mirror of
https://github.com/MariaDB/server.git
synced 2025-01-17 12:32:27 +01:00
03dbf8ccbb
"If 2 master threads with same-name temp table, slave makes bad binlog" and (two birds with one stone) for BUG#1240 "slave of slave breaks when STOP SLAVE was issud on parent slave and temp tables". Here is the design change: in a slave running with --log-slave-updates, events are now logged with the thread id they had on the master. So no more id conflicts between master threads, but introduces id conflicts between one master thread and one normal client thread connected to the slave. This is solved by storing the server id in the temp table's name. New test which requires mysql-test-run to be run with --manager, otherwise it will be skipped. Undoing a Monty's change (hum, a chill runs down my spine ;) which was "Cleanup temporary tables when slave ends" in ChangeSet 1.1572.1.1. mysql-test/mysql-test-run.sh: One new test which needs more than one slave so must be hardcoded in mysql-test-run.sh. sql/log_event.cc: The event needs to carry a slave_proxy_id (which is set at event's creation and used at event's logging). This is used for events created by ::exec_event() in the slave SQL thread: now we want to log these events with the thread id they had on the master. This is so that several same-name temp tables simultaneously created on the master end up with not the same thread id in the slave's binlog. sql/log_event.h: Query and Load need to carry a slave_proxy_id, like they carried a thread_id (to replicate temp tables well). sql/slave.cc: Do not free temp tables in the slave SQL thread. Or they will be lost when one does STOP SLAVE / START SLAVE. We even save them in rli->save_temporary_tables and set thd->temporary_tables=0 to prevent them to be freed. sql/sql_base.cc: Put the server id in the table cache key name for temp tables (we already put the slave_proxy_id, but we also need the server id in case normal clients (not slave threads) are using temp tables on the slave). sql/unireg.h: 4 more bytes, to store the server id.
30 lines
785 B
Text
30 lines
785 B
Text
slave stop;
|
|
drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
|
|
reset master;
|
|
reset slave;
|
|
drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
|
|
slave start;
|
|
reset master;
|
|
change master to master_host='127.0.0.1',master_port=9307, master_user='root';
|
|
start slave;
|
|
create temporary table t1 (a int);
|
|
create temporary table t1 (a int);
|
|
show status like 'slave_open_temp_tables';
|
|
Variable_name Value
|
|
Slave_open_temp_tables 2
|
|
create temporary table t1 (a int);
|
|
create temporary table t1 (a int);
|
|
show status like 'slave_open_temp_tables';
|
|
Variable_name Value
|
|
Slave_open_temp_tables 4
|
|
stop slave;
|
|
insert into t1 values(1);
|
|
create table t2 as select * from t1;
|
|
start slave;
|
|
show status like 'slave_open_temp_tables';
|
|
Variable_name Value
|
|
Slave_open_temp_tables 4
|
|
select * from t2;
|
|
a
|
|
1
|
|
drop table t2;
|