mirror of
https://github.com/MariaDB/server.git
synced 2025-01-31 02:51:44 +01:00
647c619393
when generating new name.
If find_uniq_filename returns an error, then this error is not
being propagated upwards, and execution does not report error to
the user (although a entry in the error log is generated).
Additionally, some more errors were ignored in new_file_impl:
- when writing the rotate event
- when reopening the index and binary log file
This patch addresses this by propagating the error up in the
execution stack. Furthermore, when rotation of the binary log
fails, an incident event is written, because there may be a
chance that some changes for a given statement, were not properly
logged. For example, in SBR, LOAD DATA INFILE statement requires
more than one event to be logged, should rotation fail while
logging part of the LOAD DATA events, then the logged data would
become inconsistent with the data in the storage engine.
mysql-test/include/restart_mysqld.inc:
Refactored restart_mysqld so that it is not hardcoded for
mysqld.1, but rather for the current server.
mysql-test/suite/binlog/t/binlog_index.test:
The error on open of index and binary log on new_file_impl
is now caught. Thence the user will get an error message.
We need to accomodate this change in the test case for the
failing FLUSH LOGS.
mysql-test/suite/rpl/t/rpl_binlog_errors-master.opt:
Sets max_binlog_size to 4096.
mysql-test/suite/rpl/t/rpl_binlog_errors.test:
Added some test cases for asserting that the error is found
and reported.
sql/handler.cc:
Catching error now returned by unlog (in ha_commit_trans) and
returning it.
sql/log.cc:
Propagating errors from new_file_impl upwards. The errors that
new_file_impl catches now are:
- error on generate_new_name
- error on writing the rotate event
- error when opening the index or the binary log file.
sql/log.h:
Changing declaration of:
- rotate_and_purge
- new_file
- new_file_without_locking
- new_file_impl
- unlog
They now return int instead of void.
sql/mysql_priv.h:
Change signature of reload_acl_and_cache so that write_to_binlog
is an int instead of bool.
sql/mysqld.cc:
Redeclaring not_used var as int instead of bool.
sql/rpl_injector.cc:
Changes to catch the return from rotate_and_purge.
sql/slave.cc:
Changes to catch the return values for new_file and rotate_relay_log.
sql/slave.h:
Changes to rotate_relay_log declaration (now returns int
instead of void).
sql/sql_load.cc:
In SBR, some logging of LOAD DATA events goes through
IO_CACHE_CALLBACK invocation at mf_iocache.c:_my_b_get. The
IO_CACHE implementation is ignoring the return value for from
these callbacks (pre_read and post_read), so we need to find out
at the end of the execution if the error is set or not in THD.
sql/sql_parse.cc:
Catching the rotate_relay_log and rotate_and_purge return values.
Semantic change in reload_acl_and_cache so that we report errors
in binlog interactions through the write_to_binlog output parameter.
If there was any failure while rotating the binary log, we should
then report the error to the client when handling SQLCOMM_FLUSH.
185 lines
5.2 KiB
Text
185 lines
5.2 KiB
Text
call mtr.add_suppression('Attempting backtrace');
|
|
call mtr.add_suppression('MSYQL_BIN_LOG::purge_logs failed to process registered files that would be purged.');
|
|
call mtr.add_suppression('MSYQL_BIN_LOG::open failed to sync the index file');
|
|
call mtr.add_suppression('Turning logging off for the whole duration of the MySQL server process.');
|
|
call mtr.add_suppression('Could not open .*');
|
|
call mtr.add_suppression('MSYQL_BIN_LOG::purge_logs failed to clean registers before purging logs.');
|
|
RESET MASTER;
|
|
flush logs;
|
|
flush logs;
|
|
flush logs;
|
|
show binary logs;
|
|
Log_name File_size
|
|
master-bin.000001 #
|
|
master-bin.000002 #
|
|
master-bin.000003 #
|
|
master-bin.000004 #
|
|
purge binary logs TO 'master-bin.000004';
|
|
Warnings:
|
|
Warning 1612 Being purged log master-bin.000001 was not found
|
|
*** must show a list starting from the 'TO' argument of PURGE ***
|
|
show binary logs;
|
|
Log_name File_size
|
|
master-bin.000004 #
|
|
reset master;
|
|
flush logs;
|
|
flush logs;
|
|
flush logs;
|
|
*** must be a warning master-bin.000001 was not found ***
|
|
Warnings:
|
|
Warning 1612 Being purged log master-bin.000001 was not found
|
|
*** must show one record, of the active binlog, left in the index file after PURGE ***
|
|
show binary logs;
|
|
Log_name File_size
|
|
master-bin.000004 #
|
|
reset master;
|
|
flush logs;
|
|
flush logs;
|
|
flush logs;
|
|
purge binary logs TO 'master-bin.000002';
|
|
ERROR HY000: Fatal error during log purge
|
|
show warnings;
|
|
Level Code Message
|
|
Warning 1377 a problem with deleting master-bin.000001; consider examining correspondence of your binlog index file to the actual binlog files
|
|
Error 1377 Fatal error during log purge
|
|
reset master;
|
|
# crash_purge_before_update_index
|
|
flush logs;
|
|
SET SESSION debug="+d,crash_purge_before_update_index";
|
|
purge binary logs TO 'master-bin.000002';
|
|
ERROR HY000: Lost connection to MySQL server during query
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000001
|
|
master-bin.000002
|
|
master-bin.000003
|
|
|
|
# crash_purge_non_critical_after_update_index
|
|
flush logs;
|
|
SET SESSION debug="+d,crash_purge_non_critical_after_update_index";
|
|
purge binary logs TO 'master-bin.000004';
|
|
ERROR HY000: Lost connection to MySQL server during query
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000004
|
|
master-bin.000005
|
|
|
|
# crash_purge_critical_after_update_index
|
|
flush logs;
|
|
SET SESSION debug="+d,crash_purge_critical_after_update_index";
|
|
purge binary logs TO 'master-bin.000006';
|
|
ERROR HY000: Lost connection to MySQL server during query
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000006
|
|
master-bin.000007
|
|
|
|
# crash_create_non_critical_before_update_index
|
|
SET SESSION debug="+d,crash_create_non_critical_before_update_index";
|
|
flush logs;
|
|
ERROR HY000: Lost connection to MySQL server during query
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000006
|
|
master-bin.000007
|
|
master-bin.000008
|
|
|
|
# crash_create_critical_before_update_index
|
|
SET SESSION debug="+d,crash_create_critical_before_update_index";
|
|
flush logs;
|
|
ERROR HY000: Lost connection to MySQL server during query
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000006
|
|
master-bin.000007
|
|
master-bin.000008
|
|
master-bin.000009
|
|
|
|
# crash_create_after_update_index
|
|
SET SESSION debug="+d,crash_create_after_update_index";
|
|
flush logs;
|
|
ERROR HY000: Lost connection to MySQL server during query
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000006
|
|
master-bin.000007
|
|
master-bin.000008
|
|
master-bin.000009
|
|
master-bin.000010
|
|
master-bin.000011
|
|
|
|
#
|
|
# This should put the server in unsafe state and stop
|
|
# accepting any command. If we inject a fault at this
|
|
# point and continue the execution the server crashes.
|
|
#
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000006
|
|
master-bin.000007
|
|
master-bin.000008
|
|
master-bin.000009
|
|
master-bin.000010
|
|
master-bin.000011
|
|
|
|
# fault_injection_registering_index
|
|
SET SESSION debug="+d,fault_injection_registering_index";
|
|
flush logs;
|
|
ERROR HY000: Can't open file: './master-bin.000012' (errno: 1)
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000006
|
|
master-bin.000007
|
|
master-bin.000008
|
|
master-bin.000009
|
|
master-bin.000010
|
|
master-bin.000011
|
|
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000006
|
|
master-bin.000007
|
|
master-bin.000008
|
|
master-bin.000009
|
|
master-bin.000010
|
|
master-bin.000011
|
|
master-bin.000012
|
|
|
|
# fault_injection_updating_index
|
|
SET SESSION debug="+d,fault_injection_updating_index";
|
|
flush logs;
|
|
ERROR HY000: Can't open file: './master-bin.000013' (errno: 1)
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000006
|
|
master-bin.000007
|
|
master-bin.000008
|
|
master-bin.000009
|
|
master-bin.000010
|
|
master-bin.000011
|
|
master-bin.000012
|
|
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000006
|
|
master-bin.000007
|
|
master-bin.000008
|
|
master-bin.000009
|
|
master-bin.000010
|
|
master-bin.000011
|
|
master-bin.000012
|
|
master-bin.000013
|
|
|
|
SET SESSION debug="";
|
|
End of tests
|