mariadb/storage/perfschema/table_setup_consumers.cc
Marc Alff 4372875aa1 Bug#53696 Performance schema engine violates the PSEA API by calling my_error()
This is a code cleanup.

The implementation of a storage engine (subclasses of handler) is not supposed
to call my_error() directly inside the engine implementation, 
but only return error codes, and report errors later at the demand
of the sql layer only (if needed), using handler::print_error().

This fix removes misplaced calls to my_error(),
and provide an implementation of print_error() instead.

Given that the sql layer implementation of create table, ha_create_table(),
does not use print_error() but returns ER_CANT_CREATE_TABLE directly,
the return code for create table statements using the performance schema
has changed to ER_CANT_CREATE_TABLE.

Adjusted the test suite accordingly.
2010-12-01 13:06:41 +01:00

211 lines
5 KiB
C++

/* Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; version 2 of the License.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software Foundation,
51 Franklin Street, Suite 500, Boston, MA 02110-1335 USA */
/**
@file storage/perfschema/table_setup_consumers.cc
Table SETUP_CONSUMERS (implementation).
*/
#include "my_global.h"
#include "my_pthread.h"
#include "table_setup_consumers.h"
#include "pfs_instr.h"
#include "pfs_events_waits.h"
#define COUNT_SETUP_CONSUMERS 8
static row_setup_consumers all_setup_consumers_data[COUNT_SETUP_CONSUMERS]=
{
{
{ C_STRING_WITH_LEN("events_waits_current") },
&flag_events_waits_current
},
{
{ C_STRING_WITH_LEN("events_waits_history") },
&flag_events_waits_history
},
{
{ C_STRING_WITH_LEN("events_waits_history_long") },
&flag_events_waits_history_long
},
{
{ C_STRING_WITH_LEN("events_waits_summary_by_thread_by_event_name") },
&flag_events_waits_summary_by_thread_by_event_name
},
{
{ C_STRING_WITH_LEN("events_waits_summary_by_event_name") },
&flag_events_waits_summary_by_event_name
},
{
{ C_STRING_WITH_LEN("events_waits_summary_by_instance") },
&flag_events_waits_summary_by_instance
},
{
{ C_STRING_WITH_LEN("file_summary_by_event_name") },
&flag_file_summary_by_event_name
},
{
{ C_STRING_WITH_LEN("file_summary_by_instance") },
&flag_file_summary_by_instance
}
};
THR_LOCK table_setup_consumers::m_table_lock;
static const TABLE_FIELD_TYPE field_types[]=
{
{
{ C_STRING_WITH_LEN("NAME") },
{ C_STRING_WITH_LEN("varchar(64)") },
{ NULL, 0}
},
{
{ C_STRING_WITH_LEN("ENABLED") },
{ C_STRING_WITH_LEN("enum(\'YES\',\'NO\')") },
{ NULL, 0}
}
};
TABLE_FIELD_DEF
table_setup_consumers::m_field_def=
{ 2, field_types };
PFS_engine_table_share
table_setup_consumers::m_share=
{
{ C_STRING_WITH_LEN("setup_consumers") },
&pfs_updatable_acl,
&table_setup_consumers::create,
NULL, /* write_row */
NULL, /* delete_all_rows */
COUNT_SETUP_CONSUMERS, /* records */
sizeof(PFS_simple_index), /* ref length */
&m_table_lock,
&m_field_def,
false /* checked */
};
PFS_engine_table* table_setup_consumers::create(void)
{
return new table_setup_consumers();
}
table_setup_consumers::table_setup_consumers()
: PFS_engine_table(&m_share, &m_pos),
m_row(NULL), m_pos(0), m_next_pos(0)
{}
void table_setup_consumers::reset_position(void)
{
m_pos.m_index= 0;
m_next_pos.m_index= 0;
}
int table_setup_consumers::rnd_next(void)
{
int result;
m_pos.set_at(&m_next_pos);
if (m_pos.m_index < COUNT_SETUP_CONSUMERS)
{
m_row= &all_setup_consumers_data[m_pos.m_index];
m_next_pos.set_after(&m_pos);
result= 0;
}
else
{
m_row= NULL;
result= HA_ERR_END_OF_FILE;
}
return result;
}
int table_setup_consumers::rnd_pos(const void *pos)
{
set_position(pos);
DBUG_ASSERT(m_pos.m_index < COUNT_SETUP_CONSUMERS);
m_row= &all_setup_consumers_data[m_pos.m_index];
return 0;
}
int table_setup_consumers::read_row_values(TABLE *table,
unsigned char *,
Field **fields,
bool read_all)
{
Field *f;
DBUG_ASSERT(m_row);
/* Set the null bits */
DBUG_ASSERT(table->s->null_bytes == 0);
for (; (f= *fields) ; fields++)
{
if (read_all || bitmap_is_set(table->read_set, f->field_index))
{
switch(f->field_index)
{
case 0: /* NAME */
set_field_varchar_utf8(f, m_row->m_name.str, m_row->m_name.length);
break;
case 1: /* ENABLED */
set_field_enum(f, (*m_row->m_enabled_ptr) ? ENUM_YES : ENUM_NO);
break;
default:
DBUG_ASSERT(false);
}
}
}
return 0;
}
int table_setup_consumers::update_row_values(TABLE *table,
const unsigned char *,
unsigned char *,
Field **fields)
{
Field *f;
enum_yes_no value;
DBUG_ASSERT(m_row);
for (; (f= *fields) ; fields++)
{
if (bitmap_is_set(table->write_set, f->field_index))
{
switch(f->field_index)
{
case 0: /* NAME */
return HA_ERR_WRONG_COMMAND;
case 1: /* ENABLED */
{
value= (enum_yes_no) get_field_enum(f);
*m_row->m_enabled_ptr= (value == ENUM_YES) ? true : false;
break;
}
default:
DBUG_ASSERT(false);
}
}
}
return 0;
}