mirror of
https://github.com/MariaDB/server.git
synced 2025-01-17 20:42:30 +01:00
821355da3c
When MySQL logged slow query information to a CSV table, it stored the query_time and lock_time values with an incorrect formula. If the time was over 59 seconds, this caused incorrect statistics (either the slow query was not logged, or the time was far from correct). This change fixes the method used to store those TIME values in the slow_log table. mysql-test/r/log_tables-big.result: BitKeeper file /benchmarks/ext3/TOSAVE/tsmith/bk/maint/51/mysql-test/r/log_tables-big.result mysql-test/t/log_tables-big-master.opt: BitKeeper file /benchmarks/ext3/TOSAVE/tsmith/bk/maint/51/mysql-test/t/log_tables-big-master.opt mysql-test/t/log_tables-big.test: BitKeeper file /benchmarks/ext3/TOSAVE/tsmith/bk/maint/51/mysql-test/t/log_tables-big.test sql/time.cc: initialize all TIME fields (except neg, which may store a needed value) in calc_time_from_sec() sql/log.cc: Log_to_csv_event_handler::log_slow(): call store_time() instead of store() for query_time and lock_time include/my_time.h: Add TIME_MAX_VALUE_SECONDS definition
35 lines
1.1 KiB
Text
35 lines
1.1 KiB
Text
# this test needs multithreaded mysqltest
|
|
-- source include/not_embedded.inc
|
|
|
|
# Test sleeps for long times
|
|
--source include/big_test.inc
|
|
|
|
# check that CSV engine was compiled in
|
|
--source include/have_csv.inc
|
|
|
|
connect (con1,localhost,root,,);
|
|
connect (con2,localhost,root,,);
|
|
|
|
#
|
|
# Bug #27638: slow logging to CSV table inserts bad query_time and lock_time values
|
|
#
|
|
connection con1;
|
|
set session long_query_time=10;
|
|
select get_lock('bug27638', 1);
|
|
connection con2;
|
|
set session long_query_time=1;
|
|
truncate table mysql.slow_log;
|
|
select get_lock('bug27638', 2);
|
|
select if (query_time between '00:00:01' and '00:00:10', 'OK', 'WRONG') as qt, sql_text from mysql.slow_log;
|
|
truncate table mysql.slow_log;
|
|
select get_lock('bug27638', 60);
|
|
select if (query_time between '00:00:59' and '00:01:10', 'OK', 'WRONG') as qt, sql_text from mysql.slow_log;
|
|
truncate table mysql.slow_log;
|
|
select get_lock('bug27638', 101);
|
|
select if (query_time between '00:01:40' and '00:01:50', 'OK', 'WRONG') as qt, sql_text from mysql.slow_log;
|
|
connection con1;
|
|
select release_lock('bug27638');
|
|
connection default;
|
|
|
|
disconnect con1;
|
|
disconnect con2;
|