mirror of
https://github.com/MariaDB/server.git
synced 2025-01-19 13:32:33 +01:00
b82094a0f8
missing after downgrade Obsolete arc/ directory and view .frm file backup support has been removed by the patch for bug 17823. However, that bugfix caused a problem with "live downgrades" of the server: if we rename some view 4 times under 5.1.29/5.0.72 and then try to rename it under 5.1.28/5.0.70 on the same database, the server fails with a error: query 'RENAME TABLE ... TO ...' failed: 6: Error on delete of '....frm-0001' (Errcode: 2) Also .frm file of that view may be lost (renamed to .frm~). The server failed because it tried to rename latest 3 backup .frm files renaming the view: the server used an integer value of the "revision" field of .frm file to extract those file names. After the fix for bug 17823 those files were not created/maintained any more, however the "revision" field was incremented as usual. So, the server failed renaming non existent files. This fix solves the problem by removing the support for "revision" .frm file field: 1. New server silently ignores existent "revision" fields in old .frm files and never write it down; 2. Old server assumes, that missing "revision" field in new .frm files means default value of 0. 3. Accordingly to the fix for bug 17823 the new server drops arc/ directory on alter/rename view, so after "live downgrade" old server begins maintenance of the arc/ directory from scratch without conflicts with .frm files.
124 lines
4.2 KiB
C++
124 lines
4.2 KiB
C++
/* -*- C++ -*- */
|
|
/* Copyright (C) 2004 MySQL AB
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */
|
|
|
|
#ifndef _PARSE_FILE_H_
|
|
#define _PARSE_FILE_H_
|
|
|
|
#define PARSE_FILE_TIMESTAMPLENGTH 19
|
|
|
|
enum file_opt_type {
|
|
FILE_OPTIONS_STRING, /* String (LEX_STRING) */
|
|
FILE_OPTIONS_ESTRING, /* Escaped string (LEX_STRING) */
|
|
FILE_OPTIONS_ULONGLONG, /* ulonglong parameter (ulonglong) */
|
|
FILE_OPTIONS_TIMESTAMP, /* timestamp (LEX_STRING have to be
|
|
allocated with length 20 (19+1) */
|
|
FILE_OPTIONS_STRLIST, /* list of escaped strings
|
|
(List<LEX_STRING>) */
|
|
FILE_OPTIONS_ULLLIST /* list of ulonglong values
|
|
(List<ulonglong>) */
|
|
};
|
|
|
|
struct File_option
|
|
{
|
|
LEX_STRING name; /* Name of the option */
|
|
int offset; /* offset to base address of value */
|
|
file_opt_type type; /* Option type */
|
|
};
|
|
|
|
|
|
/*
|
|
This hook used to catch no longer supported keys and process them for
|
|
backward compatibility.
|
|
*/
|
|
|
|
class Unknown_key_hook
|
|
{
|
|
public:
|
|
Unknown_key_hook() {} /* Remove gcc warning */
|
|
virtual ~Unknown_key_hook() {} /* Remove gcc warning */
|
|
virtual bool process_unknown_string(char *&unknown_key, gptr base,
|
|
MEM_ROOT *mem_root, char *end)= 0;
|
|
};
|
|
|
|
|
|
/* Dummy hook for parsers which do not need hook for unknown keys */
|
|
|
|
class File_parser_dummy_hook: public Unknown_key_hook
|
|
{
|
|
public:
|
|
File_parser_dummy_hook() {} /* Remove gcc warning */
|
|
virtual bool process_unknown_string(char *&unknown_key, gptr base,
|
|
MEM_ROOT *mem_root, char *end);
|
|
};
|
|
|
|
extern File_parser_dummy_hook file_parser_dummy_hook;
|
|
|
|
bool get_file_options_ulllist(char *&ptr, char *end, char *line,
|
|
gptr base, File_option *parameter,
|
|
MEM_ROOT *mem_root);
|
|
|
|
char *
|
|
parse_escaped_string(char *ptr, char *end, MEM_ROOT *mem_root, LEX_STRING *str);
|
|
|
|
class File_parser;
|
|
File_parser *sql_parse_prepare(const LEX_STRING *file_name,
|
|
MEM_ROOT *mem_root, bool bad_format_errors);
|
|
|
|
my_bool
|
|
sql_create_definition_file(const LEX_STRING *dir, const LEX_STRING *file_name,
|
|
const LEX_STRING *type,
|
|
gptr base, File_option *parameters);
|
|
my_bool rename_in_schema_file(THD *thd,
|
|
const char *schema, const char *old_name,
|
|
const char *new_name);
|
|
|
|
class File_parser: public Sql_alloc
|
|
{
|
|
char *buff, *start, *end;
|
|
LEX_STRING file_type;
|
|
my_bool content_ok;
|
|
public:
|
|
File_parser() :buff(0), start(0), end(0), content_ok(0)
|
|
{ file_type.str= 0; file_type.length= 0; }
|
|
|
|
my_bool ok() { return content_ok; }
|
|
LEX_STRING *type() { return &file_type; }
|
|
my_bool parse(gptr base, MEM_ROOT *mem_root,
|
|
struct File_option *parameters, uint required,
|
|
Unknown_key_hook *hook);
|
|
|
|
friend File_parser *sql_parse_prepare(const LEX_STRING *file_name,
|
|
MEM_ROOT *mem_root,
|
|
bool bad_format_errors);
|
|
};
|
|
|
|
|
|
/*
|
|
Custom version of standard offsetof() macro which can be used to get
|
|
offsets of members in class for non-POD types (according to the current
|
|
version of C++ standard offsetof() macro can't be used in such cases and
|
|
attempt to do so causes warnings to be emitted, OTOH in many cases it is
|
|
still OK to assume that all instances of the class has the same offsets
|
|
for the same members).
|
|
|
|
This is temporary solution which should be removed once File_parser class
|
|
and related routines are refactored.
|
|
*/
|
|
|
|
#define my_offsetof(TYPE, MEMBER) \
|
|
((size_t)((char *)&(((TYPE *)0x10)->MEMBER) - (char*)0x10))
|
|
|
|
#endif /* _PARSE_FILE_H_ */
|