mirror of
https://github.com/MariaDB/server.git
synced 2025-01-22 06:44:16 +01:00
2f78abd21b
Problem: Some system functions that could return different values on
master and slave were not marked unsafe. In particular:
GET_LOCK
IS_FREE_LOCK
IS_USED_LOCK
MASTER_POS_WAIT
RELEASE_LOCK
SLEEP
SYSDATE
VERSION
Fix: Mark these functions unsafe.
mysql-test/extra/rpl_tests/rpl_stm_000001.test:
- The test does not work in mixed mode any more, since it tries to
simulate an error in the sql thread in a query that uses get_lock.
Since get_lock now causes the query to be logged in row format,
the error didn't happen. Hence, we now force statement mode.
- Warnings must be disabled when the unsafe query is issued.
- Replaced some save_master_pos+connection slave+sync_with_master
by sync_slave_with_master.
mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
updated result file
mysql-test/suite/binlog/r/binlog_stm_row.result:
updated result file
mysql-test/suite/binlog/r/binlog_unsafe.result:
updated result file
mysql-test/suite/binlog/t/binlog_killed.test:
binlog_killed only works in statement format now, since
it switches to row mode in mixed mode.
mysql-test/suite/binlog/t/binlog_stm_mix_innodb_myisam.test:
suppress warnings for unsafe statements
mysql-test/suite/binlog/t/binlog_stm_row.test:
- Suppress warnings in test that causes warnings.
- The test sets binlog format explicitly, so no need to execute it
twice.
mysql-test/suite/binlog/t/binlog_unsafe.test:
Added test for all unsafe system functions. This test also includes
system functions that were unsafe prior to BUG#47995.
mysql-test/suite/rpl/r/rpl_err_ignoredtable.result:
updated result file
mysql-test/suite/rpl/r/rpl_get_lock.result:
updated result file
mysql-test/suite/rpl/r/rpl_nondeterministic_functions.result:
new result file
mysql-test/suite/rpl/r/rpl_stm_000001.result:
updated result file
mysql-test/suite/rpl/r/rpl_trigger.result:
updated result file
mysql-test/suite/rpl/t/rpl_err_ignoredtable.test:
- suppress warnings for unsafe statement
- replaced save_master_pos+connection slave+sync_with_master
with sync_slave_with_master
mysql-test/suite/rpl/t/rpl_get_lock.test:
update test case that causes new warnings
mysql-test/suite/rpl/t/rpl_nondeterministic_functions.test:
Added new test case for nondeterministic functions.
mysql-test/suite/rpl/t/rpl_trigger.test:
update test case that causes new warnings
sql/item_create.cc:
Marked some system functions unsafe.
sql/item_strfunc.cc:
Clarified comment related to this bug.
sql/sql_yacc.yy:
Marked sysdate unsafe.
83 lines
2.1 KiB
Text
83 lines
2.1 KiB
Text
stop slave;
|
|
drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
|
|
reset master;
|
|
reset slave;
|
|
drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
|
|
start slave;
|
|
CALL mtr.add_suppression("Statement may not be safe to log in statement format.");
|
|
create table t1 (word char(20) not null);
|
|
load data infile '../../std_data/words.dat' into table t1;
|
|
load data local infile 'MYSQL_TEST_DIR/std_data/words.dat' into table t1;
|
|
select * from t1 limit 10;
|
|
word
|
|
Aarhus
|
|
Aaron
|
|
Ababa
|
|
aback
|
|
abaft
|
|
abandon
|
|
abandoned
|
|
abandoning
|
|
abandonment
|
|
abandons
|
|
stop slave;
|
|
set password for root@"localhost" = password('foo');
|
|
start slave;
|
|
set password for root@"localhost" = password('');
|
|
create table t3(n int);
|
|
insert into t3 values(1),(2);
|
|
select * from t3;
|
|
n
|
|
1
|
|
2
|
|
select sum(length(word)) from t1;
|
|
sum(length(word))
|
|
1022
|
|
drop table t1,t3;
|
|
create table t1 (n int) engine=myisam;
|
|
reset master;
|
|
stop slave;
|
|
reset slave;
|
|
lock tables t1 read;
|
|
start slave;
|
|
unlock tables;
|
|
create table t2(id int);
|
|
insert into t2 values(connection_id());
|
|
create temporary table t3(n int);
|
|
insert into t3 select get_lock('crash_lock%20C', 1) from t2;
|
|
update t1 set n = n + get_lock('crash_lock%20C', 2);
|
|
select (@id := id) - id from t2;
|
|
(@id := id) - id
|
|
0
|
|
kill @id;
|
|
drop table t2;
|
|
Got one of the listed errors
|
|
set global sql_slave_skip_counter=1;
|
|
start slave;
|
|
select count(*) from t1;
|
|
count(*)
|
|
5000
|
|
drop table t1;
|
|
create table t1 (n int);
|
|
insert into t1 values(3456);
|
|
insert into mysql.user (Host, User, Password)
|
|
VALUES ("10.10.10.%", "blafasel2", password("blafasel2"));
|
|
Warnings:
|
|
Warning 1364 Field 'ssl_cipher' doesn't have a default value
|
|
Warning 1364 Field 'x509_issuer' doesn't have a default value
|
|
Warning 1364 Field 'x509_subject' doesn't have a default value
|
|
select select_priv,user from mysql.user where user = _binary'blafasel2';
|
|
select_priv user
|
|
N blafasel2
|
|
update mysql.user set Select_priv = "Y" where User= _binary"blafasel2";
|
|
select select_priv,user from mysql.user where user = _binary'blafasel2';
|
|
select_priv user
|
|
Y blafasel2
|
|
select n from t1;
|
|
n
|
|
3456
|
|
select select_priv,user from mysql.user where user = _binary'blafasel2';
|
|
select_priv user
|
|
Y blafasel2
|
|
drop table t1;
|
|
delete from mysql.user where user="blafasel2";
|