mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 12:02:42 +01:00
d1c2e8508f
Optimizer erroneously translated LEFT JOIN into INNER JOIN. It leads to cutting rows with NULL right side. It happens because Item_row uses not_null_tables() method form the base(Item) class and does not calculate 'null tables' properly. The fix is adding calculation of 'not null tables' to Item_row. mysql-test/r/join_outer.result: test result mysql-test/t/join_outer.test: test case sql/item_row.cc: adding calculation of 'not null tables' to Item_row. sql/item_row.h: adding calculation of 'not null tables' to Item_row.
81 lines
2.5 KiB
C++
81 lines
2.5 KiB
C++
/* Copyright (C) 2000 MySQL AB
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */
|
|
|
|
class Item_row: public Item
|
|
{
|
|
Item **items;
|
|
table_map used_tables_cache, not_null_tables_cache;
|
|
uint arg_count;
|
|
bool const_item_cache;
|
|
bool with_null;
|
|
public:
|
|
Item_row(List<Item> &);
|
|
Item_row(Item_row *item):
|
|
Item(),
|
|
items(item->items),
|
|
used_tables_cache(item->used_tables_cache),
|
|
not_null_tables_cache(0),
|
|
arg_count(item->arg_count),
|
|
const_item_cache(item->const_item_cache),
|
|
with_null(0)
|
|
{}
|
|
|
|
enum Type type() const { return ROW_ITEM; };
|
|
void illegal_method_call(const char *);
|
|
bool is_null() { return null_value; }
|
|
void make_field(Send_field *)
|
|
{
|
|
illegal_method_call((const char*)"make_field");
|
|
};
|
|
double val_real()
|
|
{
|
|
illegal_method_call((const char*)"val");
|
|
return 0;
|
|
};
|
|
longlong val_int()
|
|
{
|
|
illegal_method_call((const char*)"val_int");
|
|
return 0;
|
|
};
|
|
String *val_str(String *)
|
|
{
|
|
illegal_method_call((const char*)"val_str");
|
|
return 0;
|
|
};
|
|
my_decimal *val_decimal(my_decimal *)
|
|
{
|
|
illegal_method_call((const char*)"val_decimal");
|
|
return 0;
|
|
};
|
|
bool fix_fields(THD *thd, Item **ref);
|
|
void cleanup();
|
|
void split_sum_func(THD *thd, Item **ref_pointer_array, List<Item> &fields);
|
|
table_map used_tables() const { return used_tables_cache; };
|
|
bool const_item() const { return const_item_cache; };
|
|
enum Item_result result_type() const { return ROW_RESULT; }
|
|
void update_used_tables();
|
|
table_map not_null_tables() const { return not_null_tables_cache; }
|
|
virtual void print(String *str, enum_query_type query_type);
|
|
|
|
bool walk(Item_processor processor, bool walk_subquery, uchar *arg);
|
|
Item *transform(Item_transformer transformer, uchar *arg);
|
|
|
|
uint cols() { return arg_count; }
|
|
Item* element_index(uint i) { return items[i]; }
|
|
Item** addr(uint i) { return items + i; }
|
|
bool check_cols(uint c);
|
|
bool null_inside() { return with_null; };
|
|
void bring_value();
|
|
};
|