mirror of
https://github.com/MariaDB/server.git
synced 2025-01-18 13:02:28 +01:00
9907e970ae
The crash was caused by invalid sequence of handler::** calls: ha_smth->index_init(); ha_smth->index_next_same(); (2) (2) is an invalid call as it was not preceeded by any 'scan setup' call like index_first() or index_read(). The cause was that QUICK_SELECT::reset() didn't "fully reset" the quick select- current QUICK_RANGE wasn't forgotten, and quick select might attempt to continue reading the range, which would result in the above mentioned invalid sequence of handler calls. 5.x versions are not affected by the bug - they already have the missing "range=NULL" clause. mysql-test/r/innodb_mysql.result: Testcase for BUG#21077 mysql-test/t/innodb_mysql.test: Testcase for BUG#21077 sql/opt_range.h: BUG#21077: Possible crash caused by invalid sequence of handler::* calls: - Make QUICK_SELECT::reset() really reset the quick select
172 lines
4.6 KiB
C++
172 lines
4.6 KiB
C++
/* Copyright (C) 2000 MySQL AB & MySQL Finland AB & TCX DataKonsult AB
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */
|
|
|
|
|
|
/* classes to use when handling where clause */
|
|
|
|
#ifndef _opt_range_h
|
|
#define _opt_range_h
|
|
|
|
#ifdef USE_PRAGMA_INTERFACE
|
|
#pragma interface /* gcc class implementation */
|
|
#endif
|
|
|
|
#define NO_MIN_RANGE 1
|
|
#define NO_MAX_RANGE 2
|
|
#define NEAR_MIN 4
|
|
#define NEAR_MAX 8
|
|
#define UNIQUE_RANGE 16
|
|
#define EQ_RANGE 32
|
|
#define NULL_RANGE 64
|
|
#define GEOM_FLAG 128
|
|
|
|
|
|
typedef struct st_key_part {
|
|
uint16 key,part, store_length, length;
|
|
uint8 null_bit;
|
|
Field *field;
|
|
Field::imagetype image_type;
|
|
} KEY_PART;
|
|
|
|
|
|
class QUICK_RANGE :public Sql_alloc {
|
|
public:
|
|
char *min_key,*max_key;
|
|
uint16 min_length,max_length,flag;
|
|
#ifdef HAVE_purify
|
|
uint16 dummy; /* Avoid warnings on 'flag' */
|
|
#endif
|
|
QUICK_RANGE(); /* Full range */
|
|
QUICK_RANGE(const char *min_key_arg,uint min_length_arg,
|
|
const char *max_key_arg,uint max_length_arg,
|
|
uint flag_arg)
|
|
: min_key((char*) sql_memdup(min_key_arg,min_length_arg+1)),
|
|
max_key((char*) sql_memdup(max_key_arg,max_length_arg+1)),
|
|
min_length((uint16) min_length_arg),
|
|
max_length((uint16) max_length_arg),
|
|
flag((uint16) flag_arg)
|
|
{
|
|
#ifdef HAVE_purify
|
|
dummy=0;
|
|
#endif
|
|
}
|
|
};
|
|
|
|
|
|
class QUICK_SELECT {
|
|
public:
|
|
bool next,dont_free,sorted;
|
|
int error;
|
|
uint index, max_used_key_length, used_key_parts;
|
|
TABLE *head;
|
|
handler *file;
|
|
byte *record;
|
|
List<QUICK_RANGE> ranges;
|
|
List_iterator<QUICK_RANGE> it;
|
|
QUICK_RANGE *range;
|
|
MEM_ROOT alloc;
|
|
|
|
KEY_PART *key_parts;
|
|
KEY_PART_INFO *key_part_info;
|
|
ha_rows records;
|
|
double read_time;
|
|
|
|
QUICK_SELECT(THD *thd, TABLE *table,uint index_arg,bool no_alloc=0);
|
|
virtual ~QUICK_SELECT();
|
|
virtual void reset(void);
|
|
int init()
|
|
{
|
|
key_part_info= head->key_info[index].key_part;
|
|
return error=file->ha_index_init(index);
|
|
}
|
|
virtual int get_next();
|
|
virtual bool reverse_sorted() { return 0; }
|
|
bool unique_key_range();
|
|
};
|
|
|
|
|
|
class QUICK_SELECT_GEOM: public QUICK_SELECT
|
|
{
|
|
public:
|
|
QUICK_SELECT_GEOM(THD *thd, TABLE *table, uint index_arg, bool no_alloc)
|
|
:QUICK_SELECT(thd, table, index_arg, no_alloc)
|
|
{};
|
|
virtual int get_next();
|
|
};
|
|
|
|
|
|
class QUICK_SELECT_DESC: public QUICK_SELECT
|
|
{
|
|
public:
|
|
QUICK_SELECT_DESC(QUICK_SELECT *q, uint used_key_parts);
|
|
int get_next();
|
|
bool reverse_sorted() { return 1; }
|
|
private:
|
|
int cmp_prev(QUICK_RANGE *range);
|
|
bool range_reads_after_key(QUICK_RANGE *range);
|
|
#ifdef NOT_USED
|
|
bool test_if_null_range(QUICK_RANGE *range, uint used_key_parts);
|
|
#endif
|
|
void reset(void);
|
|
List<QUICK_RANGE> rev_ranges;
|
|
List_iterator<QUICK_RANGE> rev_it;
|
|
};
|
|
|
|
|
|
class SQL_SELECT :public Sql_alloc {
|
|
public:
|
|
QUICK_SELECT *quick; // If quick-select used
|
|
COND *cond; // where condition
|
|
TABLE *head;
|
|
IO_CACHE file; // Positions to used records
|
|
ha_rows records; // Records in use if read from file
|
|
double read_time; // Time to read rows
|
|
key_map quick_keys; // Possible quick keys
|
|
key_map needed_reg; // Possible quick keys after prev tables.
|
|
table_map const_tables,read_tables;
|
|
bool free_cond;
|
|
|
|
SQL_SELECT();
|
|
~SQL_SELECT();
|
|
void cleanup();
|
|
bool check_quick(THD *thd, bool force_quick_range, ha_rows limit)
|
|
{
|
|
key_map tmp;
|
|
tmp.set_all();
|
|
return test_quick_select(thd, tmp, 0, limit, force_quick_range) < 0;
|
|
}
|
|
inline bool skip_record() { return cond ? cond->val_int() == 0 : 0; }
|
|
int test_quick_select(THD *thd, key_map keys, table_map prev_tables,
|
|
ha_rows limit, bool force_quick_range);
|
|
};
|
|
|
|
|
|
class FT_SELECT: public QUICK_SELECT {
|
|
public:
|
|
FT_SELECT(THD *thd, TABLE *table, uint key):
|
|
QUICK_SELECT (thd, table, key, 1) { init(); }
|
|
~FT_SELECT() { file->ft_end(); }
|
|
int init() { return error= file->ft_init(); }
|
|
int get_next() { return error= file->ft_read(record); }
|
|
};
|
|
|
|
|
|
QUICK_SELECT *get_quick_select_for_ref(THD *thd, TABLE *table,
|
|
struct st_table_ref *ref);
|
|
|
|
uint get_index_for_order(TABLE *table, ORDER *order, ha_rows limit);
|
|
|
|
#endif
|