mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 12:02:42 +01:00
5bcb1d6532
The used code is largely based on code from Tencent
The problem is that in some rare cases there may be a conflict between .frm
files and the files in the storage engine. In this case the DROP TABLE
was not able to properly drop the table.
Some MariaDB/MySQL forks has solved this by adding a FORCE option to
DROP TABLE. After some discussion among MariaDB developers, we concluded
that users expects that DROP TABLE should always work, even if the
table would not be consistent. There should not be a need to use a
separate keyword to ensure that the table is really deleted.
The used solution is:
- If a .frm table doesn't exists, try dropping the table from all storage
engines.
- If the .frm table exists but the table does not exist in the engine
try dropping the table from all storage engines.
- Update storage engines using many table files (.CVS, MyISAM, Aria) to
succeed with the drop even if some of the files are missing.
- Add HTON_AUTOMATIC_DELETE_TABLE to handlerton's where delete_table()
is not needed and always succeed. This is used by ha_delete_table_force()
to know which handlers to ignore when trying to drop a table without
a .frm file.
The disadvantage of this solution is that a DROP TABLE on a non existing
table will be a bit slower as we have to ask all active storage engines
if they know anything about the table.
Other things:
- Added a new flag MY_IGNORE_ENOENT to my_delete() to not give an error
if the file doesn't exist. This simplifies some of the code.
- Don't clear thd->error in ha_delete_table() if there was an active
error. This is a bug fix.
- handler::delete_table() will not abort if first file doesn't exists.
This is bug fix to handle the case when a drop table was aborted in
the middle.
- Cleaned up mysql_rm_table_no_locks() to ensure that if_exists uses
same code path as when it's not used.
- Use non_existing_Table_error() to detect if table didn't exists.
Old code used different errors tests in different position.
- Table_triggers_list::drop_all_triggers() now drops trigger file if
it can't be parsed instead of leaving it hanging around (bug fix)
- InnoDB doesn't anymore print error about .frm file out of sync with
InnoDB directory if .frm file does not exists. This change was required
to be able to try to drop an InnoDB file when .frm doesn't exists.
- Fixed bug in mi_delete_table() where the .MYD file would not be dropped
if the .MYI file didn't exists.
- Fixed memory leak in Mroonga when deleting non existing table
- Fixed memory leak in Connect when deleting non existing table
Bugs fixed introduced by the original version of this commit:
MDEV-22826 Presence of Spider prevents tables from being force-deleted from
other engines
50 lines
1.5 KiB
C
50 lines
1.5 KiB
C
/*
|
|
Copyright (c) 2000, 2010, Oracle and/or its affiliates
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1335 USA */
|
|
|
|
/*
|
|
deletes a table
|
|
*/
|
|
|
|
#include "fulltext.h"
|
|
|
|
#ifndef HAVE_PSI_INTERFACE
|
|
#define PSI_file_key int
|
|
#define mi_key_file_kfile 0
|
|
#define mi_key_file_dfile 0
|
|
#endif
|
|
|
|
int mi_delete_table(const char *name)
|
|
{
|
|
int error= 0;
|
|
DBUG_ENTER("mi_delete_table");
|
|
|
|
#ifdef EXTRA_DEBUG
|
|
check_table_is_closed(name,"delete");
|
|
#endif
|
|
|
|
if (mysql_file_delete_with_symlink(mi_key_file_kfile, name, MI_NAME_IEXT,
|
|
MYF(MY_WME)))
|
|
error= my_errno;
|
|
if (mysql_file_delete_with_symlink(mi_key_file_dfile, name, MI_NAME_DEXT,
|
|
MYF(MY_WME)))
|
|
error= my_errno;
|
|
|
|
// optionally present:
|
|
mysql_file_delete_with_symlink(mi_key_file_dfile, name, ".OLD", MYF(0));
|
|
mysql_file_delete_with_symlink(mi_key_file_dfile, name, ".TMD", MYF(0));
|
|
|
|
DBUG_RETURN(error);
|
|
}
|