mirror of
https://github.com/MariaDB/server.git
synced 2025-01-20 14:02:32 +01:00
09c80e12c5
Major replication test framework cleanup. This does the following:
- Ensure that all tests clean up the replication state when they
finish, by making check-testcase check the output of SHOW SLAVE STATUS.
This implies:
- Slave must not be running after test finished. This is good
because it removes the risk for sporadic errors in subsequent
tests when a test forgets to sync correctly.
- Slave SQL and IO errors must be cleared when test ends. This is
good because we will notice if a test gets an unexpected error in
the slave threads near the end.
- We no longer have to clean up before a test starts.
- Ensure that all tests that wait for an error in one of the slave
threads waits for a specific error. It is no longer possible to
source wait_for_slave_[sql|io]_to_stop.inc when there is an error
in one of the slave threads. This is good because:
- If a test expects an error but there is a bug that causes
another error to happen, or if it stops the slave thread without
an error, then we will notice.
- When developing tests, wait_for_*_to_[start|stop].inc will fail
immediately if there is an error in the relevant slave thread.
Before this patch, we had to wait for the timeout.
- Remove duplicated and repeated code for setting up unusual replication
topologies. Now, there is a single file that is capable of setting
up arbitrary topologies (include/rpl_init.inc, but
include/master-slave.inc is still available for the most common
topology). Tests can now end with include/rpl_end.inc, which will clean
up correctly no matter what topology is used. The topology can be
changed with include/rpl_change_topology.inc.
- Improved debug information when tests fail. This includes:
- debug info is printed on all servers configured by include/rpl_init.inc
- User can set $rpl_debug=1, which makes auxiliary replication files
print relevant debug info.
- Improved documentation for all auxiliary replication files. Now they
describe purpose, usage, parameters, and side effects.
- Many small code cleanups:
- Made have_innodb.inc output a sensible error message.
- Moved contents of rpl000017-slave.sh into rpl000017.test
- Added mysqltest variables that expose the current state of
disable_warnings/enable_warnings and friends.
- Too many to list here: see per-file comments for details.
57 lines
1.7 KiB
PHP
57 lines
1.7 KiB
PHP
# ==== Purpose ====
|
|
#
|
|
# Write the contents of $write_var to file $write_to_file.
|
|
#
|
|
#
|
|
# ==== Usage ====
|
|
#
|
|
# --let $write_var = <value>
|
|
# --let $write_to_file = [<file>|GENERATE]
|
|
# --source include/write_var_to_file.inc
|
|
#
|
|
# $write_var is evaluated in sql 'string' context, so escapes like \n
|
|
# are interpolated.
|
|
#
|
|
# $write_to_file can be either a filename, or the special string
|
|
# GENERATE. If it is GENERATE, a unique filename is generated (based
|
|
# on UUID()). The filename is saved in $write_to_file so that it can
|
|
# be retrieved later.
|
|
#
|
|
#
|
|
# ==== Implementation ====
|
|
#
|
|
# We can't use mysqltest's write_file because it does not evaluate
|
|
# variables. We can't use '--exec echo $write_var > $write_file'
|
|
# because it will use \n\r line terminator under windows. So the only
|
|
# working way is mysql's SELECT INTO DUMPFILE, which is subject to
|
|
# @@secure_file_priv. That makes this more complex than you might
|
|
# expect.
|
|
|
|
if (`SELECT '$write_to_file' = ''`)
|
|
{
|
|
--die You must set the mysqltest variable \$write_to_file before you source include/write_var_to_file.inc
|
|
}
|
|
|
|
if (`SELECT '$write_to_file' = 'GENERATE'`)
|
|
{
|
|
--let $_wvtf_suffix= `SELECT UUID()`
|
|
--let $write_to_file= $MYSQLTEST_VARDIR/tmp/_var_file_$_wvtf_suffix.inc
|
|
}
|
|
|
|
--error 0,1
|
|
--remove_file $write_to_file
|
|
|
|
if (`SELECT LENGTH(@@secure_file_priv) > 0`)
|
|
{
|
|
--let $_wvtf_secure_file_priv= `SELECT @@secure_file_priv`
|
|
--let $_wvtf_suffix= `SELECT UUID()`
|
|
--let $_wvtf_tmp_file= $_wvtf_secure_file_priv/_wvtf_$_wvtf_suffix
|
|
|
|
--eval SELECT '$write_var' INTO DUMPFILE '$_wvtf_tmp_file'
|
|
--copy_file $_wvtf_tmp_file $write_to_file
|
|
--remove_file $_wvtf_tmp_file
|
|
}
|
|
if (`SELECT LENGTH(@@secure_file_priv) = 0`)
|
|
{
|
|
--eval SELECT '$write_var' INTO DUMPFILE '$write_to_file'
|
|
}
|