mirror of
https://github.com/MariaDB/server.git
synced 2025-01-17 20:42:30 +01:00
59eaf292de
Added missing DBUG_xxx_RETURN statements Fixed some usage of not initialized variables (as found by valgrind) Ensure that we don't remove locked tables used as name locks from open table cache until unlock_table_names() are called. This was fixed by having drop_locked_name() returning any table used as a name lock so that we can free it in unlock_table_names() This will allow Tomas to continue with his work to use namelocks to syncronize things. Note: valgrind still produces a lot of warnings about using not initialized code and shows memory loss errors when running the ndb tests BitKeeper/etc/ignore: added mysql-test/r/*.log client/mysqltest.c: Change type of variables to get rid of compiler warnings More debugging Fix memory leak mysql-test/mysql-test-run.sh: Collect warnings about missing DBUG_RETURN statements mysql-test/r/lock_multi.result: Add test of new code mysql-test/r/ndb_condition_pushdown.result: Drop used tables before test mysql-test/t/lock_multi.test: Add test of new code mysql-test/t/ndb_condition_pushdown.test: Drop used tables before test mysql-test/valgrind.supp: Ignore 'safe' warnings from libz (when used with archive) sql/event.cc: More comments Simplify code Fixed memory leak found by valgrind sql/ha_archive.cc: Remove compiler warnings (Wrong handlerton structure and signed/unsigned comparison) sql/ha_berkeley.cc: Fixed compiler warning sql/ha_blackhole.cc: Fixed compiler warning sql/ha_federated.cc: Fixed compiler warning sql/ha_heap.cc: Fixed compiler warning sql/ha_myisam.cc: Fixed compiler warning sql/ha_myisammrg.cc: Fixed compiler warning sql/ha_ndbcluster.cc: Fixed compiler warnings sql/ha_partition.cc: Fixed compiler warning Fixed error noticed by valgrind in ha_partition::rnd_init() sql/handler.cc: Fixed compiler warning sql/handler.h: Fixed compiler warning sql/item.cc: Fixed compiler warning sql/item_xmlfunc.cc: Fixed warning from valgrind when calling memcpy with wrong address sql/lock.cc: More debugging sql/log.cc: Fixed compiler warning Indentation fixes sql/log.h: Fixed compiler warning sql/mysql_priv.h: Changed prototype for 'drop_locked_tables' sql/opt_range.cc: Indentation fix sql/password.c: Removed compiler warnings sql/set_var.cc: Fixed compiler warning sql/slave.cc: Fixed compiler warning sql/sp_head.cc: Fixed compiler warning sql/sql_acl.cc: Fixed compiler warning sql/sql_analyse.cc: Added missing DBUG_RETURN statements sql/sql_base.cc: Removed de-reference of not initialized pointer More comments drop_locked_tables() changed to not delete tables used for name locking Fixed compiler warnings sql/sql_delete.cc: Fixed usage of not initialized variable (deleted could be referenced in some not common error conditions) sql/sql_parse.cc: Added missing DBUG_VOID_RETURN Simplify code sql/sql_partition.cc: Fixed usage of wrong variable (noticed by valgrind) sql/sql_plugin.cc: Removed compiler warning sql/sql_show.cc: Removed compiler warning sql/sql_table.cc: Ensure that we don't remove locked tables used as name locks from open table cache until unlock_table_names() are called. This was fixed by having drop_locked_name() returning any table used as a name lock so that we can free it in unlock_table_names() This will allow Tomas to continue with his work to use namelocks to syncronize things. Fixed wrong test of 'table_type' (path_length could otherwise be accessed uninitialized) Remove compile warnings about not initialized variables. sql/sql_yacc.yy: Ensure that no_write_to_binlog is properly initialized (Was accessed uninitialized by partition code) sql/table.cc: Removed valgrind warnings (not fatal) Removed compiler warnings sql/tztime.cc: Removed valgrind warning storage/ndb/include/ndbapi/NdbIndexStat.hpp: Removed compiler warning
175 lines
2.6 KiB
Text
175 lines
2.6 KiB
Text
#
|
|
# Suppress some common (not fatal) errors in system libraries found by valgrind
|
|
#
|
|
|
|
#
|
|
# Pthread doesn't free all thread specific memory before program exists
|
|
#
|
|
{
|
|
pthread allocate_tls memory loss
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:_dl_allocate_tls
|
|
fun:allocate_stack
|
|
fun:pthread_create@@GLIBC_2.1
|
|
}
|
|
|
|
{
|
|
pthread allocate_dtv memory loss
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:allocate_dtv
|
|
fun:_dl_allocate_tls_storage
|
|
fun:__GI__dl_allocate_tls
|
|
fun:pthread_create
|
|
}
|
|
|
|
{
|
|
pthread allocate_dtv memory loss second
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:allocate_dtv
|
|
fun:_dl_allocate_tls
|
|
fun:pthread_create*
|
|
}
|
|
|
|
{
|
|
pthread allocate_dtv memory loss second
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:allocate_dtv
|
|
fun:_dl_allocate_tls
|
|
fun:pthread_create*
|
|
}
|
|
|
|
{
|
|
pthread memalign memory loss
|
|
Memcheck:Leak
|
|
fun:memalign
|
|
fun:_dl_allocate_tls_storage
|
|
fun:__GI__dl_allocate_tls
|
|
fun:pthread_create
|
|
}
|
|
|
|
{
|
|
pthread pthread_key_create
|
|
Memcheck:Leak
|
|
fun:malloc
|
|
fun:*
|
|
fun:*
|
|
fun:pthread_key_create
|
|
fun:my_thread_global_init
|
|
}
|
|
|
|
{
|
|
pthread strstr uninit
|
|
Memcheck:Cond
|
|
fun:strstr
|
|
obj:/lib/tls/libpthread.so.*
|
|
obj:/lib/tls/libpthread.so.*
|
|
fun:call_init
|
|
fun:_dl_init
|
|
obj:/lib/ld-*.so
|
|
}
|
|
|
|
{
|
|
pthread strstr uninit
|
|
Memcheck:Cond
|
|
fun:strstr
|
|
obj:/lib/tls/libpthread.so.*
|
|
obj:/lib/tls/libpthread.so.*
|
|
fun:call_init
|
|
fun:_dl_init
|
|
obj:/lib/ld-*.so
|
|
}
|
|
|
|
{
|
|
pthread errno
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:_dlerror_run
|
|
fun:dlsym
|
|
fun:__errno_location
|
|
}
|
|
|
|
|
|
#
|
|
# Warnings in libz becasue it works with aligned memory(?)
|
|
#
|
|
|
|
{
|
|
libz tr_flush_block
|
|
Memcheck:Cond
|
|
fun:_tr_flush_block
|
|
fun:deflate_slow
|
|
fun:deflate
|
|
fun:do_flush
|
|
fun:gzclose
|
|
}
|
|
|
|
{
|
|
libz tr_flush_block2
|
|
Memcheck:Cond
|
|
fun:_tr_flush_block
|
|
fun:deflate_slow
|
|
fun:deflate
|
|
fun:compress2
|
|
}
|
|
|
|
{
|
|
libz longest_match
|
|
Memcheck:Cond
|
|
fun:longest_match
|
|
fun:deflate_slow
|
|
fun:deflate
|
|
fun:do_flush
|
|
}
|
|
|
|
{
|
|
libz longest_match2
|
|
Memcheck:Cond
|
|
fun:longest_match
|
|
fun:deflate_slow
|
|
fun:deflate
|
|
fun:compress2
|
|
}
|
|
|
|
{
|
|
libz deflate
|
|
Memcheck:Cond
|
|
obj:*/libz.so.*
|
|
obj:*/libz.so.*
|
|
fun:deflate
|
|
fun:compress2
|
|
}
|
|
|
|
{
|
|
libz deflate2
|
|
Memcheck:Cond
|
|
obj:*/libz.so.*
|
|
obj:*/libz.so.*
|
|
fun:deflate
|
|
obj:*/libz.so.*
|
|
fun:gzflush
|
|
}
|
|
|
|
{
|
|
libz deflate3
|
|
Memcheck:Cond
|
|
obj:*/libz.so.*
|
|
obj:*/libz.so.*
|
|
fun:deflate
|
|
fun:do_flush
|
|
}
|
|
|
|
#
|
|
# Warning from my_thread_init becasue mysqld dies before kill thread exists
|
|
#
|
|
|
|
{
|
|
my_thread_init kill thread memory loss second
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:my_thread_init
|
|
fun:kill_server_thread
|
|
}
|