mirror of
https://github.com/MariaDB/server.git
synced 2025-01-19 13:32:33 +01:00
9ae9f84ef4
binlog-db-db / binlog-ignore-db
InnoDB will return an error if statement based replication is used
along with transaction isolation level READ-COMMITTED (or weaker),
even if the statement in question is filtered out according to the
binlog-do-db rules set. In this case, an error should not be printed.
This patch addresses this issue by extending the existing check in
external_lock to take into account the filter rules before deciding to
print an error. Furthermore, it also changes decide_logging_format to
take into consideration whether the statement is filtered out from
binlog before decision is made.
sql/sql_base.cc:
Changed the check on decide_logging_format to take into account
whether statement is filtered or not in SBR.
sql/sql_class.cc:
Added the thd_binlog_filter_ok to INNODB_COMPATIBILITY_HOOKS set.
storage/innobase/handler/ha_innodb.cc:
Extended check in external_lock to take into consideration the
filtering when deciding to throw an error.
storage/innobase/handler/ha_innodb.h:
Added declaration of new hook.
storage/innodb_plugin/handler/ha_innodb.cc:
Extended check in external_lock to take into consideration the
filtering when deciding to throw an error.
storage/innodb_plugin/handler/ha_innodb.h:
Added declaration of new hook.
90 lines
2.8 KiB
Text
90 lines
2.8 KiB
Text
# BUG#42829: binlogging enabled for all schemas regardless of
|
|
# binlog-db-db / binlog-ignore-db
|
|
#
|
|
# WHAT
|
|
# ====
|
|
#
|
|
# We want to test whether filtered events from binlog will cause
|
|
# raising an error mentioning that statement is unable to be logged or
|
|
# not, when:
|
|
#
|
|
# 1. isolation level READ-COMMITTED; AND
|
|
#
|
|
# 2. using InnoDB engine; AND
|
|
#
|
|
# 3. using SBL (in which case InnoDB will only allow RBL).
|
|
#
|
|
# HOW
|
|
# ===
|
|
#
|
|
# The test is implemented as follows:
|
|
#
|
|
# i) set tx_isolation to read-committed.
|
|
#
|
|
# ii) create two databases (one filtered other not - using
|
|
# binlog-do-db)
|
|
#
|
|
# iii) Create statements that are to be filtered on filtered db
|
|
#
|
|
# - At this point, before fix, an error would be raised
|
|
#
|
|
# iv) do the same thing for not the filtered database and check
|
|
# that events throw an error:
|
|
#
|
|
# - Error: ER_BINLOG_STMT_MODE_AND_ROW_ENGINE
|
|
#
|
|
|
|
-- source include/have_log_bin.inc
|
|
-- source include/have_innodb.inc
|
|
-- source include/have_binlog_format_statement.inc
|
|
|
|
SET @old_isolation_level= @@session.tx_isolation;
|
|
SET @@session.tx_isolation= 'READ-COMMITTED';
|
|
|
|
-- let $engine= InnoDB
|
|
-- let $filtered= b42829_filtered
|
|
-- let $not_filtered= b42829
|
|
|
|
-- eval CREATE DATABASE $not_filtered
|
|
-- eval use $not_filtered
|
|
-- eval CREATE TABLE t1 (x int, y int) engine=$engine
|
|
-- eval CREATE TABLE t2 (x int, y int) engine=$engine
|
|
|
|
-- eval CREATE DATABASE $filtered
|
|
-- eval use $filtered
|
|
-- eval CREATE TABLE t1 (x int, y int) engine=$engine
|
|
-- eval CREATE TABLE t2 (x int, y int) engine=$engine
|
|
|
|
SET @@session.sql_log_bin= 0;
|
|
-- eval INSERT INTO $filtered.t1 VALUES (100,100)
|
|
-- eval INSERT INTO $not_filtered.t1 VALUES (100,100)
|
|
SET @@session.sql_log_bin= 1;
|
|
|
|
-- echo ### assertion: the inserts will not raise log error because
|
|
-- echo ### binlog-do-db is filtering used database
|
|
INSERT INTO t2 VALUES (1,2), (1,3), (1,4);
|
|
INSERT INTO t1 SELECT * FROM t2;
|
|
|
|
-- echo ### assertion: assert that despite updating a not filtered
|
|
-- echo ### database this wont trigger an error as the
|
|
-- echo ### used database is the filtered one.
|
|
-- eval UPDATE $filtered.t1 ft1, $not_filtered.t1 nft1 SET ft1.x=1, nft1.x=2
|
|
|
|
-- eval use $not_filtered
|
|
-- echo ### assertion: the statements *will* raise log error because
|
|
-- echo ### binlog-do-db is not filtering used database
|
|
BEGIN;
|
|
-- error ER_BINLOG_LOGGING_IMPOSSIBLE
|
|
INSERT INTO t2 VALUES (1,2), (1,3), (1,4);
|
|
-- error ER_BINLOG_LOGGING_IMPOSSIBLE
|
|
-- eval UPDATE $filtered.t1 ft1, $not_filtered.t1 nft1 SET ft1.x=1, nft1.x=2
|
|
-- error ER_BINLOG_LOGGING_IMPOSSIBLE
|
|
INSERT INTO t1 SELECT * FROM t2;
|
|
COMMIT;
|
|
|
|
-- echo ### assertion: filtered events did not make into the binlog
|
|
source include/show_binlog_events.inc;
|
|
|
|
-- eval DROP DATABASE $not_filtered
|
|
-- eval DROP DATABASE $filtered
|
|
SET @@session.tx_isolation= @old_isolation_level;
|