mirror of
https://github.com/MariaDB/server.git
synced 2025-01-31 02:51:44 +01:00
0c5d1342ae
This commit implements two phase binloggable ALTER.
When a new
@@session.binlog_alter_two_phase = YES
ALTER query gets logged in two parts, the START ALTER and the COMMIT
or ROLLBACK ALTER. START Alter is written in binlog as soon as
necessary locks have been acquired for the table. The timing is
such that any concurrent DML:s that update the same table are either
committed, thus logged into binary log having done work on the old
version of the table, or will be queued for execution on its new
version.
The "COMPLETE" COMMIT or ROLLBACK ALTER are written at the very point
of a normal "single-piece" ALTER that is after the most of
the query work is done. When its result is positive COMMIT ALTER is
written, otherwise ROLLBACK ALTER is written with specific error
happened after START ALTER phase.
Replication of two-phase binloggable ALTER is
cross-version safe. Specifically the OLD slave merely does not
recognized the start alter part, still being able to process and
memorize its gtid.
Two phase logged ALTER is read from binlog by mysqlbinlog to produce
BINLOG 'string', where 'string' contains base64 encoded
Query_log_event containing either the start part of ALTER, or a
completion part. The Query details can be displayed with `-v` flag,
similarly to ROW format events. Notice, mysqlbinlog output containing
parts of two-phase binloggable ALTER is processable correctly only by
binlog_alter_two_phase server.
@@log_warnings > 2 can reveal details of binlogging and slave side
processing of the ALTER parts.
The current commit also carries fixes to the following list of
reported bugs:
MDEV-27511, MDEV-27471, MDEV-27349, MDEV-27628, MDEV-27528.
Thanks to all people involved into early discussion of the feature
including Kristian Nielsen, those who helped to design, implement and
test: Sergei Golubchik, Andrei Elkin who took the burden of the
implemenation completion, Sujatha Sivakumar, Brandon
Nesterenko, Alice Sherepa, Ramesh Sivaraman, Jan Lindstrom.
60 lines
1.5 KiB
PHP
60 lines
1.5 KiB
PHP
#
|
|
# Run start alter basic tests (CA/RA with given engine)
|
|
# Params:-
|
|
# $engine
|
|
# $sync_slave
|
|
# master_node and slave_node connection should be defined
|
|
|
|
--echo # $engine
|
|
--connection master_node
|
|
--eval create table t1(a int, b int) engine=$engine;
|
|
insert into t1 values(1,1);
|
|
insert into t1 values(2,2);
|
|
--echo # Normal Alter
|
|
alter table t1 add column c int;
|
|
show create table t1;
|
|
--echo # Failed Alter
|
|
insert into t1 values(1,1, NULL);
|
|
--error ER_DUP_ENTRY
|
|
alter table t1 change a a int unique;
|
|
set @@session.binlog_alter_two_phase = 0;
|
|
alter table t1 change a a int;
|
|
set @@session.binlog_alter_two_phase = 1;
|
|
alter table t1 change a a int;
|
|
show create table t1;
|
|
|
|
# The following restriction should be removed post MDEV-26005 fix.
|
|
# TODO MDEV-26130 , should be removed after fixing
|
|
#if ($engine != 'aria')
|
|
#{
|
|
#--eval create temporary table tmp_tbl(a int, b int) engine=$engine;
|
|
#insert into tmp_tbl values(1,1);
|
|
#insert into tmp_tbl values(2,2);
|
|
#--echo # Normal Alter
|
|
#alter table tmp_tbl add column c int;
|
|
#--echo # Failed Alter
|
|
#insert into tmp_tbl values(1,1, NULL);
|
|
#--error ER_DUP_ENTRY
|
|
#alter table tmp_tbl change a a int unique ;
|
|
#show create table tmp_tbl;
|
|
#}
|
|
if ($sync_slave)
|
|
{
|
|
--source include/save_master_gtid.inc
|
|
--connection slave_node
|
|
--source include/sync_with_master_gtid.inc
|
|
show create table t1;
|
|
}
|
|
|
|
--connection master_node
|
|
drop table t1;
|
|
#if ($engine != 'aria')
|
|
#{
|
|
#drop temporary table tmp_tbl;
|
|
#}
|
|
if ($sync_slave)
|
|
{
|
|
--source include/save_master_gtid.inc
|
|
--connection slave_node
|
|
--source include/sync_with_master_gtid.inc
|
|
}
|