mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-01-17 12:32:27 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
mariadb/storage/maria
History
Michael Widenius 5364315229 Fix for MDEV-6493: Assertion `table->file->stats.records > 0 || error' failure, or 'Invalid write' valgrind warnings, or crash on scenario with Aria table, view, LOCK TABLES 
This bug only happens in case of paritioned tables used in LOCK TABLES and implicit_commit() was called
(as part of trying to execute a CREATE TABLE withing lock tables)

The problem was that Aria could not move the tables from one transaction to the new one, as thd->open_tables contained
a partitioned tables and not an Aria table.

Fix:
- Store a list of all open tables that are part of a share in share->open_tables
- In maria::implict_commit() use transaction->used_tables & share->open_tables to find out which tables
  was part of the current transaction instead of using thd->open_tables, which may contain partitioned tables.


mysql-test/suite/maria/maria_partition.result:
  Added test case
mysql-test/suite/maria/maria_partition.test:
  Added test case
storage/maria/ha_maria.cc:
  Use trn->used tables and share->open_tables to find out which tables was part of the current transaction instead of using thd->open_tables.
storage/maria/ma_close.c:
  Remove closed table from share->open_list
storage/maria/ma_open.c:
  Add table to share->open_list
storage/maria/ma_state.c:
  Added comment
storage/maria/maria_def.h:
  Added share->open_list, a list of all tables that is using this share.
2014-07-30 13:27:52 +03:00
..
unittest Fixed MDEV-4291: Assertion `trid >= info->s->state.create_trid' failure or data corruption (key points to record 2013-05-13 00:43:46 +03:00
CMakeLists.txt MDEV-672 : storage/maria and storage/perfschema do not appear to honor WITH_UNIT_TESTS 2012-10-30 23:05:55 +01:00
file_formats.txt
ft_maria.c Fixed some compiler warnings and errors in test suite found by buildbot 2010-01-27 23:53:08 +02:00
ha_maria.cc Fix for MDEV-6493: Assertion `table->file->stats.records > 0 || error' failure, or 'Invalid write' valgrind warnings, or crash on scenario with Aria table, view, LOCK TABLES 2014-07-30 13:27:52 +03:00
ha_maria.h Added support for --crash-script in mysqld_safe. 2013-02-28 08:42:05 +02:00
lockman.c merge with 5.3 2011-10-19 21:45:18 +02:00
lockman.h
ma_bitmap.c MDEV-4243 Warnings/errors while compiling with clang 2013-03-28 20:04:14 +01:00
ma_blockrec.c Fixed a compiler failure and removed some warnings in windows 2014-03-11 16:53:24 +02:00
ma_blockrec.h 5.1 merge 2013-05-20 10:53:04 +02:00
ma_cache.c merge with 5.3 2011-10-19 21:45:18 +02:00
ma_changed.c lots of post-merge changes 2011-04-25 17:22:25 +02:00
ma_check.c MySQL-5.5.35 merge 2014-01-22 15:29:36 +01:00
ma_check_standalone.h MySQL-5.5.35 merge 2014-01-22 15:29:36 +01:00
ma_checkpoint.c compiler warnings 2013-04-14 16:48:16 +02:00
ma_checkpoint.h rename maria to aria 2010-09-12 18:40:01 +02:00
ma_checksum.c make 5.1 compiling with modern gcc. 2013-12-20 12:35:47 +02:00
ma_close.c Fix for MDEV-6493: Assertion `table->file->stats.records > 0 || error' failure, or 'Invalid write' valgrind warnings, or crash on scenario with Aria table, view, LOCK TABLES 2014-07-30 13:27:52 +03:00
ma_commit.c
ma_commit.h
ma_control_file.c use PSI wrappers in aria and other non-MySQL code 2011-07-13 21:10:18 +02:00
ma_control_file.h rename maria to aria 2010-09-12 18:40:01 +02:00
ma_create.c Merge mariadb 5.3->mariadb 5.5 2012-03-24 18:21:22 +01:00
ma_dbug.c Fixed lp:925377 "Querying myisam table metadata while 'alter table..enable keys' is running may corrupt the table" 2012-02-28 23:18:52 +02:00
ma_delete.c 5.3 merge. 2013-05-20 12:36:30 +02:00
ma_delete_all.c merge with 5.3 2011-10-19 21:45:18 +02:00
ma_delete_table.c Fixed MDEV-306 / LP:1007967 - Assertion `table->file->stats.records > 0 || error' failed join_read_const_table on concurrent SELECT and DROP/ADD INDEX 2012-06-15 12:52:58 +03:00
ma_dynrec.c Fixed a compiler failure and removed some warnings in windows 2014-03-11 16:53:24 +02:00
ma_extra.c Fixed lp:947474 "Assertion `table->file->stats.records > 0 || error' failed in join_read_const_table on concurrent SELECT and ALTER, constant Aria table" 2012-03-20 16:04:50 +02:00
ma_ft_boolean_search.c Merge with 5.2. 2011-12-11 11:34:44 +02:00
ma_ft_eval.c
ma_ft_eval.h
ma_ft_nlq_search.c 5.3 merge 2012-10-18 23:33:06 +02:00
ma_ft_parser.c lots of post-merge changes 2011-04-25 17:22:25 +02:00
ma_ft_stem.c
ma_ft_test1.c
ma_ft_test1.h
ma_ft_update.c 5.3->5.5 merge 2011-11-22 18:04:38 +01:00
ma_ftdefs.h lots of post-merge changes 2011-04-25 17:22:25 +02:00
ma_fulltext.h Merge with mysql-maria 2009-01-30 23:55:42 +02:00
ma_info.c Fixed MDEV-306 / LP:1007967 - Assertion `table->file->stats.records > 0 || error' failed join_read_const_table on concurrent SELECT and DROP/ADD INDEX 2012-06-15 12:52:58 +03:00
ma_init.c merge with 5.3 2011-10-19 21:45:18 +02:00
ma_key.c make 5.1 compiling with modern gcc. 2013-12-20 12:35:47 +02:00
ma_key_recover.c Fixed compiler errors 2012-08-14 19:59:28 +03:00
ma_key_recover.h Fixes some bug in Aria recovery: 2010-10-07 12:51:34 +03:00
ma_keycache.c merge with 5.3 2011-10-19 21:45:18 +02:00
ma_locking.c 5.3 merge 2012-01-13 15:50:02 +01:00
ma_loghandler.c Compilation warnings. 2013-05-07 18:26:22 +02:00
ma_loghandler.h Fix of compiler errors. 2011-05-16 16:13:34 +03:00
ma_loghandler_lsn.h
ma_norec.c Added support for NO_RECORD record format (don't store any row data) for Aria. 2011-01-14 11:54:39 +01:00
ma_open.c Fix for MDEV-6493: Assertion `table->file->stats.records > 0 || error' failure, or 'Invalid write' valgrind warnings, or crash on scenario with Aria table, view, LOCK TABLES 2014-07-30 13:27:52 +03:00
ma_packrec.c fix the build and compiler warnings (few of which were real bugs) 2011-10-29 20:40:03 +02:00
ma_page.c merge with 5.3 2011-10-19 21:45:18 +02:00
ma_pagecache.c Fixed compiler errors 2012-08-14 19:59:28 +03:00
ma_pagecache.h merge with 5.3 2011-10-19 21:45:18 +02:00
ma_pagecaches.c
ma_pagecrc.c MDEV-3999: Valgrind errors 'invalid write' or assorted server crashes on concurrent flow with partitioned Aria tables 2013-05-12 11:29:16 +03:00
ma_panic.c merge with 5.3 2011-10-19 21:45:18 +02:00
ma_preload.c lots of post-merge changes 2011-04-25 17:22:25 +02:00
ma_range.c MDEV-4687: impossible where with < operation, but =-5 return one row 2013-07-25 22:42:26 +04:00
ma_recovery.c MySQL-5.5.35 merge 2014-01-22 15:29:36 +01:00
ma_recovery.h Fixed portability problem with partiton_error.test 2011-06-13 12:46:11 +03:00
ma_recovery_util.c merge with 5.3 2011-10-19 21:45:18 +02:00
ma_recovery_util.h
ma_rename.c Fixed lp:947474 "Assertion `table->file->stats.records > 0 || error' failed in join_read_const_table on concurrent SELECT and ALTER, constant Aria table" 2012-03-20 16:04:50 +02:00
ma_rfirst.c
ma_rkey.c merge with 5.3 2011-10-19 21:45:18 +02:00
ma_rlast.c
ma_rnext.c merge with 5.3 2011-10-19 21:45:18 +02:00
ma_rnext_same.c merge with 5.3 2011-10-19 21:45:18 +02:00
ma_rprev.c merge with 5.3 2011-10-19 21:45:18 +02:00
ma_rrnd.c MDEV-736 LP:1004615 - Unexpected warnings "Encountered illegal value '' when converting to DECIMAL" on a query with aggregate functions and GROUP BY 2012-11-17 16:50:15 +01:00
ma_rsame.c merge with 5.3 2011-10-19 21:45:18 +02:00
ma_rsamepos.c
ma_rt_index.c merge with 5.3. 2012-06-04 17:26:11 +02:00
ma_rt_index.h
ma_rt_key.c Fixes some bug in Aria recovery: 2010-10-07 12:51:34 +03:00
ma_rt_key.h
ma_rt_mbr.c
ma_rt_mbr.h
ma_rt_split.c compiler warnings 2013-04-14 16:48:16 +02:00
ma_rt_test.c merge with 5.3 2011-10-19 21:45:18 +02:00
ma_scan.c MDEV-4280: Assertion `empty_size == empty_size_on_page' failure in ma_blockrec.c or ER_NOT_KEYFILE on query with DISTINCT and GROUP BY 2013-05-11 15:55:11 +03:00
ma_search.c Compilation warnings. 2013-05-07 18:26:22 +02:00
ma_servicethread.c fix the include guards and add missing gplv2 headers 2012-02-17 12:19:38 +01:00
ma_servicethread.h fix the include guards and add missing gplv2 headers 2012-02-17 12:19:38 +01:00
ma_sort.c MySQL-5.5.35 merge 2014-01-22 15:29:36 +01:00
ma_sp_defs.h
ma_sp_key.c lots of post-merge changes 2011-04-25 17:22:25 +02:00
ma_sp_test.c lots of post-merge changes 2011-04-25 17:22:25 +02:00
ma_state.c Fix for MDEV-6493: Assertion `table->file->stats.records > 0 || error' failure, or 'Invalid write' valgrind warnings, or crash on scenario with Aria table, view, LOCK TABLES 2014-07-30 13:27:52 +03:00
ma_state.h MDEV-3999: Valgrind errors 'invalid write' or assorted server crashes on concurrent flow with partitioned Aria tables 2013-05-12 11:29:16 +03:00
ma_static.c merge with 5.3 2011-10-19 21:45:18 +02:00
ma_statrec.c merge with 5.3 2011-10-19 21:45:18 +02:00
ma_test1.c Fixed MDEV-4291: Assertion `trid >= info->s->state.create_trid' failure or data corruption (key points to record 2013-05-13 00:43:46 +03:00
ma_test2.c Fixed MDEV-4291: Assertion `trid >= info->s->state.create_trid' failure or data corruption (key points to record 2013-05-13 00:43:46 +03:00
ma_test3.c MDEV-4243 Warnings/errors while compiling with clang 2013-03-28 20:04:14 +01:00
ma_test_all.res
ma_test_all.sh makes mi_test_all.sh & ma_test_all.sh working (MDEV-285) 2012-09-25 13:45:11 +03:00
ma_test_big.sh
ma_test_force_start.pl rename maria to aria 2010-09-12 18:40:01 +02:00
ma_test_recovery
ma_unique.c Fixed a compiler failure and removed some warnings in windows 2014-03-11 16:53:24 +02:00
ma_update.c 5.3 merge. 2013-05-20 12:36:30 +02:00
ma_write.c Fixed some cache variables that could be set to higher value than what the code supported (size_t) 2013-06-06 15:14:23 +03:00
maria_chk.c MDEV-5485 Minor man pages formatting issues 2014-05-30 23:19:26 +02:00
maria_def.h Fix for MDEV-6493: Assertion `table->file->stats.records > 0 || error' failure, or 'Invalid write' valgrind warnings, or crash on scenario with Aria table, view, LOCK TABLES 2014-07-30 13:27:52 +03:00
maria_dump_log.c merge with 5.3 2011-10-19 21:45:18 +02:00
maria_ftdump.c lots of post-merge changes 2011-04-25 17:22:25 +02:00
maria_pack.c Fixed MDEV-5724 "Server crashes on SQL select containing more group by and left join statements using innodb tables" 2014-03-10 21:40:27 +02:00
maria_read_log.c merge with 5.3 2011-10-19 21:45:18 +02:00
maria_rename.sh
tablockman.c merge with 5.3 2011-10-19 21:45:18 +02:00
tablockman.h use PSI wrappers in aria and other non-MySQL code 2011-07-13 21:10:18 +02:00
test_pack
trnman.c Fixed MDEV-4970: Wrong result with Aria table populated with disabled keys 2014-01-25 15:41:08 +02:00
trnman.h use PSI wrappers in aria and other non-MySQL code 2011-07-13 21:10:18 +02:00
trnman_public.h merged 2009-01-16 17:18:17 +01:00