mirror of
https://github.com/MariaDB/server.git
synced 2025-01-22 23:04:20 +01:00
1336b0eb13
5.1.20 -> 5.1.21 upgrades.
We generate mysql_fix_privilege.sql file, which contains SQL
statements required to upgrade the system database. This script
is generated by concatenation of mysql_system_tables.sql and
mysql_system_tables_fix.sql.
The problem was that
- in order to create general_log and slow_log tables we use
stored programs in mysql_system_tables.sql;
- we upgrade mysql.proc table in mysql_system_tables_fix.sql;
So, if mysql.proc table needs to be upgraded, stored procedures
can not be used in mysql_system_tables.sql.
In other words, in mysql_system_tables.sql stored programs must
not be used because they may be unavailable at this point.
The fix is to use dynamic SQL instead of stored programs.
There is no test case for this bug because our test suite
is not suitable for such test cases. system_mysql_db_fix* test
cases play with the database "test". Here we need to modify
the system database and we can not do that in the test suite.
scripts/mysql_system_tables.sql:
Use dynamic SQL instead of stored programs.
|
||
|---|---|---|
| .. | ||
| .cvsignore | ||
| CMakeLists.txt | ||
| comp_sql.c | ||
| fill_help_tables.sql | ||
| make_binary_distribution.sh | ||
| make_sharedlib_distribution.sh | ||
| make_win_bin_dist | ||
| Makefile.am | ||
| msql2mysql.sh | ||
| mysql_config.sh | ||
| mysql_convert_table_format.sh | ||
| mysql_find_rows.sh | ||
| mysql_fix_extensions.sh | ||
| mysql_fix_privilege_tables.sh | ||
| mysql_install_db.sh | ||
| mysql_secure_installation.sh | ||
| mysql_setpermission.sh | ||
| mysql_system_tables.sql | ||
| mysql_system_tables_data.sql | ||
| mysql_system_tables_fix.sql | ||
| mysql_test_data_timezone.sql | ||
| mysql_zap.sh | ||
| mysqlaccess.conf | ||
| mysqlaccess.sh | ||
| mysqlbug.sh | ||
| mysqld_multi.sh | ||
| mysqld_safe.sh | ||
| mysqldumpslow.sh | ||
| mysqlhotcopy.sh | ||