mirror of
https://github.com/MariaDB/server.git
synced 2025-01-17 20:42:30 +01:00
914ae41f33
"INSERT... ON DUPLICATE KEY UPDATE skips auto_increment values". When in an INSERT ON DUPLICATE KEY UPDATE, using an autoincrement column, we inserted some autogenerated values and also updated some rows, some autogenerated values were not used (for example, even if 10 was the largest autoinc value in the table at the start of the statement, 12 could be the first autogenerated value inserted by the statement, instead of 11). One autogenerated value was lost per updated row. Led to exhausting the range of the autoincrement column faster. Bug introduced by fix of BUG#20188; present since 5.0.24 and 5.1.12. This bug breaks replication from a pre-5.0.24 master. But the present bugfix, as it makes INSERT ON DUP KEY UPDATE behave like pre-5.0.24, breaks replication from a [5.0.24,5.0.34] master to a fixed (5.0.36) slave! To warn users against this when they upgrade their slave, as agreed with the support team, we add code for a fixed slave to detect that it is connected to a buggy master in a situation (INSERT ON DUP KEY UPDATE into autoinc column) likely to break replication, in which case it cannot replicate so stops and prints a message to the slave's error log and to SHOW SLAVE STATUS. For 5.0.36->[5.0.24,5.0.34] replication we cannot warn as master does not know the slave's version (but we always recommended to users to have slave at least as new as master). As agreed with support, I'll also ask for an alert to be put into the MySQL Network Monitoring and Advisory Service. mysql-test/r/rpl_insert_id.result: results to check the bugfix; without the bugfix, you would see, in master and slave: "3,2" instead of "2,2" for the INSERT VALUES testcase, "11,6,..." instead of "6,6,..." for the INSERT SELECT testcase. mysql-test/t/rpl_insert_id.test: testing that BUG#24432 is fixed sql/log_event.cc: A trick to force the master to pretend it is old and features BUG#24432. To do fast lookups in the list of known bugs by version, we compute the 3 X.Y.Z numbers from the master's version string and cache that into a new member Format_description_log_event::server_version_split. We do this computation in the event's two constructors. A simple prevention against buffer overrun when reading the master's version from a binlog event (assume the event is corrupted on disk, and so the version string on disk is longer than ST_SERVER_VER_LEN (50), then we would not get a closing 0 at the end of the class member. sql/log_event.h: new member to hold the "split server version" (3 numbers X.Y.Z), and a method to compute this from the version string. sql/slave.cc: a function which tells, based on master's version (as found in the Format_description event in the relay log being executed), if master can have a certain bug. This function uses a list of bug_id / first_version_with_bug / first_version_with_fix. If the test is positive, a short error message is put into SHOW SLAVE STATUS, and a verbose message is put into the slave's error log. The caller is expected to stop the slave in this case. sql/slave.h: new function to test if the replication master has a bug sql/sql_insert.cc: Fix for BUG#24432:t he reason was a misplaced restore_auto_increment() (misplaced when fixing BUG#20188). Indeed, when updating the row, it is clear that the autogenerated auto_increment value will not be used for this row (and if by "chance" the autoinc value present in the updated row is >= to the not used autogenerated value, adjust_next_insert_id_after_explicit_value() will fix next_insert_id). We also add code for a fixed slave to detect that it is connected to a buggy master (in which case it cannot replicate so stops). mysql-test/r/rpl_known_bugs_detection.result: see that SHOW SLAVE STATUS prints information that slave found a bug in master, and does not execute the dangerous event (table stays empty). mysql-test/t/rpl_known_bugs_detection-master.opt: pass debug symbol to make the master pretend it has BUG#24432 mysql-test/t/rpl_known_bugs_detection.test: new test to see if bug detection by slave works
444 lines
8.3 KiB
Text
444 lines
8.3 KiB
Text
#
|
|
# Setup
|
|
#
|
|
stop slave;
|
|
drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
|
|
reset master;
|
|
reset slave;
|
|
drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
|
|
start slave;
|
|
use test;
|
|
drop table if exists t1, t2, t3;
|
|
#
|
|
# See if queries that use both auto_increment and LAST_INSERT_ID()
|
|
# are replicated well
|
|
#
|
|
# We also check how the foreign_key_check variable is replicated
|
|
#
|
|
create table t1(a int auto_increment, key(a));
|
|
create table t2(b int auto_increment, c int, key(b));
|
|
insert into t1 values (1),(2),(3);
|
|
insert into t1 values (null);
|
|
insert into t2 values (null,last_insert_id());
|
|
select * from t1;
|
|
a
|
|
1
|
|
2
|
|
3
|
|
4
|
|
select * from t2;
|
|
b c
|
|
1 4
|
|
drop table t1;
|
|
drop table t2;
|
|
create table t1(a int auto_increment, key(a)) engine=innodb;
|
|
create table t2(b int auto_increment, c int, key(b), foreign key(b) references t1(a)) engine=innodb;
|
|
SET FOREIGN_KEY_CHECKS=0;
|
|
insert into t1 values (10);
|
|
insert into t1 values (null),(null),(null);
|
|
insert into t2 values (5,0);
|
|
insert into t2 values (null,last_insert_id());
|
|
SET FOREIGN_KEY_CHECKS=1;
|
|
select * from t1;
|
|
a
|
|
10
|
|
11
|
|
12
|
|
13
|
|
select * from t2;
|
|
b c
|
|
5 0
|
|
6 11
|
|
#
|
|
# check if INSERT SELECT in auto_increment is well replicated (bug #490)
|
|
#
|
|
drop table t2;
|
|
drop table t1;
|
|
create table t1(a int auto_increment, key(a));
|
|
create table t2(b int auto_increment, c int, key(b));
|
|
insert into t1 values (10);
|
|
insert into t1 values (null),(null),(null);
|
|
insert into t2 values (5,0);
|
|
insert into t2 (c) select * from t1;
|
|
select * from t2;
|
|
b c
|
|
5 0
|
|
6 10
|
|
7 11
|
|
8 12
|
|
9 13
|
|
select * from t1;
|
|
a
|
|
10
|
|
11
|
|
12
|
|
13
|
|
select * from t2;
|
|
b c
|
|
5 0
|
|
6 10
|
|
7 11
|
|
8 12
|
|
9 13
|
|
drop table t1;
|
|
drop table t2;
|
|
#
|
|
# Bug#8412: Error codes reported in binary log for CHARACTER SET,
|
|
# FOREIGN_KEY_CHECKS
|
|
#
|
|
SET TIMESTAMP=1000000000;
|
|
CREATE TABLE t1 ( a INT UNIQUE );
|
|
SET FOREIGN_KEY_CHECKS=0;
|
|
INSERT INTO t1 VALUES (1),(1);
|
|
ERROR 23000: Duplicate entry '1' for key 1
|
|
drop table t1;
|
|
#
|
|
# Bug#14553: NULL in WHERE resets LAST_INSERT_ID
|
|
#
|
|
create table t1(a int auto_increment, key(a));
|
|
create table t2(a int);
|
|
insert into t1 (a) values (null);
|
|
insert into t2 (a) select a from t1 where a is null;
|
|
insert into t2 (a) select a from t1 where a is null;
|
|
select * from t2;
|
|
a
|
|
1
|
|
select * from t2;
|
|
a
|
|
1
|
|
drop table t1;
|
|
drop table t2;
|
|
#
|
|
# End of 4.1 tests
|
|
#
|
|
drop function if exists bug15728;
|
|
drop function if exists bug15728_insert;
|
|
drop table if exists t1, t2;
|
|
create table t1 (
|
|
id int not null auto_increment,
|
|
last_id int,
|
|
primary key (id)
|
|
);
|
|
create function bug15728() returns int(11)
|
|
return last_insert_id();
|
|
insert into t1 (last_id) values (0);
|
|
insert into t1 (last_id) values (last_insert_id());
|
|
insert into t1 (last_id) values (bug15728());
|
|
create table t2 (
|
|
id int not null auto_increment,
|
|
last_id int,
|
|
primary key (id)
|
|
);
|
|
create function bug15728_insert() returns int(11) modifies sql data
|
|
begin
|
|
insert into t2 (last_id) values (bug15728());
|
|
return bug15728();
|
|
end|
|
|
create trigger t1_bi before insert on t1 for each row
|
|
begin
|
|
declare res int;
|
|
select bug15728_insert() into res;
|
|
set NEW.last_id = res;
|
|
end|
|
|
insert into t1 (last_id) values (0);
|
|
drop trigger t1_bi;
|
|
select last_insert_id();
|
|
last_insert_id()
|
|
4
|
|
select bug15728_insert();
|
|
bug15728_insert()
|
|
2
|
|
select last_insert_id();
|
|
last_insert_id()
|
|
4
|
|
insert into t1 (last_id) values (bug15728());
|
|
select last_insert_id();
|
|
last_insert_id()
|
|
5
|
|
select * from t1;
|
|
id last_id
|
|
1 0
|
|
2 1
|
|
3 2
|
|
4 1
|
|
5 4
|
|
select * from t2;
|
|
id last_id
|
|
1 3
|
|
2 4
|
|
drop function bug15728;
|
|
drop function bug15728_insert;
|
|
drop table t1, t2;
|
|
create table t1 (n int primary key auto_increment not null,
|
|
b int, unique(b));
|
|
set sql_log_bin=0;
|
|
insert into t1 values(null,100);
|
|
replace into t1 values(null,50),(null,100),(null,150);
|
|
select * from t1 order by n;
|
|
n b
|
|
2 50
|
|
3 100
|
|
4 150
|
|
truncate table t1;
|
|
set sql_log_bin=1;
|
|
insert into t1 values(null,100);
|
|
select * from t1 order by n;
|
|
n b
|
|
1 100
|
|
insert into t1 values(null,200),(null,300);
|
|
delete from t1 where b <> 100;
|
|
select * from t1 order by n;
|
|
n b
|
|
1 100
|
|
replace into t1 values(null,100),(null,350);
|
|
select * from t1 order by n;
|
|
n b
|
|
2 100
|
|
3 350
|
|
select * from t1 order by n;
|
|
n b
|
|
2 100
|
|
3 350
|
|
insert into t1 values (NULL,400),(3,500),(NULL,600) on duplicate key UPDATE n=1000;
|
|
select * from t1 order by n;
|
|
n b
|
|
2 100
|
|
4 400
|
|
1000 350
|
|
1001 600
|
|
select * from t1 order by n;
|
|
n b
|
|
2 100
|
|
4 400
|
|
1000 350
|
|
1001 600
|
|
drop table t1;
|
|
create table t1 (n int primary key auto_increment not null,
|
|
b int, unique(b));
|
|
insert into t1 values(null,100);
|
|
select * from t1 order by n;
|
|
n b
|
|
1 100
|
|
insert into t1 values(null,200),(null,300);
|
|
delete from t1 where b <> 100;
|
|
select * from t1 order by n;
|
|
n b
|
|
1 100
|
|
insert into t1 values(null,100),(null,350) on duplicate key update n=2;
|
|
select * from t1 order by n;
|
|
n b
|
|
2 100
|
|
3 350
|
|
select * from t1 order by n;
|
|
n b
|
|
2 100
|
|
3 350
|
|
drop table t1;
|
|
CREATE TABLE t1 (a INT NOT NULL PRIMARY KEY AUTO_INCREMENT, b INT,
|
|
UNIQUE(b));
|
|
INSERT INTO t1(b) VALUES(1),(1),(2) ON DUPLICATE KEY UPDATE t1.b=10;
|
|
SELECT * FROM t1;
|
|
a b
|
|
1 10
|
|
2 2
|
|
SELECT * FROM t1;
|
|
a b
|
|
1 10
|
|
2 2
|
|
drop table t1;
|
|
CREATE TABLE t1 (
|
|
id bigint(20) unsigned NOT NULL auto_increment,
|
|
field_1 int(10) unsigned NOT NULL,
|
|
field_2 varchar(255) NOT NULL,
|
|
field_3 varchar(255) NOT NULL,
|
|
PRIMARY KEY (id),
|
|
UNIQUE KEY field_1 (field_1, field_2)
|
|
);
|
|
CREATE TABLE t2 (
|
|
field_a int(10) unsigned NOT NULL,
|
|
field_b varchar(255) NOT NULL,
|
|
field_c varchar(255) NOT NULL
|
|
);
|
|
INSERT INTO t2 (field_a, field_b, field_c) VALUES (1, 'a', '1a');
|
|
INSERT INTO t2 (field_a, field_b, field_c) VALUES (2, 'b', '2b');
|
|
INSERT INTO t2 (field_a, field_b, field_c) VALUES (3, 'c', '3c');
|
|
INSERT INTO t2 (field_a, field_b, field_c) VALUES (4, 'd', '4d');
|
|
INSERT INTO t2 (field_a, field_b, field_c) VALUES (5, 'e', '5e');
|
|
INSERT INTO t1 (field_1, field_2, field_3)
|
|
SELECT t2.field_a, t2.field_b, t2.field_c
|
|
FROM t2
|
|
ON DUPLICATE KEY UPDATE
|
|
t1.field_3 = t2.field_c;
|
|
INSERT INTO t2 (field_a, field_b, field_c) VALUES (6, 'f', '6f');
|
|
INSERT INTO t1 (field_1, field_2, field_3)
|
|
SELECT t2.field_a, t2.field_b, t2.field_c
|
|
FROM t2
|
|
ON DUPLICATE KEY UPDATE
|
|
t1.field_3 = t2.field_c;
|
|
SELECT * FROM t1;
|
|
id field_1 field_2 field_3
|
|
1 1 a 1a
|
|
2 2 b 2b
|
|
3 3 c 3c
|
|
4 4 d 4d
|
|
5 5 e 5e
|
|
6 6 f 6f
|
|
SELECT * FROM t1;
|
|
id field_1 field_2 field_3
|
|
1 1 a 1a
|
|
2 2 b 2b
|
|
3 3 c 3c
|
|
4 4 d 4d
|
|
5 5 e 5e
|
|
6 6 f 6f
|
|
drop table t1, t2;
|
|
DROP PROCEDURE IF EXISTS p1;
|
|
DROP TABLE IF EXISTS t1, t2;
|
|
SELECT LAST_INSERT_ID(0);
|
|
LAST_INSERT_ID(0)
|
|
0
|
|
CREATE TABLE t1 (
|
|
id INT NOT NULL DEFAULT 0,
|
|
last_id INT,
|
|
PRIMARY KEY (id)
|
|
);
|
|
CREATE TABLE t2 (
|
|
id INT NOT NULL AUTO_INCREMENT,
|
|
last_id INT,
|
|
PRIMARY KEY (id)
|
|
);
|
|
CREATE PROCEDURE p1()
|
|
BEGIN
|
|
INSERT INTO t2 (last_id) VALUES (LAST_INSERT_ID());
|
|
INSERT INTO t1 (last_id) VALUES (LAST_INSERT_ID());
|
|
END|
|
|
CALL p1();
|
|
SELECT * FROM t1;
|
|
id last_id
|
|
0 1
|
|
SELECT * FROM t2;
|
|
id last_id
|
|
1 0
|
|
SELECT * FROM t1;
|
|
id last_id
|
|
0 1
|
|
SELECT * FROM t2;
|
|
id last_id
|
|
1 0
|
|
DROP PROCEDURE p1;
|
|
DROP TABLE t1, t2;
|
|
DROP PROCEDURE IF EXISTS p1;
|
|
DROP FUNCTION IF EXISTS f1;
|
|
DROP FUNCTION IF EXISTS f2;
|
|
DROP FUNCTION IF EXISTS f3;
|
|
DROP TABLE IF EXISTS t1, t2;
|
|
CREATE TABLE t1 (
|
|
i INT NOT NULL AUTO_INCREMENT PRIMARY KEY,
|
|
j INT DEFAULT 0
|
|
);
|
|
CREATE TABLE t2 (i INT);
|
|
CREATE PROCEDURE p1()
|
|
BEGIN
|
|
INSERT INTO t1 (i) VALUES (NULL);
|
|
INSERT INTO t2 (i) VALUES (LAST_INSERT_ID());
|
|
INSERT INTO t1 (i) VALUES (NULL), (NULL);
|
|
INSERT INTO t2 (i) VALUES (LAST_INSERT_ID());
|
|
END |
|
|
CREATE FUNCTION f1() RETURNS INT MODIFIES SQL DATA
|
|
BEGIN
|
|
INSERT INTO t1 (i) VALUES (NULL);
|
|
INSERT INTO t2 (i) VALUES (LAST_INSERT_ID());
|
|
INSERT INTO t1 (i) VALUES (NULL), (NULL);
|
|
INSERT INTO t2 (i) VALUES (LAST_INSERT_ID());
|
|
RETURN 0;
|
|
END |
|
|
CREATE FUNCTION f2() RETURNS INT NOT DETERMINISTIC
|
|
RETURN LAST_INSERT_ID() |
|
|
CREATE FUNCTION f3() RETURNS INT MODIFIES SQL DATA
|
|
BEGIN
|
|
INSERT INTO t2 (i) VALUES (LAST_INSERT_ID());
|
|
RETURN 0;
|
|
END |
|
|
INSERT INTO t1 VALUES (NULL, -1);
|
|
CALL p1();
|
|
SELECT f1();
|
|
f1()
|
|
0
|
|
INSERT INTO t1 VALUES (NULL, f2()), (NULL, LAST_INSERT_ID()),
|
|
(NULL, LAST_INSERT_ID()), (NULL, f2()), (NULL, f2());
|
|
INSERT INTO t1 VALUES (NULL, f2());
|
|
INSERT INTO t1 VALUES (NULL, LAST_INSERT_ID()), (NULL, LAST_INSERT_ID(5)),
|
|
(NULL, @@LAST_INSERT_ID);
|
|
INSERT INTO t1 VALUES (NULL, 0), (NULL, LAST_INSERT_ID());
|
|
UPDATE t1 SET j= -1 WHERE i IS NULL;
|
|
INSERT INTO t1 (i) VALUES (NULL);
|
|
INSERT INTO t1 (i) VALUES (NULL);
|
|
SELECT f3();
|
|
f3()
|
|
0
|
|
SELECT * FROM t1;
|
|
i j
|
|
1 -1
|
|
2 0
|
|
3 0
|
|
4 0
|
|
5 0
|
|
6 0
|
|
7 0
|
|
8 3
|
|
9 3
|
|
10 3
|
|
11 3
|
|
12 3
|
|
13 8
|
|
14 13
|
|
15 5
|
|
16 13
|
|
17 -1
|
|
18 14
|
|
19 0
|
|
20 0
|
|
SELECT * FROM t2;
|
|
i
|
|
2
|
|
3
|
|
5
|
|
6
|
|
19
|
|
SELECT * FROM t1;
|
|
i j
|
|
1 -1
|
|
2 0
|
|
3 0
|
|
4 0
|
|
5 0
|
|
6 0
|
|
7 0
|
|
8 3
|
|
9 3
|
|
10 3
|
|
11 3
|
|
12 3
|
|
13 8
|
|
14 13
|
|
15 5
|
|
16 13
|
|
17 -1
|
|
18 14
|
|
19 0
|
|
20 0
|
|
SELECT * FROM t2;
|
|
i
|
|
2
|
|
3
|
|
5
|
|
6
|
|
19
|
|
DROP PROCEDURE p1;
|
|
DROP FUNCTION f1;
|
|
DROP FUNCTION f2;
|
|
DROP FUNCTION f3;
|
|
DROP TABLE t1, t2;
|
|
|
|
# End of 5.0 tests
|
|
|