mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 03:52:35 +01:00
08c852026d
This patch is the result of running run-clang-tidy -fix -header-filter=.* -checks='-*,modernize-use-equals-default' . Code style changes have been done on top. The result of this change leads to the following improvements: 1. Binary size reduction. * For a -DBUILD_CONFIG=mysql_release build, the binary size is reduced by ~400kb. * A raw -DCMAKE_BUILD_TYPE=Release reduces the binary size by ~1.4kb. 2. Compiler can better understand the intent of the code, thus it leads to more optimization possibilities. Additionally it enabled detecting unused variables that had an empty default constructor but not marked so explicitly. Particular change required following this patch in sql/opt_range.cc result_keys, an unused template class Bitmap now correctly issues unused variable warnings. Setting Bitmap template class constructor to default allows the compiler to identify that there are no side-effects when instantiating the class. Previously the compiler could not issue the warning as it assumed Bitmap class (being a template) would not be performing a NO-OP for its default constructor. This prevented the "unused variable warning".
248 lines
8.7 KiB
C++
248 lines
8.7 KiB
C++
/*************** Tabmul H Declares Source Code File (.H) ***************/
|
|
/* Name: TABMUL.H Version 1.5 */
|
|
/* */
|
|
/* (C) Copyright to PlugDB Software Development 2003-2017 */
|
|
/* Author: Olivier BERTRAND */
|
|
/* */
|
|
/* This file contains the TDBMUL and TDBDIR classes declares. */
|
|
/***********************************************************************/
|
|
#if defined(_WIN32)
|
|
#include <io.h>
|
|
#else // !_WIN32
|
|
#include <sys/types.h>
|
|
#include <unistd.h>
|
|
#include <sys/stat.h>
|
|
#include <dirent.h>
|
|
#endif // !_WIN32
|
|
//#include "osutil.h"
|
|
#include "block.h"
|
|
|
|
typedef class TDBMUL *PTDBMUL;
|
|
typedef class TDBSDR *PTDBSDR;
|
|
|
|
/***********************************************************************/
|
|
/* This is the MUL Access Method class declaration for files that are */
|
|
/* physically split in multiple files having the same format. */
|
|
/***********************************************************************/
|
|
class DllExport TDBMUL : public TDBASE {
|
|
//friend class MULCOL;
|
|
public:
|
|
// Constructor
|
|
TDBMUL(PTDB tdbp);
|
|
TDBMUL(PTDBMUL tdbp);
|
|
|
|
// Implementation
|
|
virtual AMT GetAmType(void) {return Tdbp->GetAmType();}
|
|
virtual PTDB Duplicate(PGLOBAL g);
|
|
|
|
// Methods
|
|
virtual void ResetDB(void);
|
|
virtual PTDB Clone(PTABS t);
|
|
virtual bool IsSame(PTDB tp) {return tp == (PTDB)Tdbp;}
|
|
virtual PCSZ GetFile(PGLOBAL g) {return Tdbp->GetFile(g);}
|
|
virtual int GetRecpos(void) {return 0;}
|
|
virtual PCOL ColDB(PGLOBAL g, PSZ name, int num);
|
|
bool InitFileNames(PGLOBAL g);
|
|
|
|
// Database routines
|
|
virtual PCOL MakeCol(PGLOBAL g, PCOLDEF cdp, PCOL cprec, int n)
|
|
{strcpy(g->Message, MSG(MUL_MAKECOL_ERR)); return NULL;}
|
|
virtual int Cardinality(PGLOBAL g);
|
|
virtual int GetMaxSize(PGLOBAL g);
|
|
virtual int GetProgMax(PGLOBAL g);
|
|
virtual int GetProgCur(void);
|
|
virtual int RowNumber(PGLOBAL g, bool b = false);
|
|
virtual bool OpenDB(PGLOBAL g);
|
|
virtual int ReadDB(PGLOBAL g);
|
|
virtual int WriteDB(PGLOBAL g);
|
|
virtual int DeleteDB(PGLOBAL g, int irc);
|
|
virtual void CloseDB(PGLOBAL g);
|
|
|
|
protected:
|
|
|
|
// Members
|
|
PTDB Tdbp; // Points to a (file) table class
|
|
char* *Filenames; // Points to file names
|
|
int Rows; // Total rows of already read files
|
|
int Mul; // Type of multiple file list
|
|
int NumFiles; // Number of physical files
|
|
int iFile; // Index of currently processed file
|
|
}; // end of class TDBMUL
|
|
|
|
#if 0
|
|
/***********************************************************************/
|
|
/* This is the MSD Access Method class declaration for files that are */
|
|
/* physically split in multiple files having the same format. */
|
|
/* This sub-class also include files of the sub-directories. */
|
|
/***********************************************************************/
|
|
class DllExport TDBMSD : public TDBMUL {
|
|
//friend class MULCOL;
|
|
public:
|
|
// Constructor
|
|
TDBMSD(PTDB tdbp) : TDBMUL(tdbp) {}
|
|
TDBMSD(PTDBMSD tdbp) : TDBMUL(tdbp) {}
|
|
|
|
// Implementation
|
|
virtual PTDB Duplicate(PGLOBAL g);
|
|
|
|
// Methods
|
|
virtual PTDB Clone(PTABS t);
|
|
bool InitFileNames(PGLOBAL g);
|
|
|
|
// Database routines
|
|
|
|
protected:
|
|
|
|
// Members
|
|
}; // end of class TDBMSD
|
|
#endif
|
|
|
|
/***********************************************************************/
|
|
/* Directory listing table. */
|
|
/***********************************************************************/
|
|
class DllExport DIRDEF : public TABDEF { /* Directory listing table */
|
|
friend class CATALOG;
|
|
friend class TDBDIR;
|
|
public:
|
|
// Constructor
|
|
DIRDEF(void) {Fn = NULL; Incl = false; Huge = false;}
|
|
|
|
// Implementation
|
|
virtual const char *GetType(void) {return "DIR";}
|
|
|
|
// Methods
|
|
virtual bool DefineAM(PGLOBAL g, LPCSTR am, int poff);
|
|
virtual PTDB GetTable(PGLOBAL g, MODE m);
|
|
|
|
protected:
|
|
// Members
|
|
PSZ Fn; /* Path/Name of file search */
|
|
bool Incl; /* true to include sub-directories */
|
|
bool Huge; /* true if files can be larger than 2GB */
|
|
bool Nodir; /* true to exclude directories */
|
|
}; // end of DIRDEF
|
|
|
|
/***********************************************************************/
|
|
/* This is the DIR Access Method class declaration for tables that */
|
|
/* represent a directory listing. The pathname is given at the create */
|
|
/* time and can contain wildcard characters in the file name, and the */
|
|
/* (virtual) table is populated when it is in use. */
|
|
/***********************************************************************/
|
|
class TDBDIR : public TDBASE {
|
|
friend class DIRCOL;
|
|
friend class TDBMUL;
|
|
public:
|
|
// Constructor
|
|
TDBDIR(PDIRDEF tdp);
|
|
TDBDIR(PSZ fpat);
|
|
|
|
// Implementation
|
|
virtual AMT GetAmType(void) {return TYPE_AM_DIR;}
|
|
|
|
// Methods
|
|
virtual int GetRecpos(void) {return iFile;}
|
|
|
|
// Database routines
|
|
virtual PCOL MakeCol(PGLOBAL g, PCOLDEF cdp, PCOL cprec, int n);
|
|
virtual int GetMaxSize(PGLOBAL g);
|
|
virtual int GetProgMax(PGLOBAL g) {return GetMaxSize(g);}
|
|
virtual int GetProgCur(void) {return iFile;}
|
|
virtual bool OpenDB(PGLOBAL g);
|
|
virtual int ReadDB(PGLOBAL g);
|
|
virtual int WriteDB(PGLOBAL g);
|
|
virtual int DeleteDB(PGLOBAL g, int irc);
|
|
virtual void CloseDB(PGLOBAL g);
|
|
|
|
protected:
|
|
void Init(void);
|
|
char *Path(PGLOBAL g);
|
|
|
|
// Members
|
|
PSZ To_File; // Points to file search pathname
|
|
int iFile; // Index of currently retrieved file
|
|
#if defined(_WIN32)
|
|
PVAL Dvalp; // Used to retrieve file date values
|
|
WIN32_FIND_DATA FileData; // Find data structure
|
|
HANDLE hSearch; // Search handle
|
|
char Drive[_MAX_DRIVE]; // Drive name
|
|
#else // !_WIN32
|
|
struct stat Fileinfo; // File info structure
|
|
struct dirent *Entry; // Point to directory entry structure
|
|
DIR *Dir; // To searched directory structure
|
|
bool Done; // true when _splipath is done
|
|
char Pattern[_MAX_FNAME+_MAX_EXT];
|
|
#endif // !_WIN32
|
|
char Fpath[_MAX_PATH]; // Absolute file search pattern
|
|
char Direc[_MAX_DIR]; // Search path
|
|
char Fname[_MAX_FNAME]; // File name
|
|
char Ftype[_MAX_EXT]; // File extention
|
|
bool Nodir; // Exclude directories from file list
|
|
}; // end of class TDBDIR
|
|
|
|
/***********************************************************************/
|
|
/* This is the DIR Access Method class declaration for tables that */
|
|
/* represent a directory listing. The pathname is given at the create */
|
|
/* time and can contain wildcard characters in the file name, and the */
|
|
/* (virtual) table is populated when it is in use. In addition, this */
|
|
/* class also includes files of included sub-directories. */
|
|
/***********************************************************************/
|
|
class TDBSDR : public TDBDIR {
|
|
friend class DIRCOL;
|
|
friend class TDBMUL;
|
|
public:
|
|
// Constructors
|
|
TDBSDR(PDIRDEF tdp) : TDBDIR(tdp) {Sub = NULL;}
|
|
TDBSDR(PSZ fpat) : TDBDIR(fpat) {Sub = NULL;}
|
|
|
|
// Database routines
|
|
virtual int GetMaxSize(PGLOBAL g);
|
|
virtual int GetProgMax(PGLOBAL g) {return GetMaxSize(g);}
|
|
virtual bool OpenDB(PGLOBAL g);
|
|
virtual int ReadDB(PGLOBAL g);
|
|
//virtual void CloseDB(PGLOBAL g);
|
|
|
|
protected:
|
|
int FindInDir(PGLOBAL g);
|
|
|
|
typedef struct _Sub_Dir {
|
|
struct _Sub_Dir *Next;
|
|
struct _Sub_Dir *Prev;
|
|
#if defined(_WIN32)
|
|
HANDLE H; // Search handle
|
|
#else // !_WIN32
|
|
DIR *D;
|
|
#endif // !_WIN32
|
|
size_t Len; // Initial directory name length
|
|
} SUBDIR, *PSUBDIR;
|
|
|
|
// Members
|
|
PSUBDIR Sub; // To current Subdir block
|
|
}; // end of class TDBSDR
|
|
|
|
/***********************************************************************/
|
|
/* Class DIRCOL: DIR access method column descriptor. */
|
|
/* This A.M. is used for tables populated by DIR file name list. */
|
|
/***********************************************************************/
|
|
class DIRCOL : public COLBLK {
|
|
public:
|
|
// Constructors
|
|
DIRCOL(PCOLDEF cdp, PTDB tdbp, PCOL cprec, int i, PCSZ am = "DIR");
|
|
DIRCOL(DIRCOL *colp, PTDB tdbp); // Constructor used in copy process
|
|
|
|
// Implementation
|
|
virtual int GetAmType(void) {return TYPE_AM_DIR;}
|
|
|
|
// Methods
|
|
virtual void ReadColumn(PGLOBAL g);
|
|
|
|
protected:
|
|
// Default constructor not to be used
|
|
DIRCOL(void) = default;
|
|
#if defined(_WIN32)
|
|
void SetTimeValue(PGLOBAL g, FILETIME& ftime);
|
|
#endif // _WIN32
|
|
|
|
// Members
|
|
PTDBDIR Tdbp; // To DIR table
|
|
int N; // Column number
|
|
}; // end of class DIRCOL
|