mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 20:12:31 +01:00
08c852026d
This patch is the result of running run-clang-tidy -fix -header-filter=.* -checks='-*,modernize-use-equals-default' . Code style changes have been done on top. The result of this change leads to the following improvements: 1. Binary size reduction. * For a -DBUILD_CONFIG=mysql_release build, the binary size is reduced by ~400kb. * A raw -DCMAKE_BUILD_TYPE=Release reduces the binary size by ~1.4kb. 2. Compiler can better understand the intent of the code, thus it leads to more optimization possibilities. Additionally it enabled detecting unused variables that had an empty default constructor but not marked so explicitly. Particular change required following this patch in sql/opt_range.cc result_keys, an unused template class Bitmap now correctly issues unused variable warnings. Setting Bitmap template class constructor to default allows the compiler to identify that there are no side-effects when instantiating the class. Previously the compiler could not issue the warning as it assumed Bitmap class (being a template) would not be performing a NO-OP for its default constructor. This prevented the "unused variable warning".
97 lines
2.8 KiB
C++
97 lines
2.8 KiB
C++
/* Copyright (c) 2010, 2012, Oracle and/or its affiliates. All rights reserved.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License, version 2.0,
|
|
as published by the Free Software Foundation.
|
|
|
|
This program is also distributed with certain software (including
|
|
but not limited to OpenSSL) that is licensed under separate terms,
|
|
as designated in a particular file or component or in included license
|
|
documentation. The authors of MySQL hereby grant you an additional
|
|
permission to link the program and your derivative works with the
|
|
separately licensed software that they have included with MySQL.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License, version 2.0, for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1335 USA */
|
|
|
|
#ifndef TABLE_LOCK_WAITS_SUMMARY_BY_TABLE_H
|
|
#define TABLE_LOCK_WAITS_SUMMARY_BY_TABLE_H
|
|
|
|
/**
|
|
@file storage/perfschema/table_tlws_by_table.h
|
|
Table TABLE_LOCK_WAITS_SUMMARY_BY_TABLE (declarations).
|
|
*/
|
|
|
|
#include "pfs_column_types.h"
|
|
#include "pfs_engine_table.h"
|
|
#include "pfs_instr_class.h"
|
|
#include "pfs_instr.h"
|
|
#include "table_helper.h"
|
|
|
|
/**
|
|
@addtogroup Performance_schema_tables
|
|
@{
|
|
*/
|
|
|
|
/**
|
|
A row of table
|
|
PERFORMANCE_SCHEMA.TABLE_LOCK_WAITS_SUMMARY_BY_TABLE.
|
|
*/
|
|
struct row_tlws_by_table
|
|
{
|
|
/** Column OBJECT_TYPE, SCHEMA_NAME, OBJECT_NAME. */
|
|
PFS_object_row m_object;
|
|
/** Columns COUNT/SUM/MIN/AVG/MAX READ/WRITE/READ_NORMAL/etc. */
|
|
PFS_table_lock_stat_row m_stat;
|
|
};
|
|
|
|
/** Table PERFORMANCE_SCHEMA.TABLE_LOCK_WAITS_SUMMARY_BY_TABLE. */
|
|
class table_tlws_by_table : public PFS_engine_table
|
|
{
|
|
public:
|
|
/** Table share */
|
|
static PFS_engine_table_share m_share;
|
|
static PFS_engine_table* create();
|
|
static int delete_all_rows();
|
|
|
|
virtual int rnd_init(bool scan);
|
|
virtual int rnd_next();
|
|
virtual int rnd_pos(const void *pos);
|
|
virtual void reset_position(void);
|
|
|
|
protected:
|
|
virtual int read_row_values(TABLE *table,
|
|
unsigned char *buf,
|
|
Field **fields,
|
|
bool read_all);
|
|
|
|
table_tlws_by_table();
|
|
|
|
public:
|
|
~table_tlws_by_table() = default;
|
|
|
|
protected:
|
|
void make_row(PFS_table_share *table_share);
|
|
|
|
private:
|
|
/** Table share lock. */
|
|
static THR_LOCK m_table_lock;
|
|
|
|
/** Current row. */
|
|
row_tlws_by_table m_row;
|
|
/** True is the current row exists. */
|
|
bool m_row_exists;
|
|
/** Current position. */
|
|
PFS_simple_index m_pos;
|
|
/** Next position. */
|
|
PFS_simple_index m_next_pos;
|
|
};
|
|
|
|
/** @} */
|
|
#endif
|