mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 12:02:42 +01:00
16ce188ded
Very complex select statements can create temporary tables
that are too big to be represented as a MyISAM table.
This was not checked at table creation time, but only at
open time. The result was an attempt to delete the
"impossible" table.
But if the server is built --with-raid, MyISAM tries to
open the table before deleting the files. It needs to find
out if the table uses the raid support and how many raid
chunks there are. This is done with an open "for repair",
which will almost always succeed.
But in this case we have an "impossible" table. The open
failed. Hence the files were not deleted. Also the error
message was a bit unspecific.
I turned an open error in this situation into the assumption
of having no raid support on the table. Thus the normal data
file is tried to be deleted. This may however leave existing
raid chunks behind.
I also added a check in mi_create() to prevent the creation
of an "impossible" table. A more decriptive error message is
given in this case.
No test case. The required select statement is way too
large for the test suite. I added a test script to the
bug report.
myisam/mi_create.c:
Bug#11824 - internal /tmp/*.{MYD,MYI} files remain, causing subsequent queries to fail
Added a check to mi_create() that the table description
header of the index file does not exceed 64KB. The header
has only 16 bits to encode its length.
myisam/mi_delete_table.c:
Bug#11824 - internal /tmp/*.{MYD,MYI} files remain, causing subsequent queries to fail
Interpret error in table open as not having a raid
configuration on the tbale. Thus try to delete the
normal data file, but leave behind raid chunks if
they exist.
70 lines
2.2 KiB
C
70 lines
2.2 KiB
C
/* Copyright (C) 2000 MySQL AB & MySQL Finland AB & TCX DataKonsult AB
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */
|
|
|
|
/*
|
|
deletes a table
|
|
*/
|
|
|
|
#include "fulltext.h"
|
|
|
|
int mi_delete_table(const char *name)
|
|
{
|
|
char from[FN_REFLEN];
|
|
#ifdef USE_RAID
|
|
uint raid_type=0,raid_chunks=0;
|
|
#endif
|
|
DBUG_ENTER("mi_delete_table");
|
|
|
|
#ifdef EXTRA_DEBUG
|
|
check_table_is_closed(name,"delete");
|
|
#endif
|
|
#ifdef USE_RAID
|
|
{
|
|
MI_INFO *info;
|
|
/*
|
|
When built with RAID support, we need to determine if this table
|
|
makes use of the raid feature. If yes, we need to remove all raid
|
|
chunks. This is done with my_raid_delete(). Unfortunately it is
|
|
necessary to open the table just to check this. We use
|
|
'open_for_repair' to be able to open even a crashed table. If even
|
|
this open fails, we assume no raid configuration for this table
|
|
and try to remove the normal data file only. This may however
|
|
leave the raid chunks behind.
|
|
*/
|
|
if (!(info= mi_open(name, O_RDONLY, HA_OPEN_FOR_REPAIR)))
|
|
raid_type= 0;
|
|
else
|
|
{
|
|
raid_type= info->s->base.raid_type;
|
|
raid_chunks= info->s->base.raid_chunks;
|
|
mi_close(info);
|
|
}
|
|
}
|
|
#ifdef EXTRA_DEBUG
|
|
check_table_is_closed(name,"delete");
|
|
#endif
|
|
#endif /* USE_RAID */
|
|
|
|
fn_format(from,name,"",MI_NAME_IEXT,4);
|
|
if (my_delete_with_symlink(from, MYF(MY_WME)))
|
|
DBUG_RETURN(my_errno);
|
|
fn_format(from,name,"",MI_NAME_DEXT,4);
|
|
#ifdef USE_RAID
|
|
if (raid_type)
|
|
DBUG_RETURN(my_raid_delete(from, raid_chunks, MYF(MY_WME)) ? my_errno : 0);
|
|
#endif
|
|
DBUG_RETURN(my_delete_with_symlink(from, MYF(MY_WME)) ? my_errno : 0);
|
|
}
|