mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-01-30 18:41:56 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
mariadb/storage/perfschema/unittest
History
Vicențiu Ciorbaru 4799af0925 Fix unit test after merge from mysql 5.5.35 perfschema 
The problem in MariaDB is introduced by this merge commit:
c33db2cdc0

The merge comes from mysql and the original author comes from this
commit from MySQL:
------------------------------------------------
    commit 160b823d146288d66638e4a740d6d2da72f9a689
    Author: Marc Alff <marc.alff@oracle.com>
    Date:   Tue Aug 30 12:14:07 2016 +0200

    Bug#22551677 SIGNAL 11 IN LF_PINBOX_PUT_PINS

    Backport to 5.6
------------------------------------------------

The breaking change is in start_socket_wait_v1 where instead of using
m_thread_owner, we make use of my_pthread_getspecific_ptr to fetch a
thread local storage value. Unfortunately this invalidates the
"m_thread_owner" member when a socket is created. The internals of the
socket structure have m_thread_owner set to NULL, but when checking for
ownership we actually look at the current thread's key store.

This seems incorrect however it is not immediately apparent why.

To not diverge from MySQL's reasoning as it is not described what the
actual problem was that this commit is trying to fix, I have adjusted the
unittest to account for this new behaviour. We destroy the current
thread in the unit test, such that the newly created socket actually has
no thread owner. The m_thread_owner is untouched in all this.
2017-01-10 14:20:43 +02:00
..
CMakeLists.txt Merge branch 'merge-perfschema-5.6' into 10.0 2015-08-03 16:34:59 +02:00
conf.txt 5.5 merge 2014-05-09 12:35:11 +02:00
pfs-t.cc Fix unit test after merge from mysql 5.5.35 perfschema 2017-01-10 14:20:43 +02:00
pfs_account-oom-t.cc perfschema 5.6.24 2015-05-05 15:23:47 +02:00
pfs_connect_attr-t.cc perfschema 5.6.10 initial commit. 2014-05-06 23:20:50 +02:00
pfs_host-oom-t.cc perfschema 5.6.24 2015-05-05 15:23:47 +02:00
pfs_instr-oom-t.cc perfschema 5.6.24 2015-05-05 15:23:47 +02:00
pfs_instr-t.cc perfschema 5.6.24 2015-05-05 15:23:47 +02:00
pfs_instr_class-oom-t.cc perfschema 5.6.24 2015-05-05 15:23:47 +02:00
pfs_instr_class-t.cc perfschema 5.6.24 2015-05-05 15:23:47 +02:00
pfs_misc-t.cc Merge branch 'merge-perfschema-5.6' into 10.0 2015-08-03 16:34:59 +02:00
pfs_server_stubs.cc 5.6.28 2015-12-13 10:15:55 +01:00
pfs_timer-t.cc perfschema 5.6.10 initial commit. 2014-05-06 23:20:50 +02:00
pfs_user-oom-t.cc perfschema 5.6.24 2015-05-05 15:23:47 +02:00
stub_pfs_defaults.h 5.6.17 2014-05-07 10:04:30 +02:00
stub_pfs_global.h 5.6.26 2015-08-03 13:05:40 +02:00
stub_print_error.h 5.6.26 2015-08-03 13:05:40 +02:00