mirror of
https://github.com/MariaDB/server.git
synced 2025-01-18 13:02:28 +01:00
791584ae0d
SELECT statement itself returns empty. As a result of this bug 'SELECT AGGREGATE_FUNCTION(fld) ... GROUP BY' can return one row instead of an empty result set. When GROUP BY only has fields of constant tables (with a single row), the optimizer deletes the group_list. After that we lose the information about whether we had an GROUP BY statement. Though it's important as SELECT min(x) from empty_table; and SELECT min(x) from empty_table GROUP BY y; have to return different results - the first query should return one row, second - an empty result set. So here we add the 'group_optimized_away' flag to remember this case when GROUP BY exists in the query and is removed by the optimizer, and check this flag in end_send_group() mysql-test/r/group_by.result: Bug #29717 INSERT INTO SELECT inserts values even if SELECT statement itself returns empty. test result mysql-test/r/insert_select.result: Bug #29717 INSERT INTO SELECT inserts values even if SELECT statement itself returns empty. test result mysql-test/t/group_by.test: Bug #29717 INSERT INTO SELECT inserts values even if SELECT statement itself returns empty. This is additional testcase that is more basic than the original bug's testcase and has the same reason. mysql-test/t/insert_select.test: Bug #29717 INSERT INTO SELECT inserts values even if SELECT statement itself returns empty. test case sql/sql_select.cc: Bug #29717 INSERT INTO SELECT inserts values even if SELECT statement itself returns empty. Remember the 'GROUP BY was optimized away' case in the JOIN::group_optimized and check this in the end_send_group() sql/sql_select.h: Bug #29717 INSERT INTO SELECT inserts values even if SELECT statement itself returns empty. JOIN::group_optimized member added to remember the 'GROUP BY optimied away' case
270 lines
9.7 KiB
Text
270 lines
9.7 KiB
Text
#
|
|
# Problem with INSERT ... SELECT
|
|
#
|
|
|
|
--disable_warnings
|
|
drop table if exists t1,t2,t3;
|
|
--enable_warnings
|
|
|
|
create table t1 (bandID MEDIUMINT UNSIGNED NOT NULL PRIMARY KEY, payoutID SMALLINT UNSIGNED NOT NULL);
|
|
insert into t1 (bandID,payoutID) VALUES (1,6),(2,6),(3,4),(4,9),(5,10),(6,1),(7,12),(8,12);
|
|
create table t2 (payoutID SMALLINT UNSIGNED NOT NULL PRIMARY KEY);
|
|
insert into t2 (payoutID) SELECT DISTINCT payoutID FROM t1;
|
|
--error 1062
|
|
insert into t2 (payoutID) SELECT payoutID+10 FROM t1;
|
|
insert ignore into t2 (payoutID) SELECT payoutID+10 FROM t1;
|
|
select * from t2;
|
|
drop table t1,t2;
|
|
|
|
#
|
|
# bug in bulk insert optimization
|
|
# test case by Fournier Jocelyn <joc@presence-pc.com>
|
|
#
|
|
|
|
CREATE TABLE `t1` (
|
|
`numeropost` bigint(20) unsigned NOT NULL default '0',
|
|
`icone` tinyint(4) unsigned NOT NULL default '0',
|
|
`numreponse` bigint(20) unsigned NOT NULL auto_increment,
|
|
`contenu` text NOT NULL,
|
|
`pseudo` varchar(50) NOT NULL default '',
|
|
`date` datetime NOT NULL default '0000-00-00 00:00:00',
|
|
`ip` bigint(11) NOT NULL default '0',
|
|
`signature` tinyint(1) unsigned NOT NULL default '0',
|
|
PRIMARY KEY (`numeropost`,`numreponse`)
|
|
,KEY `ip` (`ip`),
|
|
KEY `date` (`date`),
|
|
KEY `pseudo` (`pseudo`),
|
|
KEY `numreponse` (`numreponse`)
|
|
) ENGINE=MyISAM;
|
|
|
|
CREATE TABLE `t2` (
|
|
`numeropost` bigint(20) unsigned NOT NULL default '0',
|
|
`icone` tinyint(4) unsigned NOT NULL default '0',
|
|
`numreponse` bigint(20) unsigned NOT NULL auto_increment,
|
|
`contenu` text NOT NULL,
|
|
`pseudo` varchar(50) NOT NULL default '',
|
|
`date` datetime NOT NULL default '0000-00-00 00:00:00',
|
|
`ip` bigint(11) NOT NULL default '0',
|
|
`signature` tinyint(1) unsigned NOT NULL default '0',
|
|
PRIMARY KEY (`numeropost`,`numreponse`),
|
|
KEY `ip` (`ip`),
|
|
KEY `date` (`date`),
|
|
KEY `pseudo` (`pseudo`),
|
|
KEY `numreponse` (`numreponse`)
|
|
) ENGINE=MyISAM;
|
|
|
|
INSERT INTO t2
|
|
(numeropost,icone,numreponse,contenu,pseudo,date,ip,signature) VALUES
|
|
(9,1,56,'test','joce','2001-07-25 13:50:53'
|
|
,3649052399,0);
|
|
|
|
|
|
INSERT INTO t1 (numeropost,icone,contenu,pseudo,date,signature,ip)
|
|
SELECT 1618,icone,contenu,pseudo,date,signature,ip FROM t2
|
|
WHERE numeropost=9 ORDER BY numreponse ASC;
|
|
|
|
show variables like '%bulk%';
|
|
|
|
INSERT INTO t1 (numeropost,icone,contenu,pseudo,date,signature,ip)
|
|
SELECT 1718,icone,contenu,pseudo,date,signature,ip FROM t2
|
|
WHERE numeropost=9 ORDER BY numreponse ASC;
|
|
|
|
DROP TABLE t1,t2;
|
|
|
|
#
|
|
# Test of insert ... select from same table
|
|
#
|
|
|
|
create table t1 (a int not null);
|
|
create table t2 (a int not null);
|
|
insert into t1 values (1);
|
|
insert into t1 values (a+2);
|
|
insert into t1 values (a+3);
|
|
insert into t1 values (4),(a+5);
|
|
insert into t1 select * from t1;
|
|
select * from t1;
|
|
insert into t1 select * from t1 as t2;
|
|
select * from t1;
|
|
insert into t2 select * from t1 as t2;
|
|
select * from t1;
|
|
insert into t1 select t2.a from t1,t2;
|
|
select * from t1;
|
|
--error 1066
|
|
insert into t1 select * from t1,t1;
|
|
drop table t1,t2;
|
|
|
|
#
|
|
# test replace ... select
|
|
#
|
|
|
|
create table t1 (a int not null primary key, b char(10));
|
|
create table t2 (a int not null, b char(10));
|
|
insert into t1 values (1,"t1:1"),(3,"t1:3");
|
|
insert into t2 values (2,"t2:2"), (3,"t2:3");
|
|
--error 1062
|
|
insert into t1 select * from t2;
|
|
select * from t1;
|
|
# REPLACE .. SELECT is not yet supported by PS
|
|
--disable_ps_protocol
|
|
replace into t1 select * from t2;
|
|
--enable_ps_protocol
|
|
select * from t1;
|
|
drop table t1,t2;
|
|
|
|
#
|
|
# Test that caused uninitialized memory access in auto_increment_key update
|
|
#
|
|
|
|
CREATE TABLE t1 ( USID INTEGER UNSIGNED, ServerID TINYINT UNSIGNED, State ENUM ('unknown', 'Access-Granted', 'Session-Active', 'Session-Closed' ) NOT NULL DEFAULT 'unknown', SessionID CHAR(32), User CHAR(32) NOT NULL DEFAULT '<UNKNOWN>', NASAddr INTEGER UNSIGNED, NASPort INTEGER UNSIGNED, NASPortType INTEGER UNSIGNED, ConnectSpeed INTEGER UNSIGNED, CarrierType CHAR(32), CallingStationID CHAR(32), CalledStationID CHAR(32), AssignedAddr INTEGER UNSIGNED, SessionTime INTEGER UNSIGNED, PacketsIn INTEGER UNSIGNED, OctetsIn INTEGER UNSIGNED, PacketsOut INTEGER UNSIGNED, OctetsOut INTEGER UNSIGNED, TerminateCause INTEGER UNSIGNED, UnauthTime TINYINT UNSIGNED, AccessRequestTime DATETIME, AcctStartTime DATETIME, AcctLastTime DATETIME, LastModification TIMESTAMP NOT NULL);
|
|
CREATE TABLE t2 ( USID INTEGER UNSIGNED AUTO_INCREMENT, ServerID TINYINT UNSIGNED, State ENUM ('unknown', 'Access-Granted', 'Session-Active', 'Session-Closed' ) NOT NULL DEFAULT 'unknown', SessionID CHAR(32), User TEXT NOT NULL, NASAddr INTEGER UNSIGNED, NASPort INTEGER UNSIGNED, NASPortType INTEGER UNSIGNED, ConnectSpeed INTEGER UNSIGNED, CarrierType CHAR(32), CallingStationID CHAR(32), CalledStationID CHAR(32), AssignedAddr INTEGER UNSIGNED, SessionTime INTEGER UNSIGNED, PacketsIn INTEGER UNSIGNED, OctetsIn INTEGER UNSIGNED, PacketsOut INTEGER UNSIGNED, OctetsOut INTEGER UNSIGNED, TerminateCause INTEGER UNSIGNED, UnauthTime TINYINT UNSIGNED, AccessRequestTime DATETIME, AcctStartTime DATETIME, AcctLastTime DATETIME, LastModification TIMESTAMP NOT NULL, INDEX(USID,ServerID,NASAddr,SessionID), INDEX(AssignedAddr));
|
|
INSERT INTO t1 VALUES (39,42,'Access-Granted','46','491721000045',2130706433,17690,NULL,NULL,'Localnet','491721000045','49172200000',754974766,NULL,NULL,NULL,NULL,NULL,NULL,NULL,'2003-07-18 00:11:21',NULL,NULL,20030718001121);
|
|
INSERT INTO t2 SELECT USID, ServerID, State, SessionID, User, NASAddr, NASPort, NASPortType, ConnectSpeed, CarrierType, CallingStationID, CalledStationID, AssignedAddr, SessionTime, PacketsIn, OctetsIn, PacketsOut, OctetsOut, TerminateCause, UnauthTime, AccessRequestTime, AcctStartTime, AcctLastTime, LastModification from t1 LIMIT 1;
|
|
drop table t1,t2;
|
|
|
|
#
|
|
# Another problem from Bug #2012
|
|
#
|
|
|
|
CREATE TABLE t1(
|
|
Month date NOT NULL,
|
|
Type tinyint(3) unsigned NOT NULL auto_increment,
|
|
Field int(10) unsigned NOT NULL,
|
|
Count int(10) unsigned NOT NULL,
|
|
UNIQUE KEY Month (Month,Type,Field)
|
|
);
|
|
|
|
insert into t1 Values
|
|
(20030901, 1, 1, 100),
|
|
(20030901, 1, 2, 100),
|
|
(20030901, 2, 1, 100),
|
|
(20030901, 2, 2, 100),
|
|
(20030901, 3, 1, 100);
|
|
|
|
select * from t1;
|
|
|
|
Select null, Field, Count From t1 Where Month=20030901 and Type=2;
|
|
|
|
create table t2(No int not null, Field int not null, Count int not null);
|
|
|
|
insert into t2 Select null, Field, Count From t1 Where Month=20030901 and Type=2;
|
|
|
|
select * from t2;
|
|
|
|
drop table t1, t2;
|
|
|
|
#
|
|
# BUG#6034 - Error code 124: Wrong medium type
|
|
#
|
|
CREATE TABLE t1 (
|
|
ID int(11) NOT NULL auto_increment,
|
|
NO int(11) NOT NULL default '0',
|
|
SEQ int(11) NOT NULL default '0',
|
|
PRIMARY KEY (ID),
|
|
KEY t1$NO (SEQ,NO)
|
|
) ENGINE=MyISAM;
|
|
INSERT INTO t1 (SEQ, NO) SELECT "1" AS SEQ, IF(MAX(NO) IS NULL, 0, MAX(NO)) + 1 AS NO FROM t1 WHERE (SEQ = 1);
|
|
select SQL_BUFFER_RESULT * from t1 WHERE (SEQ = 1);
|
|
drop table t1;
|
|
|
|
#
|
|
# Bug#10886 - Have to restore default values after update ON DUPLICATE KEY
|
|
#
|
|
create table t1 (f1 int);
|
|
create table t2 (ff1 int unique, ff2 int default 1);
|
|
insert into t1 values (1),(1),(2);
|
|
insert into t2(ff1) select f1 from t1 on duplicate key update ff2=ff2+1;
|
|
select * from t2;
|
|
drop table t1, t2;
|
|
#
|
|
# BUGS #9728 - 'Decreased functionality in "on duplicate key update"'
|
|
# #8147 - 'a column proclaimed ambigous in INSERT ... SELECT .. ON
|
|
# DUPLICATE'
|
|
#
|
|
create table t1 (a int unique);
|
|
create table t2 (a int, b int);
|
|
create table t3 (c int, d int);
|
|
insert into t1 values (1),(2);
|
|
insert into t2 values (1,2);
|
|
insert into t3 values (1,6),(3,7);
|
|
select * from t1;
|
|
insert into t1 select a from t2 on duplicate key update a= t1.a + t2.b;
|
|
select * from t1;
|
|
insert into t1 select a+1 from t2 on duplicate key update t1.a= t1.a + t2.b+1;
|
|
select * from t1;
|
|
insert into t1 select t3.c from t3 on duplicate key update a= a + t3.d;
|
|
select * from t1;
|
|
insert into t1 select t2.a from t2 group by t2.a on duplicate key update a= a + 10;
|
|
|
|
#Some error cases
|
|
--error 1052
|
|
insert into t1 select t2.a from t2 on duplicate key update a= a + t2.b;
|
|
--error 1109
|
|
insert into t1 select t2.a from t2 on duplicate key update t2.a= a + t2.b;
|
|
--error 1109
|
|
insert into t1 select t2.a from t2 group by t2.a on duplicate key update a= t1.a + t2.b;
|
|
drop table t1,t2,t3;
|
|
|
|
#
|
|
# Bug #12695 Item_func_isnull::update_used_tables() did not update
|
|
# const_item_cache
|
|
create table t1(f1 varchar(5) key);
|
|
insert into t1(f1) select if(max(f1) is null, '2000',max(f1)+1) from t1;
|
|
insert into t1(f1) select if(max(f1) is null, '2000',max(f1)+1) from t1;
|
|
insert into t1(f1) select if(max(f1) is null, '2000',max(f1)+1) from t1;
|
|
select * from t1;
|
|
drop table t1;
|
|
|
|
#
|
|
# Bug #13392 values() fails with 'ambiguous' or returns NULL
|
|
# with ON DUPLICATE and SELECT
|
|
create table t1(x int, y int);
|
|
create table t2(x int, z int);
|
|
insert into t1(x,y) select x,z from t2 on duplicate key update x=values(x);
|
|
--error 1054
|
|
insert into t1(x,y) select x,z from t2 on duplicate key update x=values(z);
|
|
--error 1109
|
|
insert into t1(x,y) select x,z from t2 on duplicate key update x=values(t2.x);
|
|
drop table t1,t2;
|
|
|
|
#
|
|
# Bug #9676: INSERT INTO x SELECT .. FROM x LIMIT 1; slows down with big
|
|
# tables
|
|
#
|
|
|
|
#Note: not an exsaustive test : just a check of the code path.
|
|
CREATE TABLE t1 (a int PRIMARY KEY);
|
|
INSERT INTO t1 values (1), (2);
|
|
|
|
INSERT INTO t1 SELECT a + 2 FROM t1 LIMIT 1;
|
|
|
|
DROP TABLE t1;
|
|
|
|
#
|
|
# Bug #29717 INSERT INTO SELECT inserts values even if SELECT statement itself returns empty
|
|
#
|
|
|
|
CREATE TABLE t1 (
|
|
f1 int(10) unsigned NOT NULL auto_increment PRIMARY KEY,
|
|
f2 varchar(100) NOT NULL default ''
|
|
);
|
|
CREATE TABLE t2 (
|
|
f1 varchar(10) NOT NULL default '',
|
|
f2 char(3) NOT NULL default '',
|
|
PRIMARY KEY (`f1`),
|
|
KEY `k1` (`f2`, `f1`)
|
|
);
|
|
|
|
INSERT INTO t1 values(NULL, '');
|
|
INSERT INTO `t2` VALUES ('486878','WDT'),('486910','WDT');
|
|
SELECT COUNT(*) FROM t1;
|
|
|
|
SELECT min(t2.f1) FROM t1, t2 where t2.f2 = 'SIR' GROUP BY t1.f1;
|
|
|
|
INSERT INTO t1 (f2)
|
|
SELECT min(t2.f1) FROM t1, t2 where t2.f2 = 'SIR' GROUP BY t1.f1;
|
|
|
|
SELECT COUNT(*) FROM t1;
|
|
SELECT * FROM t1;
|
|
DROP TABLE t1, t2;
|
|
|
|
# End of 4.1 tests
|