mirror of
https://github.com/MariaDB/server.git
synced 2025-01-30 10:31:54 +01:00
6400b199ac
The crash inside my_vsnprintf_utf32() happened correctly, because the caller methods: Field_string::sql_rpl_type() Field_varstring::sql_rpl_type() mis-used the charset library and sent pure ASCII data to the virtual function snprintf() of a utf32 CHARSET_INFO. It was wrong to use Field::charset() in sql_rpl_type(). We're printing the metadata (the data type) here, not the column data. The string contraining the data type of a CHAR/VARCHAR column is a pure ASCII string. Fixing to use res->charset() to print, like all virtual implementations of sql_type() do. Review was done by Andrei Elkin. Thanks to Andrei for proposing MTR test improvents.
84 lines
2.3 KiB
Text
84 lines
2.3 KiB
Text
include/master-slave.inc
|
|
[connection master]
|
|
SET SQL_LOG_BIN=0;
|
|
CREATE TABLE t1 (c1 char(255) DEFAULT NULL, KEY c1 (c1)) DEFAULT CHARSET=utf32;
|
|
Warnings:
|
|
Note 1071 Specified key was too long; max key length is 1000 bytes
|
|
SET SQL_LOG_BIN=1;
|
|
connection slave;
|
|
SET @saved_slave_type_conversions= @@global.slave_type_conversions;
|
|
include/stop_slave.inc
|
|
SET GLOBAL SLAVE_TYPE_CONVERSIONS='ALL_NON_LOSSY';
|
|
include/start_slave.inc
|
|
SET SQL_LOG_BIN=0;
|
|
CREATE TABLE t1 ( c1 varchar(255) DEFAULT NULL, KEY c1 (c1)) DEFAULT CHARSET=utf32;
|
|
Warnings:
|
|
Note 1071 Specified key was too long; max key length is 1000 bytes
|
|
SET SQL_LOG_BIN=1;
|
|
connection master;
|
|
INSERT INTO t1(c1) VALUES ('insert into t1');
|
|
DROP TABLE t1;
|
|
connection slave;
|
|
#
|
|
# MDEV-32249 strings/ctype-ucs2.c:2336: my_vsnprintf_utf32: Assertion `(n
|
|
#
|
|
#
|
|
# Testing with VARCHAR
|
|
#
|
|
connection slave;
|
|
include/stop_slave.inc
|
|
SET GLOBAL SLAVE_TYPE_CONVERSIONS= '';
|
|
include/start_slave.inc
|
|
connection master;
|
|
CREATE TABLE t1 (a INT);
|
|
connection slave;
|
|
ALTER TABLE t1 MODIFY a VARCHAR(1) CHARACTER SET utf32;
|
|
connection master;
|
|
INSERT INTO t1 VALUES (1);
|
|
connection slave;
|
|
include/wait_for_slave_sql_error.inc [errno=1677]
|
|
SHOW CREATE TABLE t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`a` varchar(1) CHARACTER SET utf32 COLLATE utf32_general_ci DEFAULT NULL
|
|
) ENGINE=MyISAM DEFAULT CHARSET=latin1 COLLATE=latin1_swedish_ci
|
|
SELECT * FROM t1 ORDER BY a;
|
|
a
|
|
SET GLOBAL SQL_SLAVE_SKIP_COUNTER = 1;
|
|
START SLAVE;
|
|
connection master;
|
|
DROP TABLE t1;
|
|
connection slave;
|
|
#
|
|
# Testing with CHAR
|
|
#
|
|
connection slave;
|
|
include/stop_slave.inc
|
|
SET GLOBAL SLAVE_TYPE_CONVERSIONS= '';
|
|
include/start_slave.inc
|
|
connection master;
|
|
CREATE TABLE t1 (a INT);
|
|
connection slave;
|
|
ALTER TABLE t1 MODIFY a CHAR(1) CHARACTER SET utf32;
|
|
connection master;
|
|
INSERT INTO t1 VALUES (1);
|
|
connection slave;
|
|
include/wait_for_slave_sql_error.inc [errno=1677]
|
|
SHOW CREATE TABLE t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`a` char(1) CHARACTER SET utf32 COLLATE utf32_general_ci DEFAULT NULL
|
|
) ENGINE=MyISAM DEFAULT CHARSET=latin1 COLLATE=latin1_swedish_ci
|
|
SELECT * FROM t1 ORDER BY a;
|
|
a
|
|
SET GLOBAL SQL_SLAVE_SKIP_COUNTER = 1;
|
|
START SLAVE;
|
|
connection master;
|
|
DROP TABLE t1;
|
|
connection slave;
|
|
connection slave;
|
|
SET GLOBAL SLAVE_TYPE_CONVERSIONS= @saved_slave_type_conversions;
|
|
include/stop_slave.inc
|
|
include/start_slave.inc
|
|
connection master;
|
|
include/rpl_end.inc
|