mirror of
https://github.com/MariaDB/server.git
synced 2025-01-22 14:54:20 +01:00
dd2bdfda8d
numbers) Before this patch, the code in the class Log_to_csv_event_handler, which is used by the global LOGGER object to write to the tables mysql.slow_log and mysql_general_log, was supporting only records of the format defined for these tables in the database creation scripts. Also before this patch, the server would allow, with certain limitations, to perform ALTER TABLE on the LOG TABLES. As implemented, the behavior of the server, with regards to LOG TABLES, is inconsistent: - either ALTER TABLES on LOG TABLES should be prohibited, and the code writing to these tables can make assumptions on the record format, - or ALTER TABLE on LOG TABLES is permitted, in which case the code writing a record to these tables should be more flexible and honor new fields. In particular, adding an AUTO_INCREMENT column to the logs, does not work as expected (per the bug report). Given that the ALTER TABLE on log tables statement has been explicitly implemented to check that the log should be off to perform the operation, and that current test cases already cover this, the user expectation is already set that this is a "feature" and should be supported. With this patch, the server will: - populate AUTO INCREMENT columns if present, - populate any additional column with it's default value when writing a record to the LOG TABLES. Tests are provided, that detail the precise sequence of statements a SUPER user might want to perform to add more columns to the log tables.
357 lines
16 KiB
Text
357 lines
16 KiB
Text
use mysql;
|
|
truncate table general_log;
|
|
select * from general_log;
|
|
event_time user_host thread_id server_id command_type argument
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select * from general_log
|
|
truncate table slow_log;
|
|
select * from slow_log;
|
|
start_time user_host query_time lock_time rows_sent rows_examined db last_insert_id insert_id server_id sql_text
|
|
truncate table general_log;
|
|
select * from general_log where argument like '%general_log%';
|
|
event_time user_host thread_id server_id command_type argument
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select * from general_log where argument like '%general_log%'
|
|
create table join_test (verbose_comment varchar (80), command_type varchar(64));
|
|
insert into join_test values ("User performed a usual SQL query", "Query");
|
|
insert into join_test values ("New DB connection was registered", "Connect");
|
|
insert into join_test values ("Get the table info", "Field List");
|
|
select verbose_comment, user_host, argument
|
|
from mysql.general_log join join_test
|
|
on (mysql.general_log.command_type = join_test.command_type);
|
|
verbose_comment user_host argument
|
|
User performed a usual SQL query USER_HOST select * from general_log where argument like '%general_log%'
|
|
User performed a usual SQL query USER_HOST create table join_test (verbose_comment varchar (80), command_type varchar(64))
|
|
User performed a usual SQL query USER_HOST insert into join_test values ("User performed a usual SQL query", "Query")
|
|
User performed a usual SQL query USER_HOST insert into join_test values ("New DB connection was registered", "Connect")
|
|
User performed a usual SQL query USER_HOST insert into join_test values ("Get the table info", "Field List")
|
|
User performed a usual SQL query USER_HOST select verbose_comment, user_host, argument
|
|
from mysql.general_log join join_test
|
|
on (mysql.general_log.command_type = join_test.command_type)
|
|
drop table join_test;
|
|
flush logs;
|
|
lock tables mysql.general_log WRITE;
|
|
ERROR HY000: You can't write-lock a log table. Only read access is possible
|
|
lock tables mysql.slow_log WRITE;
|
|
ERROR HY000: You can't write-lock a log table. Only read access is possible
|
|
lock tables mysql.general_log READ;
|
|
ERROR HY000: You can't use usual read lock with log tables. Try READ LOCAL instead
|
|
lock tables mysql.slow_log READ;
|
|
ERROR HY000: You can't use usual read lock with log tables. Try READ LOCAL instead
|
|
lock tables mysql.slow_log READ LOCAL, mysql.general_log READ LOCAL;
|
|
unlock tables;
|
|
lock tables mysql.general_log READ LOCAL;
|
|
flush logs;
|
|
unlock tables;
|
|
select "Mark that we woke up from flush logs in the test"
|
|
as "test passed";
|
|
test passed
|
|
Mark that we woke up from flush logs in the test
|
|
lock tables mysql.general_log READ LOCAL;
|
|
truncate mysql.general_log;
|
|
unlock tables;
|
|
select "Mark that we woke up from TRUNCATE in the test"
|
|
as "test passed";
|
|
test passed
|
|
Mark that we woke up from TRUNCATE in the test
|
|
use test;
|
|
truncate table mysql.general_log;
|
|
set names utf8;
|
|
create table bug16905 (s char(15) character set utf8 default 'пусто');
|
|
insert into bug16905 values ('новое');
|
|
select * from mysql.general_log;
|
|
event_time user_host thread_id server_id command_type argument
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query set names utf8
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query create table bug16905 (s char(15) character set utf8 default 'пусто')
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query insert into bug16905 values ('новое')
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select * from mysql.general_log
|
|
drop table bug16905;
|
|
truncate table mysql.slow_log;
|
|
set session long_query_time=1;
|
|
select sleep(2);
|
|
sleep(2)
|
|
0
|
|
select * from mysql.slow_log;
|
|
start_time user_host query_time lock_time rows_sent rows_examined db last_insert_id insert_id server_id sql_text
|
|
TIMESTAMP USER_HOST QUERY_TIME 00:00:00 1 0 test 0 0 1 select sleep(2)
|
|
alter table mysql.general_log engine=myisam;
|
|
ERROR HY000: You cannot 'ALTER' a log table if logging is enabled
|
|
alter table mysql.slow_log engine=myisam;
|
|
ERROR HY000: You cannot 'ALTER' a log table if logging is enabled
|
|
drop table mysql.general_log;
|
|
ERROR HY000: You cannot 'DROP' a log table if logging is enabled
|
|
drop table mysql.slow_log;
|
|
ERROR HY000: You cannot 'DROP' a log table if logging is enabled
|
|
set global general_log='OFF';
|
|
alter table mysql.slow_log engine=myisam;
|
|
ERROR HY000: You cannot 'ALTER' a log table if logging is enabled
|
|
set global slow_query_log='OFF';
|
|
show create table mysql.general_log;
|
|
Table Create Table
|
|
general_log CREATE TABLE `general_log` (
|
|
`event_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
|
|
`user_host` mediumtext,
|
|
`thread_id` int(11) DEFAULT NULL,
|
|
`server_id` int(11) DEFAULT NULL,
|
|
`command_type` varchar(64) DEFAULT NULL,
|
|
`argument` mediumtext
|
|
) ENGINE=CSV DEFAULT CHARSET=utf8 COMMENT='General log'
|
|
show create table mysql.slow_log;
|
|
Table Create Table
|
|
slow_log CREATE TABLE `slow_log` (
|
|
`start_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
|
|
`user_host` mediumtext NOT NULL,
|
|
`query_time` time NOT NULL,
|
|
`lock_time` time NOT NULL,
|
|
`rows_sent` int(11) NOT NULL,
|
|
`rows_examined` int(11) NOT NULL,
|
|
`db` varchar(512) DEFAULT NULL,
|
|
`last_insert_id` int(11) DEFAULT NULL,
|
|
`insert_id` int(11) DEFAULT NULL,
|
|
`server_id` int(11) DEFAULT NULL,
|
|
`sql_text` mediumtext NOT NULL
|
|
) ENGINE=CSV DEFAULT CHARSET=utf8 COMMENT='Slow log'
|
|
alter table mysql.general_log engine=myisam;
|
|
alter table mysql.slow_log engine=myisam;
|
|
show create table mysql.general_log;
|
|
Table Create Table
|
|
general_log CREATE TABLE `general_log` (
|
|
`event_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
|
|
`user_host` mediumtext,
|
|
`thread_id` int(11) DEFAULT NULL,
|
|
`server_id` int(11) DEFAULT NULL,
|
|
`command_type` varchar(64) DEFAULT NULL,
|
|
`argument` mediumtext
|
|
) ENGINE=MyISAM DEFAULT CHARSET=utf8 COMMENT='General log'
|
|
show create table mysql.slow_log;
|
|
Table Create Table
|
|
slow_log CREATE TABLE `slow_log` (
|
|
`start_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
|
|
`user_host` mediumtext NOT NULL,
|
|
`query_time` time NOT NULL,
|
|
`lock_time` time NOT NULL,
|
|
`rows_sent` int(11) NOT NULL,
|
|
`rows_examined` int(11) NOT NULL,
|
|
`db` varchar(512) DEFAULT NULL,
|
|
`last_insert_id` int(11) DEFAULT NULL,
|
|
`insert_id` int(11) DEFAULT NULL,
|
|
`server_id` int(11) DEFAULT NULL,
|
|
`sql_text` mediumtext NOT NULL
|
|
) ENGINE=MyISAM DEFAULT CHARSET=utf8 COMMENT='Slow log'
|
|
set global general_log='ON';
|
|
set global slow_query_log='ON';
|
|
select * from mysql.general_log;
|
|
event_time user_host thread_id server_id command_type argument
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query set names utf8
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query create table bug16905 (s char(15) character set utf8 default 'пусто')
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query insert into bug16905 values ('новое')
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select * from mysql.general_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query drop table bug16905
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query truncate table mysql.slow_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query set session long_query_time=1
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select sleep(2)
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select * from mysql.slow_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query alter table mysql.general_log engine=myisam
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query alter table mysql.slow_log engine=myisam
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query drop table mysql.general_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query drop table mysql.slow_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query set global general_log='OFF'
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query set global slow_query_log='ON'
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select * from mysql.general_log
|
|
flush logs;
|
|
lock tables mysql.general_log WRITE;
|
|
ERROR HY000: You can't write-lock a log table. Only read access is possible
|
|
lock tables mysql.slow_log WRITE;
|
|
ERROR HY000: You can't write-lock a log table. Only read access is possible
|
|
lock tables mysql.general_log READ;
|
|
ERROR HY000: You can't use usual read lock with log tables. Try READ LOCAL instead
|
|
lock tables mysql.slow_log READ;
|
|
ERROR HY000: You can't use usual read lock with log tables. Try READ LOCAL instead
|
|
lock tables mysql.slow_log READ LOCAL, mysql.general_log READ LOCAL;
|
|
unlock tables;
|
|
set global general_log='OFF';
|
|
set global slow_query_log='OFF';
|
|
set @save_storage_engine= @@session.storage_engine;
|
|
set storage_engine= MEMORY;
|
|
alter table mysql.slow_log engine=ndb;
|
|
ERROR HY000: This storage engine cannot be used for log tables"
|
|
alter table mysql.slow_log engine=innodb;
|
|
ERROR HY000: This storage engine cannot be used for log tables"
|
|
alter table mysql.slow_log engine=archive;
|
|
ERROR HY000: This storage engine cannot be used for log tables"
|
|
alter table mysql.slow_log engine=blackhole;
|
|
ERROR HY000: This storage engine cannot be used for log tables"
|
|
set storage_engine= @save_storage_engine;
|
|
drop table mysql.slow_log;
|
|
drop table mysql.general_log;
|
|
drop table mysql.general_log;
|
|
ERROR 42S02: Unknown table 'general_log'
|
|
drop table mysql.slow_log;
|
|
ERROR 42S02: Unknown table 'slow_log'
|
|
use mysql;
|
|
CREATE TABLE `general_log` (
|
|
`event_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP
|
|
ON UPDATE CURRENT_TIMESTAMP,
|
|
`user_host` mediumtext,
|
|
`thread_id` int(11) DEFAULT NULL,
|
|
`server_id` int(11) DEFAULT NULL,
|
|
`command_type` varchar(64) DEFAULT NULL,
|
|
`argument` mediumtext
|
|
) ENGINE=CSV DEFAULT CHARSET=utf8 COMMENT='General log';
|
|
CREATE TABLE `slow_log` (
|
|
`start_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP
|
|
ON UPDATE CURRENT_TIMESTAMP,
|
|
`user_host` mediumtext NOT NULL,
|
|
`query_time` time NOT NULL,
|
|
`lock_time` time NOT NULL,
|
|
`rows_sent` int(11) NOT NULL,
|
|
`rows_examined` int(11) NOT NULL,
|
|
`db` varchar(512) DEFAULT NULL,
|
|
`last_insert_id` int(11) DEFAULT NULL,
|
|
`insert_id` int(11) DEFAULT NULL,
|
|
`server_id` int(11) DEFAULT NULL,
|
|
`sql_text` mediumtext NOT NULL
|
|
) ENGINE=CSV DEFAULT CHARSET=utf8 COMMENT='Slow log';
|
|
set global general_log='ON';
|
|
set global slow_query_log='ON';
|
|
use test;
|
|
flush tables with read lock;
|
|
unlock tables;
|
|
use mysql;
|
|
lock tables general_log read local, help_category read local;
|
|
unlock tables;
|
|
use mysql;
|
|
RENAME TABLE general_log TO renamed_general_log;
|
|
ERROR HY000: Cannot rename 'general_log'. When logging enabled, rename to/from log table must rename two tables: the log table to an archive table and another table back to 'general_log'
|
|
RENAME TABLE slow_log TO renamed_slow_log;
|
|
ERROR HY000: Cannot rename 'slow_log'. When logging enabled, rename to/from log table must rename two tables: the log table to an archive table and another table back to 'slow_log'
|
|
truncate table general_log;
|
|
select * from general_log;
|
|
event_time user_host thread_id server_id command_type argument
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select * from general_log
|
|
truncate table slow_log;
|
|
select * from slow_log;
|
|
start_time user_host query_time lock_time rows_sent rows_examined db last_insert_id insert_id server_id sql_text
|
|
create table general_log_new like general_log;
|
|
rename table general_log TO renamed_general_log, general_log_new TO general_log;
|
|
create table slow_log_new like slow_log;
|
|
rename table slow_log TO renamed_slow_log, slow_log_new TO slow_log;
|
|
rename table general_log TO general_log_new, renamed_general_log TO general_log, slow_log to renamed_slow_log;
|
|
ERROR HY000: Cannot rename 'slow_log'. When logging enabled, rename to/from log table must rename two tables: the log table to an archive table and another table back to 'slow_log'
|
|
select * from general_log;
|
|
event_time user_host thread_id server_id command_type argument
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query create table slow_log_new like slow_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query rename table slow_log TO renamed_slow_log, slow_log_new TO slow_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query rename table general_log TO general_log_new, renamed_general_log TO general_log, slow_log to renamed_slow_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select * from general_log
|
|
select * from renamed_general_log;
|
|
event_time user_host thread_id server_id command_type argument
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select * from general_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query truncate table slow_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query select * from slow_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query create table general_log_new like general_log
|
|
TIMESTAMP USER_HOST THREAD_ID 1 Query rename table general_log TO renamed_general_log, general_log_new TO general_log
|
|
select * from slow_log;
|
|
start_time user_host query_time lock_time rows_sent rows_examined db last_insert_id insert_id server_id sql_text
|
|
select * from renamed_slow_log;
|
|
start_time user_host query_time lock_time rows_sent rows_examined db last_insert_id insert_id server_id sql_text
|
|
set global general_log='OFF';
|
|
RENAME TABLE general_log TO general_log2;
|
|
set global slow_query_log='OFF';
|
|
RENAME TABLE slow_log TO slow_log2;
|
|
set global general_log='ON';
|
|
ERROR HY000: Cannot activate 'general' log
|
|
set global slow_query_log='ON';
|
|
ERROR HY000: Cannot activate 'slow query' log
|
|
RENAME TABLE general_log2 TO general_log;
|
|
RENAME TABLE slow_log2 TO slow_log;
|
|
set global general_log='ON';
|
|
set global slow_query_log='ON';
|
|
flush logs;
|
|
flush logs;
|
|
drop table renamed_general_log, renamed_slow_log;
|
|
use test;
|
|
use mysql;
|
|
repair table general_log;
|
|
Table Op Msg_type Msg_text
|
|
mysql.general_log repair status OK
|
|
repair table slow_log;
|
|
Table Op Msg_type Msg_text
|
|
mysql.slow_log repair status OK
|
|
create table general_log_new like general_log;
|
|
create table slow_log_new like slow_log;
|
|
show tables like "%log%";
|
|
Tables_in_mysql (%log%)
|
|
general_log
|
|
general_log_new
|
|
ndb_binlog_index
|
|
slow_log
|
|
slow_log_new
|
|
drop table slow_log_new, general_log_new;
|
|
use test;
|
|
SET GLOBAL LOG_OUTPUT = 'TABLE';
|
|
SET GLOBAL general_log = 0;
|
|
FLUSH LOGS;
|
|
TRUNCATE TABLE mysql.general_log;
|
|
ALTER TABLE mysql.general_log ENGINE = MyISAM;
|
|
ALTER TABLE mysql.general_log
|
|
ADD COLUMN seq BIGINT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY;
|
|
SET GLOBAL general_log = 1;
|
|
FLUSH LOGS;
|
|
SELECT * FROM mysql.general_log;
|
|
event_time user_host thread_id server_id command_type argument seq
|
|
EVENT_TIME USER_HOST THREAD_ID SERVER_ID Query FLUSH LOGS 1
|
|
EVENT_TIME USER_HOST THREAD_ID SERVER_ID Query SELECT * FROM mysql.general_log 2
|
|
SELECT * FROM mysql.general_log;
|
|
event_time user_host thread_id server_id command_type argument seq
|
|
EVENT_TIME USER_HOST THREAD_ID SERVER_ID Query FLUSH LOGS 1
|
|
EVENT_TIME USER_HOST THREAD_ID SERVER_ID Query SELECT * FROM mysql.general_log 2
|
|
EVENT_TIME USER_HOST THREAD_ID SERVER_ID Query SELECT * FROM mysql.general_log 3
|
|
SELECT "My own query 1";
|
|
My own query 1
|
|
My own query 1
|
|
SELECT "My own query 2";
|
|
My own query 2
|
|
My own query 2
|
|
SELECT * FROM mysql.general_log;
|
|
event_time user_host thread_id server_id command_type argument seq
|
|
EVENT_TIME USER_HOST THREAD_ID SERVER_ID Query FLUSH LOGS 1
|
|
EVENT_TIME USER_HOST THREAD_ID SERVER_ID Query SELECT * FROM mysql.general_log 2
|
|
EVENT_TIME USER_HOST THREAD_ID SERVER_ID Query SELECT * FROM mysql.general_log 3
|
|
EVENT_TIME USER_HOST THREAD_ID SERVER_ID Query SELECT "My own query 1" 4
|
|
EVENT_TIME USER_HOST THREAD_ID SERVER_ID Query SELECT "My own query 2" 5
|
|
EVENT_TIME USER_HOST THREAD_ID SERVER_ID Query SELECT * FROM mysql.general_log 6
|
|
SET GLOBAL general_log = 0;
|
|
FLUSH LOGS;
|
|
ALTER TABLE mysql.general_log DROP COLUMN seq;
|
|
ALTER TABLE mysql.general_log ENGINE = CSV;
|
|
SET @old_long_query_time:=@@long_query_time;
|
|
SET GLOBAL slow_query_log = 0;
|
|
FLUSH LOGS;
|
|
TRUNCATE TABLE mysql.slow_log;
|
|
ALTER TABLE mysql.slow_log ENGINE = MyISAM;
|
|
ALTER TABLE mysql.slow_log
|
|
ADD COLUMN seq BIGINT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY;
|
|
SET SESSION long_query_time = 1;
|
|
SET GLOBAL slow_query_log = 1;
|
|
FLUSH LOGS;
|
|
SELECT "My own slow query", sleep(2);
|
|
My own slow query sleep(2)
|
|
My own slow query 0
|
|
SELECT "My own slow query", sleep(2);
|
|
My own slow query sleep(2)
|
|
My own slow query 0
|
|
SELECT "My own slow query", sleep(2);
|
|
My own slow query sleep(2)
|
|
My own slow query 0
|
|
SELECT "My own slow query", sleep(2);
|
|
My own slow query sleep(2)
|
|
My own slow query 0
|
|
SELECT * FROM mysql.slow_log WHERE seq >= 2 LIMIT 3;
|
|
start_time user_host query_time lock_time rows_sent rows_examined db last_insert_id insert_id server_id sql_text seq
|
|
START_TIME USER_HOST QUERY_TIME 00:00:00 1 0 test NULL NULL 1 SELECT "My own slow query", sleep(2) 2
|
|
START_TIME USER_HOST QUERY_TIME 00:00:00 1 0 test NULL NULL 1 SELECT "My own slow query", sleep(2) 3
|
|
START_TIME USER_HOST QUERY_TIME 00:00:00 1 0 test NULL NULL 1 SELECT "My own slow query", sleep(2) 4
|
|
SET GLOBAL slow_query_log = 0;
|
|
SET SESSION long_query_time =@old_long_query_time;
|
|
FLUSH LOGS;
|
|
ALTER TABLE mysql.slow_log DROP COLUMN seq;
|
|
ALTER TABLE mysql.slow_log ENGINE = CSV;
|