mirror of
https://github.com/MariaDB/server.git
synced 2025-01-29 18:20:07 +01:00
3ef111610b
When the server is started with `--event-scheduler=ON` and with `--skip-grant-tables` (or built as embedded server which has no grant tables at all), the event scheduler *appears* to be enabled (`SELECT @@global.event_scheduler` returns `'ON'`), but attempting to manipulate it in any way returns a misleading error message: "Cannot proceed, because event scheduler is disabled" Possible solutions: 1. Fast-fail: fail immediately on startup if `EVENT_SCHEDULER` is set to any value other than `DISABLED` when starting up without grant tables, then prevent `SET GLOBAL event_scheduler` while running. Problem: there are existing setup scripts and code which start with this combination and assume it will not fail. 2. Warn and change value: if `EVENT_SCHEDULER` is set to any value other than `DISABLED` when starting, print a warning and change it immediately to `DISABLED`. Advantage: The value of the `EVENT_SCHEDULER` system variable after startup will be consistent with its functional unavailability. 3. Display a clear error: if `EVENT_SCHEDULER` is enabled, but grant tables are not enabled, then ensure error messages clearly explain the fact that the combination is not supported. Advantage: The error message encountered by the end user when attempting to manipulate the event scheduler (such as `CREATE EVENT`) is clear and explicit. This commit implements the combination of solutions (2) and (3): it will set `EVENT_SCHEDULER=DISABLED` on startup (reflecting the functional reality) and it will print a startup warning, *and* it will print a *distinct* error message each time that an end user attempts to manipulate the event scheduler, so that the end user will clearly understand the problem even if the startup messages are not visible at that point. It also adds an MTR test `main.events_skip_grant_tables` to verify the expected behavior, and the unmodified `main.events_restart` test continues to demonstrate no change in the error message when the event scheduler is non-functional for *different* reasons. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services
154 lines
4.6 KiB
Text
154 lines
4.6 KiB
Text
call mtr.add_suppression("Event Scheduler will not function when starting with --skip-grant-tables or --bootstrap.");
|
|
use test;
|
|
CREATE TABLE t1(c INT);
|
|
CREATE TRIGGER t1_bi BEFORE INSERT ON t1
|
|
FOR EACH ROW
|
|
SET @a = 1;
|
|
CREATE VIEW v1 AS SELECT * FROM t1;
|
|
CREATE PROCEDURE p1()
|
|
SELECT 1;
|
|
CREATE FUNCTION f1() RETURNS INT
|
|
RETURN 1;
|
|
CREATE DEFINER=a@b TRIGGER ti_ai AFTER INSERT ON t1
|
|
FOR EACH ROW
|
|
SET @b = 1;
|
|
CREATE DEFINER=a@b VIEW v2 AS SELECT * FROM t1;
|
|
CREATE DEFINER=a@b PROCEDURE p2()
|
|
SELECT 2;
|
|
CREATE DEFINER=a@b FUNCTION f2() RETURNS INT
|
|
RETURN 2;
|
|
CREATE DEFINER=a@'' TRIGGER ti_bu BEFORE UPDATE ON t1
|
|
FOR EACH ROW
|
|
SET @c = 1;
|
|
CREATE DEFINER=a@'' VIEW v3 AS SELECT * FROM t1;
|
|
CREATE DEFINER=a@'' PROCEDURE p3()
|
|
SELECT 3;
|
|
CREATE DEFINER=a@'' FUNCTION f3() RETURNS INT
|
|
RETURN 3;
|
|
SHOW CREATE VIEW v3;
|
|
View Create View character_set_client collation_connection
|
|
v3 CREATE ALGORITHM=UNDEFINED DEFINER=`a`@`%` SQL SECURITY DEFINER VIEW `v3` AS select `t1`.`c` AS `c` from `t1` latin1 latin1_swedish_ci
|
|
SHOW CREATE PROCEDURE p3;
|
|
Procedure sql_mode Create Procedure character_set_client collation_connection Database Collation
|
|
p3 STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION CREATE DEFINER=`a`@`%` PROCEDURE `p3`()
|
|
SELECT 3 latin1 latin1_swedish_ci latin1_swedish_ci
|
|
SHOW CREATE FUNCTION f3;
|
|
Function sql_mode Create Function character_set_client collation_connection Database Collation
|
|
f3 STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION CREATE DEFINER=`a`@`%` FUNCTION `f3`() RETURNS int(11)
|
|
RETURN 3 latin1 latin1_swedish_ci latin1_swedish_ci
|
|
DROP TRIGGER t1_bi;
|
|
DROP TRIGGER ti_ai;
|
|
DROP TRIGGER ti_bu;
|
|
DROP VIEW v1;
|
|
DROP VIEW v2;
|
|
DROP VIEW v3;
|
|
DROP TABLE t1;
|
|
DROP PROCEDURE p1;
|
|
DROP PROCEDURE p2;
|
|
DROP PROCEDURE p3;
|
|
DROP FUNCTION f1;
|
|
DROP FUNCTION f2;
|
|
DROP FUNCTION f3;
|
|
#
|
|
# Bug #26807 "set global event_scheduler=1" and --skip-grant-tables crashes server
|
|
#
|
|
set global event_scheduler=1;
|
|
ERROR HY000: The MariaDB server is running with the --event-scheduler=DISABLED or --skip-grant-tables option so it cannot execute this statement
|
|
#
|
|
# Bug#26285 Selecting information_schema crahes server
|
|
#
|
|
select count(*) from information_schema.COLUMN_PRIVILEGES;
|
|
count(*)
|
|
0
|
|
select count(*) from information_schema.SCHEMA_PRIVILEGES;
|
|
count(*)
|
|
0
|
|
select count(*) from information_schema.TABLE_PRIVILEGES;
|
|
count(*)
|
|
0
|
|
select count(*) from information_schema.USER_PRIVILEGES;
|
|
count(*)
|
|
0
|
|
#
|
|
# End of 5.0 tests
|
|
#
|
|
#
|
|
# Bug#29817 Queries with UDF fail with non-descriptive error
|
|
# if mysql.proc is missing
|
|
#
|
|
select no_such_function(1);
|
|
ERROR 42000: FUNCTION test.no_such_function does not exist
|
|
#
|
|
# End of 5.1 tests
|
|
#
|
|
#
|
|
# MDEV-8280 crash in 'show global status' with --skip-grant-tables
|
|
#
|
|
show global status like 'Acl%';
|
|
Variable_name Value
|
|
Acl_column_grants 0
|
|
Acl_database_grants 0
|
|
Acl_function_grants 0
|
|
Acl_procedure_grants 0
|
|
Acl_package_spec_grants 0
|
|
Acl_package_body_grants 0
|
|
Acl_proxy_users 0
|
|
Acl_role_grants 0
|
|
Acl_roles 0
|
|
Acl_table_grants 0
|
|
Acl_users 0
|
|
#
|
|
# End of 10.1 tests
|
|
#
|
|
#
|
|
# MDEV-22966 Server crashes or hangs with SET ROLE when started with skip-grant-tables
|
|
#
|
|
set role x;
|
|
ERROR HY000: The MariaDB server is running with the --skip-grant-tables option so it cannot execute this statement
|
|
#
|
|
# End of 10.2 tests
|
|
#
|
|
show create user root@localhost;
|
|
ERROR HY000: The MariaDB server is running with the --skip-grant-tables option so it cannot execute this statement
|
|
insert mysql.global_priv values ('foo', 'bar', '{}');
|
|
insert mysql.global_priv values ('baz', 'baz', '{"plugin":"baz"}');
|
|
set password for bar@foo = password("pass word");
|
|
ERROR HY000: The MariaDB server is running with the --skip-grant-tables option so it cannot execute this statement
|
|
flush privileges;
|
|
show create user root@localhost;
|
|
CREATE USER for root@localhost
|
|
CREATE USER `root`@`localhost`
|
|
show create user bar@foo;
|
|
CREATE USER for bar@foo
|
|
CREATE USER `bar`@`foo`
|
|
show create user baz@baz;
|
|
CREATE USER for baz@baz
|
|
CREATE USER `baz`@`baz` IDENTIFIED VIA baz
|
|
set password for bar@foo = password("pass word");
|
|
show create user bar@foo;
|
|
CREATE USER for bar@foo
|
|
CREATE USER `bar`@`foo` IDENTIFIED BY PASSWORD '*EDBBEA7F4E7B5D8B0BC8D7AC5D1936FB7DA10611'
|
|
alter user baz@baz identified with mysql_native_password as password("baz");
|
|
show create user baz@baz;
|
|
CREATE USER for baz@baz
|
|
CREATE USER `baz`@`baz` IDENTIFIED BY PASSWORD '*E52096EF8EB0240275A7FE9E069101C33F98CF07'
|
|
drop user bar@foo;
|
|
drop user baz@baz;
|
|
# restart
|
|
#
|
|
# End of 10.3 tests
|
|
#
|
|
#
|
|
# MDEV-24815 Show "--skip-grant-tables" state in SYSTEM VARIABLES
|
|
#
|
|
SELECT @@skip_grant_tables AS EXPECT_1;
|
|
EXPECT_1
|
|
1
|
|
# restart: --skip-skip-grant-tables
|
|
SELECT @@skip_grant_tables AS EXPECT_0;
|
|
EXPECT_0
|
|
0
|
|
# restart: --skip-grant-tables
|
|
#
|
|
# End of 10.10 tests
|
|
#
|