mirror of
https://github.com/MariaDB/server.git
synced 2025-01-19 05:22:25 +01:00
fbe17c2a36
For "count(*) while index_column = value" an index read is done. It consists of an index scan and retrieval of each key. For efficiency reasons the index scan stores the key in the special buffer 'lastkey2' once only. At the first iteration it notes this fact with the flag HA_STATE_RNEXT_SAME in 'info->update'. For efficiency reasons, the key retrieval for blobs does not allocate a new buffer, but uses 'lastkey2'... Now I clear the HA_STATE_RNEXT_SAME flag whenever the buffer has been polluted. In this case, the index scan copies the key value again (and sets the flag again). include/my_base.h: Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX Changed the comment for HA_STATE_RNEXT_SAME as a warning for future uses. myisam/mi_delete.c: Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX Removing the flag HA_STATE_RNEXT_SAME from info->update if info->lastkey2 was reused for another purpose than index scanning. myisam/mi_key.c: Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX Removing the flag HA_STATE_RNEXT_SAME from info->update if info->lastkey2 was reused for another purpose than index scanning. myisam/mi_rnext_same.c: Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX Removed trailing space and fixed a comment. myisam/mi_unique.c: Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX Removing the flag HA_STATE_RNEXT_SAME from info->update if info->lastkey2 was reused for another purpose than index scanning. myisam/mi_update.c: Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX Removing the flag HA_STATE_RNEXT_SAME from info->update if info->lastkey2 was reused for another purpose than index scanning. myisam/mi_write.c: Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX Removing the flag HA_STATE_RNEXT_SAME from info->update if info->lastkey2 was reused for another purpose than index scanning. mysql-test/r/myisam.result: Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX Added test result. mysql-test/t/myisam.test: Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX Added test.
540 lines
14 KiB
C
540 lines
14 KiB
C
/* Copyright (C) 2000 MySQL AB & MySQL Finland AB & TCX DataKonsult AB
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */
|
|
|
|
/* Functions to handle keys */
|
|
|
|
#include "myisamdef.h"
|
|
#include "m_ctype.h"
|
|
#include "sp_defs.h"
|
|
#ifdef HAVE_IEEEFP_H
|
|
#include <ieeefp.h>
|
|
#endif
|
|
|
|
#define CHECK_KEYS /* Enable safety checks */
|
|
|
|
#define FIX_LENGTH(cs, pos, length, char_length) \
|
|
do { \
|
|
if (length > char_length) \
|
|
char_length= my_charpos(cs, pos, pos+length, char_length); \
|
|
set_if_smaller(char_length,length); \
|
|
} while(0)
|
|
|
|
static int _mi_put_key_in_record(MI_INFO *info,uint keynr,byte *record);
|
|
|
|
/*
|
|
** Make a intern key from a record
|
|
** Ret: Length of key
|
|
*/
|
|
|
|
uint _mi_make_key(register MI_INFO *info, uint keynr, uchar *key,
|
|
const byte *record, my_off_t filepos)
|
|
{
|
|
byte *pos,*end;
|
|
uchar *start;
|
|
reg1 HA_KEYSEG *keyseg;
|
|
my_bool is_ft= info->s->keyinfo[keynr].flag & HA_FULLTEXT;
|
|
DBUG_ENTER("_mi_make_key");
|
|
|
|
if (info->s->keyinfo[keynr].flag & HA_SPATIAL)
|
|
{
|
|
/*
|
|
TODO: nulls processing
|
|
*/
|
|
#ifdef HAVE_SPATIAL
|
|
return sp_make_key(info,keynr,key,record,filepos);
|
|
#else
|
|
DBUG_ASSERT(0); /* mi_open should check that this never happens*/
|
|
#endif
|
|
}
|
|
|
|
start=key;
|
|
for (keyseg=info->s->keyinfo[keynr].seg ; keyseg->type ;keyseg++)
|
|
{
|
|
enum ha_base_keytype type=(enum ha_base_keytype) keyseg->type;
|
|
uint length=keyseg->length;
|
|
uint char_length;
|
|
CHARSET_INFO *cs=keyseg->charset;
|
|
|
|
if (keyseg->null_bit)
|
|
{
|
|
if (record[keyseg->null_pos] & keyseg->null_bit)
|
|
{
|
|
*key++= 0; /* NULL in key */
|
|
continue;
|
|
}
|
|
*key++=1; /* Not NULL */
|
|
}
|
|
|
|
char_length= ((!is_ft && cs && cs->mbmaxlen > 1) ? length/cs->mbmaxlen :
|
|
length);
|
|
|
|
pos= (byte*) record+keyseg->start;
|
|
if (keyseg->flag & HA_SPACE_PACK)
|
|
{
|
|
end= pos + length;
|
|
if (type != HA_KEYTYPE_NUM)
|
|
{
|
|
while (end > pos && end[-1] == ' ')
|
|
end--;
|
|
}
|
|
else
|
|
{
|
|
while (pos < end && pos[0] == ' ')
|
|
pos++;
|
|
}
|
|
length=(uint) (end-pos);
|
|
FIX_LENGTH(cs, pos, length, char_length);
|
|
store_key_length_inc(key,char_length);
|
|
memcpy((byte*) key,(byte*) pos,(size_t) char_length);
|
|
key+=char_length;
|
|
continue;
|
|
}
|
|
if (keyseg->flag & HA_VAR_LENGTH)
|
|
{
|
|
uint tmp_length=uint2korr(pos);
|
|
pos+=2; /* Skip VARCHAR length */
|
|
set_if_smaller(length,tmp_length);
|
|
FIX_LENGTH(cs, pos, length, char_length);
|
|
store_key_length_inc(key,char_length);
|
|
memcpy((byte*) key,(byte*) pos,(size_t) char_length);
|
|
key+= char_length;
|
|
continue;
|
|
}
|
|
else if (keyseg->flag & HA_BLOB_PART)
|
|
{
|
|
uint tmp_length=_mi_calc_blob_length(keyseg->bit_start,pos);
|
|
memcpy_fixed((byte*) &pos,pos+keyseg->bit_start,sizeof(char*));
|
|
set_if_smaller(length,tmp_length);
|
|
FIX_LENGTH(cs, pos, length, char_length);
|
|
store_key_length_inc(key,char_length);
|
|
memcpy((byte*) key,(byte*) pos,(size_t) char_length);
|
|
key+= char_length;
|
|
continue;
|
|
}
|
|
else if (keyseg->flag & HA_SWAP_KEY)
|
|
{ /* Numerical column */
|
|
#ifdef HAVE_ISNAN
|
|
if (type == HA_KEYTYPE_FLOAT)
|
|
{
|
|
float nr;
|
|
float4get(nr,pos);
|
|
if (isnan(nr))
|
|
{
|
|
/* Replace NAN with zero */
|
|
bzero(key,length);
|
|
key+=length;
|
|
continue;
|
|
}
|
|
}
|
|
else if (type == HA_KEYTYPE_DOUBLE)
|
|
{
|
|
double nr;
|
|
float8get(nr,pos);
|
|
if (isnan(nr))
|
|
{
|
|
bzero(key,length);
|
|
key+=length;
|
|
continue;
|
|
}
|
|
}
|
|
#endif
|
|
pos+=length;
|
|
while (length--)
|
|
{
|
|
*key++ = *--pos;
|
|
}
|
|
continue;
|
|
}
|
|
FIX_LENGTH(cs, pos, length, char_length);
|
|
memcpy((byte*) key, pos, char_length);
|
|
if (length > char_length)
|
|
cs->cset->fill(cs, key+char_length, length-char_length, ' ');
|
|
key+= length;
|
|
}
|
|
_mi_dpointer(info,key,filepos);
|
|
DBUG_PRINT("exit",("keynr: %d",keynr));
|
|
DBUG_DUMP("key",(byte*) start,(uint) (key-start)+keyseg->length);
|
|
DBUG_EXECUTE("key",
|
|
_mi_print_key(DBUG_FILE,info->s->keyinfo[keynr].seg,start,
|
|
(uint) (key-start)););
|
|
DBUG_RETURN((uint) (key-start)); /* Return keylength */
|
|
} /* _mi_make_key */
|
|
|
|
|
|
/*
|
|
Pack a key to intern format from given format (c_rkey)
|
|
|
|
SYNOPSIS
|
|
_mi_pack_key()
|
|
info MyISAM handler
|
|
uint keynr key number
|
|
key Store packed key here
|
|
old Not packed key
|
|
k_length Length of 'old' to use
|
|
last_used_keyseg out parameter. May be NULL
|
|
|
|
RETURN
|
|
length of packed key
|
|
|
|
last_use_keyseg Store pointer to the keyseg after the last used one
|
|
*/
|
|
|
|
uint _mi_pack_key(register MI_INFO *info, uint keynr, uchar *key, uchar *old,
|
|
uint k_length, HA_KEYSEG **last_used_keyseg)
|
|
{
|
|
uchar *start_key=key;
|
|
HA_KEYSEG *keyseg;
|
|
my_bool is_ft= info->s->keyinfo[keynr].flag & HA_FULLTEXT;
|
|
DBUG_ENTER("_mi_pack_key");
|
|
|
|
for (keyseg=info->s->keyinfo[keynr].seg ;
|
|
keyseg->type && (int) k_length > 0;
|
|
old+=keyseg->length, keyseg++)
|
|
{
|
|
enum ha_base_keytype type=(enum ha_base_keytype) keyseg->type;
|
|
uint length=min((uint) keyseg->length,(uint) k_length);
|
|
uint char_length;
|
|
uchar *pos;
|
|
CHARSET_INFO *cs=keyseg->charset;
|
|
|
|
if (keyseg->null_bit)
|
|
{
|
|
k_length--;
|
|
if (!(*key++= (char) 1-*old++)) /* Copy null marker */
|
|
{
|
|
k_length-=length;
|
|
if (keyseg->flag & (HA_VAR_LENGTH | HA_BLOB_PART))
|
|
{
|
|
old+= 2;
|
|
k_length-=2; /* Skip length */
|
|
}
|
|
continue; /* Found NULL */
|
|
}
|
|
}
|
|
char_length= (!is_ft && cs && cs->mbmaxlen > 1) ? length/cs->mbmaxlen : length;
|
|
pos=old;
|
|
if (keyseg->flag & HA_SPACE_PACK)
|
|
{
|
|
uchar *end=pos+length;
|
|
if (type != HA_KEYTYPE_NUM)
|
|
{
|
|
while (end > pos && end[-1] == ' ')
|
|
end--;
|
|
}
|
|
else
|
|
{
|
|
while (pos < end && pos[0] == ' ')
|
|
pos++;
|
|
}
|
|
k_length-=length;
|
|
length=(uint) (end-pos);
|
|
FIX_LENGTH(cs, pos, length, char_length);
|
|
store_key_length_inc(key,char_length);
|
|
memcpy((byte*) key,pos,(size_t) char_length);
|
|
key+= char_length;
|
|
continue;
|
|
}
|
|
else if (keyseg->flag & (HA_VAR_LENGTH | HA_BLOB_PART))
|
|
{
|
|
/* Length of key-part used with mi_rkey() always 2 */
|
|
uint tmp_length=uint2korr(pos);
|
|
k_length-= 2+length;
|
|
pos+=2;
|
|
set_if_smaller(length,tmp_length); /* Safety */
|
|
FIX_LENGTH(cs, pos, length, char_length);
|
|
store_key_length_inc(key,char_length);
|
|
old+=2; /* Skip length */
|
|
memcpy((byte*) key, pos,(size_t) char_length);
|
|
key+= char_length;
|
|
continue;
|
|
}
|
|
else if (keyseg->flag & HA_SWAP_KEY)
|
|
{ /* Numerical column */
|
|
pos+=length;
|
|
k_length-=length;
|
|
while (length--)
|
|
{
|
|
*key++ = *--pos;
|
|
}
|
|
continue;
|
|
}
|
|
FIX_LENGTH(cs, pos, length, char_length);
|
|
memcpy((byte*) key, pos, char_length);
|
|
if (length > char_length)
|
|
cs->cset->fill(cs,key+char_length, length-char_length, ' ');
|
|
key+= length;
|
|
k_length-=length;
|
|
}
|
|
if (last_used_keyseg)
|
|
*last_used_keyseg= keyseg;
|
|
|
|
#ifdef NOT_USED
|
|
if (keyseg->type)
|
|
{
|
|
/* Part-key ; fill with ASCII 0 for easier searching */
|
|
length= (uint) -k_length; /* unused part of last key */
|
|
do
|
|
{
|
|
if (keyseg->flag & HA_NULL_PART)
|
|
length++;
|
|
if (keyseg->flag & HA_SPACE_PACK)
|
|
length+=2;
|
|
else
|
|
length+= keyseg->length;
|
|
keyseg++;
|
|
} while (keyseg->type);
|
|
bzero((byte*) key,length);
|
|
key+=length;
|
|
}
|
|
#endif
|
|
DBUG_RETURN((uint) (key-start_key));
|
|
} /* _mi_pack_key */
|
|
|
|
|
|
|
|
/*
|
|
Store found key in record
|
|
|
|
SYNOPSIS
|
|
_mi_put_key_in_record()
|
|
info MyISAM handler
|
|
keynr Key number that was used
|
|
record Store key here
|
|
|
|
Last read key is in info->lastkey
|
|
|
|
NOTES
|
|
Used when only-keyread is wanted
|
|
|
|
RETURN
|
|
0 ok
|
|
1 error
|
|
*/
|
|
|
|
static int _mi_put_key_in_record(register MI_INFO *info, uint keynr,
|
|
byte *record)
|
|
{
|
|
reg2 byte *key;
|
|
byte *pos,*key_end;
|
|
reg1 HA_KEYSEG *keyseg;
|
|
byte *blob_ptr;
|
|
DBUG_ENTER("_mi_put_key_in_record");
|
|
|
|
blob_ptr= info->lastkey2; /* Place to put blob parts */
|
|
key=(byte*) info->lastkey; /* KEy that was read */
|
|
key_end=key+info->lastkey_length;
|
|
for (keyseg=info->s->keyinfo[keynr].seg ; keyseg->type ;keyseg++)
|
|
{
|
|
if (keyseg->null_bit)
|
|
{
|
|
if (!*key++)
|
|
{
|
|
record[keyseg->null_pos]|= keyseg->null_bit;
|
|
continue;
|
|
}
|
|
record[keyseg->null_pos]&= ~keyseg->null_bit;
|
|
}
|
|
if (keyseg->flag & HA_SPACE_PACK)
|
|
{
|
|
uint length;
|
|
get_key_length(length,key);
|
|
#ifdef CHECK_KEYS
|
|
if (length > keyseg->length || key+length > key_end)
|
|
goto err;
|
|
#endif
|
|
pos= record+keyseg->start;
|
|
if (keyseg->type != (int) HA_KEYTYPE_NUM)
|
|
{
|
|
memcpy(pos,key,(size_t) length);
|
|
bfill(pos+length,keyseg->length-length,' ');
|
|
}
|
|
else
|
|
{
|
|
bfill(pos,keyseg->length-length,' ');
|
|
memcpy(pos+keyseg->length-length,key,(size_t) length);
|
|
}
|
|
key+=length;
|
|
continue;
|
|
}
|
|
|
|
if (keyseg->flag & HA_VAR_LENGTH)
|
|
{
|
|
uint length;
|
|
get_key_length(length,key);
|
|
#ifdef CHECK_KEYS
|
|
if (length > keyseg->length || key+length > key_end)
|
|
goto err;
|
|
#endif
|
|
memcpy(record+keyseg->start,(byte*) key, length);
|
|
key+= length;
|
|
}
|
|
else if (keyseg->flag & HA_BLOB_PART)
|
|
{
|
|
uint length;
|
|
get_key_length(length,key);
|
|
#ifdef CHECK_KEYS
|
|
if (length > keyseg->length || key+length > key_end)
|
|
goto err;
|
|
#endif
|
|
memcpy(record+keyseg->start+keyseg->bit_start,
|
|
(char*) &blob_ptr,sizeof(char*));
|
|
memcpy(blob_ptr,key,length);
|
|
blob_ptr+=length;
|
|
|
|
/* The above changed info->lastkey2. Inform mi_rnext_same(). */
|
|
info->update&= ~HA_STATE_RNEXT_SAME;
|
|
|
|
_my_store_blob_length(record+keyseg->start,
|
|
(uint) keyseg->bit_start,length);
|
|
key+=length;
|
|
}
|
|
else if (keyseg->flag & HA_SWAP_KEY)
|
|
{
|
|
byte *to= record+keyseg->start+keyseg->length;
|
|
byte *end= key+keyseg->length;
|
|
#ifdef CHECK_KEYS
|
|
if (end > key_end)
|
|
goto err;
|
|
#endif
|
|
do
|
|
{
|
|
*--to= *key++;
|
|
} while (key != end);
|
|
continue;
|
|
}
|
|
else
|
|
{
|
|
#ifdef CHECK_KEYS
|
|
if (key+keyseg->length > key_end)
|
|
goto err;
|
|
#endif
|
|
memcpy(record+keyseg->start,(byte*) key,
|
|
(size_t) keyseg->length);
|
|
key+= keyseg->length;
|
|
}
|
|
}
|
|
DBUG_RETURN(0);
|
|
|
|
err:
|
|
DBUG_RETURN(1); /* Crashed row */
|
|
} /* _mi_put_key_in_record */
|
|
|
|
|
|
/* Here when key reads are used */
|
|
|
|
int _mi_read_key_record(MI_INFO *info, my_off_t filepos, byte *buf)
|
|
{
|
|
fast_mi_writeinfo(info);
|
|
if (filepos != HA_OFFSET_ERROR)
|
|
{
|
|
if (info->lastinx >= 0)
|
|
{ /* Read only key */
|
|
if (_mi_put_key_in_record(info,(uint) info->lastinx,buf))
|
|
{
|
|
my_errno=HA_ERR_CRASHED;
|
|
return -1;
|
|
}
|
|
info->update|= HA_STATE_AKTIV; /* We should find a record */
|
|
return 0;
|
|
}
|
|
my_errno=HA_ERR_WRONG_INDEX;
|
|
}
|
|
return(-1); /* Wrong data to read */
|
|
}
|
|
|
|
|
|
/*
|
|
Update auto_increment info
|
|
|
|
SYNOPSIS
|
|
update_auto_increment()
|
|
info MyISAM handler
|
|
record Row to update
|
|
|
|
IMPLEMENTATION
|
|
Only replace the auto_increment value if it is higher than the previous
|
|
one. For signed columns we don't update the auto increment value if it's
|
|
less than zero.
|
|
*/
|
|
|
|
void update_auto_increment(MI_INFO *info,const byte *record)
|
|
{
|
|
ulonglong value= 0; /* Store unsigned values here */
|
|
longlong s_value= 0; /* Store signed values here */
|
|
HA_KEYSEG *keyseg= info->s->keyinfo[info->s->base.auto_key-1].seg;
|
|
const uchar *key= (uchar*) record + keyseg->start;
|
|
|
|
switch (keyseg->type) {
|
|
case HA_KEYTYPE_INT8:
|
|
s_value= (longlong) *(char*)key;
|
|
break;
|
|
case HA_KEYTYPE_BINARY:
|
|
value=(ulonglong) *(uchar*) key;
|
|
break;
|
|
case HA_KEYTYPE_SHORT_INT:
|
|
s_value= (longlong) sint2korr(key);
|
|
break;
|
|
case HA_KEYTYPE_USHORT_INT:
|
|
value=(ulonglong) uint2korr(key);
|
|
break;
|
|
case HA_KEYTYPE_LONG_INT:
|
|
s_value= (longlong) sint4korr(key);
|
|
break;
|
|
case HA_KEYTYPE_ULONG_INT:
|
|
value=(ulonglong) uint4korr(key);
|
|
break;
|
|
case HA_KEYTYPE_INT24:
|
|
s_value= (longlong) sint3korr(key);
|
|
break;
|
|
case HA_KEYTYPE_UINT24:
|
|
value=(ulonglong) uint3korr(key);
|
|
break;
|
|
case HA_KEYTYPE_FLOAT: /* This shouldn't be used */
|
|
{
|
|
float f_1;
|
|
float4get(f_1,key);
|
|
/* Ignore negative values */
|
|
value = (f_1 < (float) 0.0) ? 0 : (ulonglong) f_1;
|
|
break;
|
|
}
|
|
case HA_KEYTYPE_DOUBLE: /* This shouldn't be used */
|
|
{
|
|
double f_1;
|
|
float8get(f_1,key);
|
|
/* Ignore negative values */
|
|
value = (f_1 < 0.0) ? 0 : (ulonglong) f_1;
|
|
break;
|
|
}
|
|
case HA_KEYTYPE_LONGLONG:
|
|
s_value= sint8korr(key);
|
|
break;
|
|
case HA_KEYTYPE_ULONGLONG:
|
|
value= uint8korr(key);
|
|
break;
|
|
default:
|
|
DBUG_ASSERT(0);
|
|
value=0; /* Error */
|
|
break;
|
|
}
|
|
|
|
/*
|
|
The following code works becasue if s_value < 0 then value is 0
|
|
and if s_value == 0 then value will contain either s_value or the
|
|
correct value.
|
|
*/
|
|
set_if_bigger(info->s->state.auto_increment,
|
|
(s_value > 0) ? (ulonglong) s_value : value);
|
|
}
|