mirror of
https://github.com/MariaDB/server.git
synced 2025-01-17 20:42:30 +01:00
4b0cedf82d
Consider an IN predicate with ROW-type arguments: predicant IN (value1, ..., valueM) where predicant and all values consist of N elements. When performing IN for these arguments, at every position i (1..N) only data type of i-th element of predicant was taken into account, while data types on i-th elements of value1..valueM were not taken. These led to bad comparison data type detection, e.g. when mixing unsigned and signed integer values. After this change all element data types are taken into account. So, for example, a mixture of unsigned and signed values is now calculated using decimal and does not overflow any more. Detailed changes: 1. All comparators for ROW elements are now created recursively at fix_fields() time, inside cmp_item_row::prepare_comparators(). Previously prepare_comparators() installed comparators only for temporal data types, while comparators for other types were installed at execution time, in cmp_item_row::store_value(). 2. Removing comparator creating code from cmp_item_row::store_value(). It was responsible for non-temporal data types. 3. Removing find_date_time_item(). It's not needed any more. All ROW-element data types are now covered by cmp_item_row::prepare_comparators(). 4. Adding a helper method Item_args::alloc_and_extract_row_elements() to extract elements from an array of ROW-type Items, from the given position. Using this method to collect elements from the i-th position and further pass them to Type_handler_hybrid_field_type::aggregate_for_comparison(). 5. Moving the call for alloc_comparators() inside cmp_item_row::prepare_comparators(). This helps to call prepare_comparators() for ROW elements recursively (if elements appear to be ROWs again). Moving alloc_comparators() from "public" to "private".
149 lines
3.9 KiB
Text
149 lines
3.9 KiB
Text
--source include/have_geometry.inc
|
|
--source include/have_debug.inc
|
|
|
|
SET @tmp=ST_GIS_DEBUG(1);
|
|
|
|
--source include/gis_debug.inc
|
|
|
|
|
|
--echo #
|
|
--echo # Start of 10.2 tests
|
|
--echo #
|
|
|
|
--echo #
|
|
--echo # MDEV-10134 Add full support for DEFAULT
|
|
--echo #
|
|
|
|
--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
|
|
CREATE TABLE t1 (a INT DEFAULT ST_GIS_DEBUG(1));
|
|
|
|
--echo #
|
|
--echo # End of 10.2 tests
|
|
--echo #
|
|
|
|
--echo #
|
|
--echo # Start of 10.3 tests
|
|
--echo #
|
|
|
|
--echo #
|
|
--echo # Comparison data type aggregation for pluggable data types
|
|
--echo #
|
|
|
|
SET SESSION debug_dbug="+d,Item_func_in";
|
|
SET SESSION debug_dbug="+d,Predicant_to_list_comparator";
|
|
|
|
CREATE TABLE t1 (a POINT);
|
|
INSERT INTO t1 VALUES (POINT(1,1)),(POINT(1,2)),(POINT(1,3));
|
|
SELECT COUNT(*) FROM t1 WHERE a IN (POINT(1,1),POINT(10,20),POINT(10,30));
|
|
SELECT COUNT(*) FROM t1 WHERE a IN (POINT(1,1),POINT(10,20),POINT(10,30),'test');
|
|
SELECT COUNT(*) FROM t1 WHERE a IN ('test','test1');
|
|
DROP TABLE t1;
|
|
|
|
CREATE TABLE t1 (a TEXT);
|
|
INSERT INTO t1 VALUES ('test'),('test1'),('test2');
|
|
SELECT * FROM t1 WHERE a IN ('test',POINT(1,1));
|
|
DROP TABLE t1;
|
|
|
|
SET SESSION debug_dbug="-d,Predicant_to_list_comparator";
|
|
SET SESSION debug_dbug="-d,Item_func_in";
|
|
|
|
|
|
--echo #
|
|
--echo # MDEV-12238 Add Type_handler::Item_func_{plus|minus|mul|div|mod}_fix_length_and_dec()
|
|
--echo #
|
|
|
|
# This tests is to check that operators '+' and '*' are commutative,
|
|
# while operators '/', '-' and 'MOD' are not commutative.
|
|
#
|
|
# It forces substitution of type_aggregator_for_{plus|minus|mul|div|mod} to
|
|
# type_aggregator_for_result / type_aggregator_non_commutative_test,
|
|
# which have pairs:
|
|
# (GEOMETRY,GEOMETRY)->GEOMETRY
|
|
# (GEOMETRY,VARCHAR)->GEOMETRY
|
|
# Note, they don't not have a pair:
|
|
# (VARCHAR,GEOMETRY)->GEOMETRY
|
|
#
|
|
# Commutative operators should work for all these argument type combinations:
|
|
# (GEOMETRY,GEOMETRY), (GEOMETRY,VARCHAR), (VARCHAR,GEOMETRY).
|
|
# Non-commutative operators should work for:
|
|
# (GEOMETRY,GEOMETRY), (GEOMETRY,VARCHAR),
|
|
# but should fail for (VARCHAR,GEOMETRY).
|
|
#
|
|
# Note, LIMIT 0 is needed to avoid calling str_op(), which does DBUG_ASSERT(0).
|
|
|
|
SET debug_dbug='+d,num_op';
|
|
|
|
# (GEOMETRY,GEOMETRY) gives GEOMETRY for all operators
|
|
CREATE TABLE t1 AS SELECT
|
|
POINT(0,0)+POINT(0,0),
|
|
POINT(0,0)-POINT(0,0),
|
|
POINT(0,0)*POINT(0,0),
|
|
POINT(0,0)/POINT(0,0),
|
|
POINT(0,0) MOD POINT(0,0) LIMIT 0;
|
|
SHOW CREATE TABLE t1;
|
|
DROP TABLE t1;
|
|
|
|
# (GEOMETRY,VARCHAR) gives GEOMETRY for all operators
|
|
CREATE TABLE t1 AS SELECT
|
|
POINT(0,0)+'0',
|
|
POINT(0,0)-'0',
|
|
POINT(0,0)*'0',
|
|
POINT(0,0)/'0',
|
|
POINT(0,0) MOD '0' LIMIT 0;
|
|
SHOW CREATE TABLE t1;
|
|
DROP TABLE t1;
|
|
|
|
# (VARCHAR,GEOMETRY) gives GEOMETRY for commutative operators
|
|
CREATE TABLE t1 AS SELECT
|
|
'0'+POINT(0,0),
|
|
'0'*POINT(0,0) LIMIT 0;
|
|
SHOW CREATE TABLE t1;
|
|
DROP TABLE t1;
|
|
|
|
# (VARCHAR,GEOMETRY) gives an error for non-commutative operators
|
|
--error ER_ILLEGAL_PARAMETER_DATA_TYPES2_FOR_OPERATION
|
|
CREATE TABLE t1 AS SELECT '0'-POINT(0,0) LIMIT 0;
|
|
|
|
--error ER_ILLEGAL_PARAMETER_DATA_TYPES2_FOR_OPERATION
|
|
CREATE TABLE t1 AS SELECT '0'/POINT(0,0) LIMIT 0;
|
|
|
|
--error ER_ILLEGAL_PARAMETER_DATA_TYPES2_FOR_OPERATION
|
|
CREATE TABLE t1 AS SELECT '0' MOD POINT(0,0) LIMIT 0;
|
|
|
|
SET debug_dbug='-d,num_op';
|
|
|
|
--echo #
|
|
--echo # End of 10.3 tests
|
|
--echo #
|
|
|
|
|
|
--echo #
|
|
--echo # Start of 10.4 tests
|
|
--echo #
|
|
|
|
--echo #
|
|
--echo # MDEV-16454 Bad results for IN with ROW
|
|
--echo #
|
|
|
|
SET SESSION debug_dbug="+d,cmp_item";
|
|
SET SESSION debug_dbug="+d,Item_func_in";
|
|
SET SESSION debug_dbug="+d,Predicant_to_list_comparator";
|
|
|
|
SELECT (POINT(1,1),0) IN ((POINT(1,1),0),((POINT(1,1)),1));
|
|
SELECT (1,(POINT(1,1),0)) IN ((1,(POINT(1,1),0)),(0,(POINT(1,1),0)));
|
|
|
|
--error ER_ILLEGAL_PARAMETER_DATA_TYPES2_FOR_OPERATION
|
|
SELECT (1,0) IN ((POINT(1,1),0),(0,0));
|
|
SHOW WARNINGS;
|
|
|
|
--error ER_ILLEGAL_PARAMETER_DATA_TYPES2_FOR_OPERATION
|
|
SELECT (1,(0,0)) IN ((1,(POINT(1,1),0)),(0,(0,0)));
|
|
SHOW WARNINGS;
|
|
|
|
SET SESSION debug_dbug="-d,Predicant_to_list_comparator";
|
|
SET SESSION debug_dbug="-d,Item_func_in";
|
|
SET SESSION debug_dbug="-d,cmp_item";
|
|
|
|
--echo #
|
|
--echo # End of 10.4 tests
|
|
--echo #
|