mirror of
https://github.com/MariaDB/server.git
synced 2025-01-30 10:31:54 +01:00
5a759d31f7
Benefits of this patch: - Removed a lot of calls to strlen(), especially for field_string - Strings generated by parser are now const strings, less chance of accidently changing a string - Removed a lot of calls with LEX_STRING as parameter (changed to pointer) - More uniform code - Item::name_length was not kept up to date. Now fixed - Several bugs found and fixed (Access to null pointers, access of freed memory, wrong arguments to printf like functions) - Removed a lot of casts from (const char*) to (char*) Changes: - This caused some ABI changes - lex_string_set now uses LEX_CSTRING - Some fucntions are now taking const char* instead of char* - Create_field::change and after changed to LEX_CSTRING - handler::connect_string, comment and engine_name() changed to LEX_CSTRING - Checked printf() related calls to find bugs. Found and fixed several errors in old code. - A lot of changes from LEX_STRING to LEX_CSTRING, especially related to parsing and events. - Some changes from LEX_STRING and LEX_STRING & to LEX_CSTRING* - Some changes for char* to const char* - Added printf argument checking for my_snprintf() - Introduced null_clex_str, star_clex_string, temp_lex_str to simplify code - Added item_empty_name and item_used_name to be able to distingush between items that was given an empty name and items that was not given a name This is used in sql_yacc.yy to know when to give an item a name. - select table_name."*' is not anymore same as table_name.* - removed not used function Item::rename() - Added comparision of item->name_length before some calls to my_strcasecmp() to speed up comparison - Moved Item_sp_variable::make_field() from item.h to item.cc - Some minimal code changes to avoid copying to const char * - Fixed wrong error message in wsrep_mysql_parse() - Fixed wrong code in find_field_in_natural_join() where real_item() was set when it shouldn't - ER_ERROR_ON_RENAME was used with extra arguments. - Removed some (wrong) ER_OUTOFMEMORY, as alloc_root will already give the error. TODO: - Check possible unsafe casts in plugin/auth_examples/qa_auth_interface.c - Change code to not modify LEX_CSTRING for database name (as part of lower_case_table_names)
197 lines
5.4 KiB
C++
197 lines
5.4 KiB
C++
/* Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */
|
|
|
|
#include <my_global.h>
|
|
#include "datadict.h"
|
|
#include "sql_priv.h"
|
|
#include "sql_class.h"
|
|
#include "sql_table.h"
|
|
#include "ha_sequence.h"
|
|
|
|
static int read_string(File file, uchar**to, size_t length)
|
|
{
|
|
DBUG_ENTER("read_string");
|
|
|
|
my_free(*to);
|
|
if (!(*to= (uchar*) my_malloc(length+1,MYF(MY_WME))) ||
|
|
mysql_file_read(file, *to, length, MYF(MY_NABP)))
|
|
{
|
|
my_free(*to);
|
|
*to= 0;
|
|
DBUG_RETURN(1);
|
|
}
|
|
*((char*) *to+length)= '\0'; // C-style safety
|
|
DBUG_RETURN (0);
|
|
}
|
|
|
|
|
|
/**
|
|
Check type of .frm if we are not going to parse it.
|
|
|
|
@param[in] thd The current session.
|
|
@param[in] path path to FRM file.
|
|
@param[in/out] engine_name table engine name (length < NAME_CHAR_LEN)
|
|
|
|
engine_name is a LEX_CSTRING, where engine_name->str must point to
|
|
a buffer of at least NAME_CHAR_LEN+1 bytes.
|
|
|
|
@param[out] is_sequence 1 if table is a SEQUENCE, 0 otherwise
|
|
|
|
@retval TABLE_TYPE_UNKNOWN error
|
|
@retval TABLE_TYPE_TABLE table
|
|
@retval TABLE_TYPE_SEQUENCE sequence table
|
|
@retval TABLE_TYPE_VIEW view
|
|
*/
|
|
|
|
Table_type dd_frm_type(THD *thd, char *path, LEX_CSTRING *engine_name,
|
|
bool *is_sequence)
|
|
{
|
|
File file;
|
|
uchar header[40]; //"TYPE=VIEW\n" it is 10 characters
|
|
size_t error;
|
|
Table_type type= TABLE_TYPE_UNKNOWN;
|
|
uchar dbt;
|
|
DBUG_ENTER("dd_frm_type");
|
|
|
|
*is_sequence= 0;
|
|
|
|
if ((file= mysql_file_open(key_file_frm, path, O_RDONLY | O_SHARE, MYF(0)))
|
|
< 0)
|
|
DBUG_RETURN(TABLE_TYPE_UNKNOWN);
|
|
error= mysql_file_read(file, (uchar*) header, sizeof(header), MYF(MY_NABP));
|
|
|
|
if (error)
|
|
goto err;
|
|
if (!strncmp((char*) header, "TYPE=VIEW\n", 10))
|
|
{
|
|
type= TABLE_TYPE_VIEW;
|
|
goto err;
|
|
}
|
|
|
|
type= TABLE_TYPE_NORMAL;
|
|
|
|
if (!is_binary_frm_header(header) || !engine_name)
|
|
goto err;
|
|
|
|
engine_name->length= 0;
|
|
dbt= header[3];
|
|
|
|
/* cannot use ha_resolve_by_legacy_type without a THD */
|
|
if (thd && dbt < DB_TYPE_FIRST_DYNAMIC)
|
|
{
|
|
handlerton *ht= ha_resolve_by_legacy_type(thd, (enum legacy_db_type)dbt);
|
|
if (ht)
|
|
{
|
|
*engine_name= hton2plugin[ht->slot]->name;
|
|
goto err;
|
|
}
|
|
}
|
|
|
|
if (((header[39] >> 4) & 3) == HA_CHOICE_YES)
|
|
*is_sequence= 1;
|
|
|
|
/* read the true engine name */
|
|
{
|
|
MY_STAT state;
|
|
uchar *frm_image= 0;
|
|
uint n_length;
|
|
|
|
if (mysql_file_fstat(file, &state, MYF(MY_WME)))
|
|
goto err;
|
|
|
|
if (mysql_file_seek(file, 0, SEEK_SET, MYF(MY_WME)))
|
|
goto err;
|
|
|
|
if (read_string(file, &frm_image, (size_t)state.st_size))
|
|
goto err;
|
|
|
|
if ((n_length= uint4korr(frm_image+55)))
|
|
{
|
|
uint record_offset= uint2korr(frm_image+6)+
|
|
((uint2korr(frm_image+14) == 0xffff ?
|
|
uint4korr(frm_image+47) : uint2korr(frm_image+14)));
|
|
uint reclength= uint2korr(frm_image+16);
|
|
|
|
uchar *next_chunk= frm_image + record_offset + reclength;
|
|
uchar *buff_end= next_chunk + n_length;
|
|
uint connect_string_length= uint2korr(next_chunk);
|
|
next_chunk+= connect_string_length + 2;
|
|
if (next_chunk + 2 < buff_end)
|
|
{
|
|
uint len= uint2korr(next_chunk);
|
|
if (len <= NAME_CHAR_LEN)
|
|
{
|
|
/*
|
|
The following cast is safe as the caller has allocated buffer
|
|
and it's up to this function to generate the name.
|
|
*/
|
|
strmake((char*) engine_name->str, (char*)next_chunk + 2,
|
|
engine_name->length= len);
|
|
}
|
|
}
|
|
}
|
|
|
|
my_free(frm_image);
|
|
}
|
|
|
|
/* Probably a table. */
|
|
err:
|
|
mysql_file_close(file, MYF(MY_WME));
|
|
DBUG_RETURN(type);
|
|
}
|
|
|
|
|
|
/*
|
|
Regenerate a metadata locked table.
|
|
|
|
@param thd Thread context.
|
|
@param db Name of the database to which the table belongs to.
|
|
@param name Table name.
|
|
@param path For temporary tables only - path to table files.
|
|
Otherwise NULL (the path is calculated from db and table names).
|
|
|
|
@retval FALSE Success.
|
|
@retval TRUE Error.
|
|
*/
|
|
|
|
bool dd_recreate_table(THD *thd, const char *db, const char *table_name,
|
|
const char *path)
|
|
{
|
|
bool error= TRUE;
|
|
HA_CREATE_INFO create_info;
|
|
char path_buf[FN_REFLEN + 1];
|
|
DBUG_ENTER("dd_recreate_table");
|
|
|
|
memset(&create_info, 0, sizeof(create_info));
|
|
|
|
if (path)
|
|
create_info.options|= HA_LEX_CREATE_TMP_TABLE;
|
|
else
|
|
{
|
|
build_table_filename(path_buf, sizeof(path_buf) - 1,
|
|
db, table_name, "", 0);
|
|
path= path_buf;
|
|
|
|
/* There should be a exclusive metadata lock on the table. */
|
|
DBUG_ASSERT(thd->mdl_context.is_lock_owner(MDL_key::TABLE, db, table_name,
|
|
MDL_EXCLUSIVE));
|
|
}
|
|
|
|
/* Attempt to reconstruct the table. */
|
|
error= ha_create_table(thd, path, db, table_name, &create_info, NULL);
|
|
|
|
DBUG_RETURN(error);
|
|
}
|
|
|