mirror of
https://github.com/MariaDB/server.git
synced 2025-02-02 03:51:50 +01:00
931ac1d781
This is a post-push fix addressing review requests and problems with extra warnings. Problem 1: The sub-statement where an unsafe warning was detected was printed as part of the warning. This was ok for statements that were unsafe due to, e.g., calls to UUID(), but did not make sense for statements that were unsafe because there was more than one autoincrement column (unsafeness in this case comes from the combination of several sub-statements). Fix 1: Instead of printing the sub-statement, print an explanation of why the statement is unsafe. Problem 2: When a recursive construct (i.e., stored proceure, stored function, trigger, view, prepared statement) contained several sub-statements, and at least one of them was unsafe, there would be one unsafeness warning per sub-statement - even for safe sub-statements. Fix 2: Ensure that each type of warning is printed at most once, by remembering throughout the execution of the statement which types of warnings have been printed.
158 lines
4 KiB
Text
158 lines
4 KiB
Text
source include/master-slave.inc;
|
|
source include/have_binlog_format_mixed.inc;
|
|
|
|
# It is not possible to replicate FOUND_ROWS() using statement-based
|
|
# replication, but there is a workaround that stores the result of
|
|
# FOUND_ROWS() into a user variable and then replicates this instead.
|
|
#
|
|
# The purpose of this test case is to test that the workaround works
|
|
# properly even when inside stored programs (i.e., stored routines and
|
|
# triggers).
|
|
|
|
--echo ==== Initialize ====
|
|
|
|
--echo **** On Master ****
|
|
connection master;
|
|
CREATE TABLE t1 (a INT);
|
|
CREATE TABLE logtbl (sect INT, test INT, count INT);
|
|
|
|
INSERT INTO t1 VALUES (1),(2),(3);
|
|
INSERT INTO t1 SELECT 2*a+3 FROM t1;
|
|
INSERT INTO t1 SELECT 2*a+3 FROM t1;
|
|
INSERT INTO t1 SELECT 2*a+3 FROM t1;
|
|
INSERT INTO t1 SELECT 2*a+3 FROM t1;
|
|
INSERT INTO t1 SELECT 2*a+3 FROM t1;
|
|
INSERT INTO t1 SELECT 2*a+3 FROM t1;
|
|
|
|
--echo ==== Checking a procedure ====
|
|
|
|
--echo **** On Master ****
|
|
connection master;
|
|
|
|
# We will now check some stuff that will not work in statement-based
|
|
# replication, but which should cause the binary log to switch to
|
|
# row-based logging.
|
|
|
|
--delimiter $$
|
|
CREATE PROCEDURE just_log(sect INT, test INT) BEGIN
|
|
INSERT INTO logtbl VALUES (sect,test,FOUND_ROWS());
|
|
END $$
|
|
--delimiter ;
|
|
sync_slave_with_master;
|
|
|
|
--echo **** On Master 1 ****
|
|
connection master1;
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a > 5 ORDER BY a LIMIT 1;
|
|
CALL just_log(1,1);
|
|
|
|
--echo **** On Master ****
|
|
connection master;
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a > 5 ORDER BY a LIMIT 1;
|
|
CALL just_log(1,2);
|
|
|
|
--echo **** On Master 1 ****
|
|
|
|
connection master1;
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a < 5 ORDER BY a LIMIT 1;
|
|
CALL just_log(1,3);
|
|
sync_slave_with_master;
|
|
|
|
--echo **** On Master ****
|
|
connection master;
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a > 5 ORDER BY a LIMIT 1;
|
|
CALL just_log(1,4);
|
|
sync_slave_with_master;
|
|
|
|
connection master;
|
|
SELECT * FROM logtbl WHERE sect = 1 ORDER BY sect,test;
|
|
--echo **** On Slave ****
|
|
sync_slave_with_master;
|
|
SELECT * FROM logtbl WHERE sect = 1 ORDER BY sect,test;
|
|
|
|
--echo ==== Checking a stored function ====
|
|
--echo **** On Master ****
|
|
connection master;
|
|
--delimiter $$
|
|
CREATE FUNCTION log_rows(sect INT, test INT)
|
|
RETURNS INT
|
|
BEGIN
|
|
DECLARE found_rows INT;
|
|
SELECT FOUND_ROWS() INTO found_rows;
|
|
INSERT INTO logtbl VALUES(sect,test,found_rows);
|
|
RETURN found_rows;
|
|
END $$
|
|
--delimiter ;
|
|
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a < 5 ORDER BY a LIMIT 1;
|
|
SELECT log_rows(2,1), log_rows(2,2);
|
|
|
|
CREATE TABLE t2 (a INT, b INT);
|
|
|
|
# Trying with referencing FOUND_ROWS() directly in the trigger.
|
|
|
|
--delimiter $$
|
|
CREATE TRIGGER t2_tr BEFORE INSERT ON t2 FOR EACH ROW
|
|
BEGIN
|
|
INSERT INTO logtbl VALUES (NEW.a, NEW.b, FOUND_ROWS());
|
|
END $$
|
|
--delimiter ;
|
|
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a < 5 ORDER BY a LIMIT 1;
|
|
INSERT INTO t2 VALUES (2,3), (2,4);
|
|
|
|
# Referencing FOUND_ROWS() indirectly.
|
|
|
|
DROP TRIGGER t2_tr;
|
|
|
|
--delimiter $$
|
|
CREATE TRIGGER t2_tr BEFORE INSERT ON t2 FOR EACH ROW
|
|
BEGIN
|
|
DECLARE dummy INT;
|
|
SELECT log_rows(NEW.a, NEW.b) INTO dummy;
|
|
END $$
|
|
--delimiter ;
|
|
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a > 5 ORDER BY a LIMIT 1;
|
|
INSERT INTO t2 VALUES (2,5), (2,6);
|
|
|
|
# Putting FOUND_ROWS() even lower in the call chain.
|
|
|
|
connection master;
|
|
DROP TRIGGER t2_tr;
|
|
|
|
--delimiter $$
|
|
CREATE PROCEDURE log_me_inner(sect INT, test INT)
|
|
BEGIN
|
|
DECLARE dummy INT;
|
|
SELECT log_rows(sect, test) INTO dummy;
|
|
SELECT log_rows(sect, test+1) INTO dummy;
|
|
END $$
|
|
|
|
CREATE PROCEDURE log_me(sect INT, test INT)
|
|
BEGIN
|
|
CALL log_me_inner(sect,test);
|
|
END $$
|
|
--delimiter ;
|
|
|
|
--delimiter $$
|
|
CREATE TRIGGER t2_tr BEFORE INSERT ON t2 FOR EACH ROW
|
|
BEGIN
|
|
CALL log_me(NEW.a, NEW.b);
|
|
END $$
|
|
--delimiter ;
|
|
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a > 5 ORDER BY a LIMIT 1;
|
|
INSERT INTO t2 VALUES (2,5), (2,6);
|
|
|
|
SELECT * FROM logtbl WHERE sect = 2 ORDER BY sect,test;
|
|
sync_slave_with_master;
|
|
SELECT * FROM logtbl WHERE sect = 2 ORDER BY sect,test;
|
|
|
|
connection master;
|
|
DROP TABLE t1, t2, logtbl;
|
|
DROP PROCEDURE just_log;
|
|
DROP PROCEDURE log_me;
|
|
DROP PROCEDURE log_me_inner;
|
|
DROP FUNCTION log_rows;
|
|
sync_slave_with_master;
|
|
|