mirror of
https://github.com/MariaDB/server.git
synced 2025-01-20 05:52:27 +01:00
043e09b543
If the log_bin_trust_function_creators option is not defined, creating a stored function requires either one of the modifiers DETERMINISTIC, NO SQL, or READS SQL DATA. Executing a stored function should also follows the same rules if in STATEMENT mode. However, this was not happening and a wrong error was being printed out: ER_BINLOG_ROW_RBR_TO_SBR. The patch makes the creation and execution compatible and prints out the correct error ER_BINLOG_UNSAFE_ROUTINE when a stored function without one of the modifiers above is executed in STATEMENT mode.
187 lines
2.5 KiB
Text
187 lines
2.5 KiB
Text
-- source include/have_log_bin.inc
|
|
|
|
# Bug#16456 RBR: rpl_sp.test expects query to fail, but passes in RBR
|
|
# BUG#41166 stored function requires "deterministic" if binlog_format is "statement"
|
|
|
|
# save status
|
|
|
|
let $oblf=`select @@SESSION.BINLOG_FORMAT`;
|
|
let $otfc=`select @@log_bin_trust_function_creators`;
|
|
|
|
set global log_bin_trust_function_creators=0;
|
|
|
|
|
|
|
|
# fail *on definition*
|
|
|
|
set binlog_format=STATEMENT;
|
|
|
|
delimiter |;
|
|
--error ER_BINLOG_UNSAFE_ROUTINE
|
|
create function fn16456()
|
|
returns int
|
|
begin
|
|
return unix_timestamp();
|
|
end|
|
|
delimiter ;|
|
|
|
|
|
|
|
|
# force in definition, so we can see whether we fail on call
|
|
|
|
set global log_bin_trust_function_creators=1;
|
|
|
|
delimiter |;
|
|
create function fn16456()
|
|
returns int
|
|
begin
|
|
return unix_timestamp();
|
|
end|
|
|
delimiter ;|
|
|
|
|
set global log_bin_trust_function_creators=0;
|
|
|
|
|
|
|
|
# allow funcall in RBR
|
|
|
|
set binlog_format=ROW;
|
|
|
|
--replace_column 1 timestamp
|
|
select fn16456();
|
|
|
|
|
|
|
|
# fail funcall in SBR
|
|
|
|
set binlog_format=STATEMENT;
|
|
|
|
--error ER_BINLOG_UNSAFE_ROUTINE
|
|
select fn16456();
|
|
|
|
|
|
|
|
# clean
|
|
|
|
drop function fn16456;
|
|
|
|
|
|
|
|
# success in definition with deterministic
|
|
|
|
set global log_bin_trust_function_creators=0;
|
|
|
|
delimiter |;
|
|
create function fn16456()
|
|
returns int deterministic
|
|
begin
|
|
return unix_timestamp();
|
|
end|
|
|
delimiter ;|
|
|
|
|
|
|
|
|
# allow funcall in RBR
|
|
|
|
set binlog_format=ROW;
|
|
|
|
--replace_column 1 timestamp
|
|
select fn16456();
|
|
|
|
|
|
|
|
# allow funcall in SBR
|
|
|
|
set binlog_format=STATEMENT;
|
|
|
|
--replace_column 1 timestamp
|
|
select fn16456();
|
|
|
|
|
|
|
|
# clean
|
|
|
|
drop function fn16456;
|
|
|
|
|
|
# success in definition with NO SQL
|
|
|
|
set global log_bin_trust_function_creators=0;
|
|
|
|
delimiter |;
|
|
create function fn16456()
|
|
returns int no sql
|
|
begin
|
|
return unix_timestamp();
|
|
end|
|
|
delimiter ;|
|
|
|
|
|
|
|
|
# allow funcall in RBR
|
|
|
|
set binlog_format=ROW;
|
|
|
|
--replace_column 1 timestamp
|
|
select fn16456();
|
|
|
|
|
|
|
|
# allow funcall in SBR
|
|
|
|
set binlog_format=STATEMENT;
|
|
|
|
--replace_column 1 timestamp
|
|
select fn16456();
|
|
|
|
|
|
# clean
|
|
|
|
drop function fn16456;
|
|
|
|
|
|
|
|
# success in definition with reads sql data
|
|
|
|
set global log_bin_trust_function_creators=0;
|
|
|
|
delimiter |;
|
|
create function fn16456()
|
|
returns int reads sql data
|
|
begin
|
|
return unix_timestamp();
|
|
end|
|
|
delimiter ;|
|
|
|
|
|
|
|
|
# allow funcall in RBR
|
|
|
|
set binlog_format=ROW;
|
|
|
|
--replace_column 1 timestamp
|
|
select fn16456();
|
|
|
|
|
|
|
|
# allow funcall in SBR
|
|
|
|
set binlog_format=STATEMENT;
|
|
|
|
--replace_column 1 timestamp
|
|
select fn16456();
|
|
|
|
|
|
|
|
# clean
|
|
|
|
drop function fn16456;
|
|
|
|
|
|
|
|
# restore status
|
|
|
|
--disable_query_log
|
|
eval set binlog_format=$oblf;
|
|
eval set global log_bin_trust_function_creators=$otfc;
|
|
--enable_query_log
|