mirror of
https://github.com/MariaDB/server.git
synced 2025-01-18 13:02:28 +01:00
c1e69a77a6
The problem was in a test case for Bug33507:
- when the number of active connections reaches the limit,
the server accepts only root connections. That's achieved by
accepting a connection, negotiating with the client and
checking user credentials. If it is not SUPER, the connection
is dropped.
- when the server accepts connection, it increases the counter;
- when the server drops connection, it decreases the counter;
- the race was in between of decreasing the counter and accepting
new connection:
- max_user_connections = 2;
- 2 oridinary user connections accepted;
- extra user connection is establishing;
- server checked user credentials, and sent 'Too many connections'
error;
- the client receives the error and establishes extra SUPER user
connection;
- the server however didn't decrease the counter (the extra
user connection still is "alive" in the server) -- so, the new
SUPER-user connection, will be dropped, because it exceeds
(max_user_connections + 1).
The fix is to implement "safe connect", which makes several attempts
to connect and use it in the test script.
mysql-test/r/connect.result:
Update test file.
mysql-test/t/connect.test:
Avoid races in connect.test.
mysql-test/include/connect2.inc:
Auxiliary routine to establish a connection reliably.
220 lines
5.7 KiB
Text
220 lines
5.7 KiB
Text
drop table if exists t1,t2;
|
|
show tables;
|
|
Tables_in_mysql
|
|
columns_priv
|
|
db
|
|
event
|
|
func
|
|
general_log
|
|
help_category
|
|
help_keyword
|
|
help_relation
|
|
help_topic
|
|
host
|
|
ndb_binlog_index
|
|
plugin
|
|
proc
|
|
procs_priv
|
|
servers
|
|
slow_log
|
|
tables_priv
|
|
time_zone
|
|
time_zone_leap_second
|
|
time_zone_name
|
|
time_zone_transition
|
|
time_zone_transition_type
|
|
user
|
|
show tables;
|
|
Tables_in_test
|
|
connect(localhost,root,z,test2,MASTER_PORT,MASTER_SOCKET);
|
|
ERROR 28000: Access denied for user 'root'@'localhost' (using password: YES)
|
|
connect(localhost,root,z,test,MASTER_PORT,MASTER_SOCKET);
|
|
ERROR 28000: Access denied for user 'root'@'localhost' (using password: YES)
|
|
grant ALL on *.* to test@localhost identified by "gambling";
|
|
grant ALL on *.* to test@127.0.0.1 identified by "gambling";
|
|
show tables;
|
|
Tables_in_mysql
|
|
columns_priv
|
|
db
|
|
event
|
|
func
|
|
general_log
|
|
help_category
|
|
help_keyword
|
|
help_relation
|
|
help_topic
|
|
host
|
|
ndb_binlog_index
|
|
plugin
|
|
proc
|
|
procs_priv
|
|
servers
|
|
slow_log
|
|
tables_priv
|
|
time_zone
|
|
time_zone_leap_second
|
|
time_zone_name
|
|
time_zone_transition
|
|
time_zone_transition_type
|
|
user
|
|
show tables;
|
|
Tables_in_test
|
|
connect(localhost,test,,test2,MASTER_PORT,MASTER_SOCKET);
|
|
ERROR 28000: Access denied for user 'test'@'localhost' (using password: NO)
|
|
connect(localhost,test,,"",MASTER_PORT,MASTER_SOCKET);
|
|
ERROR 28000: Access denied for user 'test'@'localhost' (using password: NO)
|
|
connect(localhost,test,zorro,test2,MASTER_PORT,MASTER_SOCKET);
|
|
ERROR 28000: Access denied for user 'test'@'localhost' (using password: YES)
|
|
connect(localhost,test,zorro,test,MASTER_PORT,MASTER_SOCKET);
|
|
ERROR 28000: Access denied for user 'test'@'localhost' (using password: YES)
|
|
update mysql.user set password=old_password("gambling2") where user=_binary"test";
|
|
flush privileges;
|
|
set password="";
|
|
set password='gambling3';
|
|
ERROR HY000: Password hash should be a 41-digit hexadecimal number
|
|
set password=old_password('gambling3');
|
|
show tables;
|
|
Tables_in_mysql
|
|
columns_priv
|
|
db
|
|
event
|
|
func
|
|
general_log
|
|
help_category
|
|
help_keyword
|
|
help_relation
|
|
help_topic
|
|
host
|
|
ndb_binlog_index
|
|
plugin
|
|
proc
|
|
procs_priv
|
|
servers
|
|
slow_log
|
|
tables_priv
|
|
time_zone
|
|
time_zone_leap_second
|
|
time_zone_name
|
|
time_zone_transition
|
|
time_zone_transition_type
|
|
user
|
|
show tables;
|
|
Tables_in_test
|
|
connect(localhost,test,,test2,MASTER_PORT,MASTER_SOCKET);
|
|
ERROR 28000: Access denied for user 'test'@'localhost' (using password: NO)
|
|
connect(localhost,test,,test,MASTER_PORT,MASTER_SOCKET);
|
|
ERROR 28000: Access denied for user 'test'@'localhost' (using password: NO)
|
|
connect(localhost,test,zorro,test2,MASTER_PORT,MASTER_SOCKET);
|
|
ERROR 28000: Access denied for user 'test'@'localhost' (using password: YES)
|
|
connect(localhost,test,zorro,test,MASTER_PORT,MASTER_SOCKET);
|
|
ERROR 28000: Access denied for user 'test'@'localhost' (using password: YES)
|
|
delete from mysql.user where user=_binary"test";
|
|
flush privileges;
|
|
create table t1 (id integer not null auto_increment primary key);
|
|
create temporary table t2(id integer not null auto_increment primary key);
|
|
set @id := 1;
|
|
delete from t1 where id like @id;
|
|
drop table t1;
|
|
# ------------------------------------------------------------------
|
|
# -- End of 4.1 tests
|
|
# ------------------------------------------------------------------
|
|
|
|
# -- Bug#33507: Event scheduler creates more threads than max_connections
|
|
# -- which results in user lockout.
|
|
|
|
GRANT USAGE ON *.* TO mysqltest_u1@localhost;
|
|
|
|
SET GLOBAL max_connections = 3;
|
|
SET GLOBAL event_scheduler = ON;
|
|
|
|
# -- Waiting for Event Scheduler to start...
|
|
|
|
# -- Disconnecting default connection...
|
|
|
|
# -- Check that we allow exactly three user connections, no matter how
|
|
# -- many threads are running.
|
|
|
|
# -- Connecting (1)...
|
|
# -- Establishing connection 'con_1' (user: mysqltest_u1)...
|
|
# -- Connection 'con_1' has been established.
|
|
|
|
# -- Connecting (2)...
|
|
# -- Establishing connection 'con_2' (user: mysqltest_u1)...
|
|
# -- Connection 'con_2' has been established.
|
|
|
|
# -- Connecting (3)...
|
|
# -- Establishing connection 'con_3' (user: mysqltest_u1)...
|
|
# -- Connection 'con_3' has been established.
|
|
|
|
# -- Connecting (4) [should fail]...
|
|
# -- Establishing connection 'con_4' (user: mysqltest_u1)...
|
|
# -- Error: can not establish connection 'con_4'.
|
|
|
|
# -- Check that we allow one extra SUPER-user connection.
|
|
|
|
# -- Connecting super (1)...
|
|
# -- Establishing connection 'con_super_1' (user: root)...
|
|
# -- Connection 'con_super_1' has been established.
|
|
|
|
# -- Connecting super (2) [should fail]...
|
|
# -- Establishing connection 'con_super_2' (user: root)...
|
|
# -- Error: can not establish connection 'con_super_2'.
|
|
|
|
# -- Ensure that we have Event Scheduler thread, 3 ordinary user
|
|
# -- connections and one extra super-user connection.
|
|
SELECT user FROM information_schema.processlist ORDER BY id;
|
|
user
|
|
event_scheduler
|
|
mysqltest_u1
|
|
mysqltest_u1
|
|
mysqltest_u1
|
|
root
|
|
|
|
# -- Resetting variables...
|
|
SET GLOBAL max_connections = 151;
|
|
|
|
# -- Stopping Event Scheduler...
|
|
SET GLOBAL event_scheduler = OFF;
|
|
|
|
# -- Waiting for Event Scheduler to stop...
|
|
|
|
# -- That's it. Closing connections...
|
|
|
|
# -- Restoring default connection...
|
|
|
|
# -- Waiting for connections to close...
|
|
|
|
DROP USER mysqltest_u1@localhost;
|
|
|
|
# -- End of Bug#33507.
|
|
|
|
# -- Bug#35074: max_used_connections is not correct.
|
|
|
|
FLUSH STATUS;
|
|
|
|
SHOW STATUS LIKE 'max_used_connections';
|
|
Variable_name Value
|
|
Max_used_connections 1
|
|
|
|
# -- Starting Event Scheduler...
|
|
SET GLOBAL event_scheduler = ON;
|
|
# -- Waiting for Event Scheduler to start...
|
|
|
|
# -- Opening a new connection to check max_used_connections...
|
|
|
|
# -- Check that max_used_connections hasn't changed.
|
|
SHOW STATUS LIKE 'max_used_connections';
|
|
Variable_name Value
|
|
Max_used_connections 2
|
|
|
|
# -- Closing new connection...
|
|
|
|
# -- Stopping Event Scheduler...
|
|
SET GLOBAL event_scheduler = OFF;
|
|
# -- Waiting for Event Scheduler to stop...
|
|
|
|
# -- End of Bug#35074.
|
|
|
|
# ------------------------------------------------------------------
|
|
# -- End of 5.1 tests
|
|
# ------------------------------------------------------------------
|