mirror of
https://github.com/MariaDB/server.git
synced 2025-01-20 22:12:30 +01:00
9fae9ef66f
- BUG#11986: Stored routines and triggers can fail if the code
has a non-ascii symbol
- BUG#16291: mysqldump corrupts string-constants with non-ascii-chars
- BUG#19443: INFORMATION_SCHEMA does not support charsets properly
- BUG#21249: Character set of SP-var can be ignored
- BUG#25212: Character set of string constant is ignored (stored routines)
- BUG#25221: Character set of string constant is ignored (triggers)
There were a few general problems that caused these bugs:
1. Character set information of the original (definition) query for views,
triggers, stored routines and events was lost.
2. mysqldump output query in client character set, which can be
inappropriate to encode definition-query.
3. INFORMATION_SCHEMA used strings with mixed encodings to display object
definition;
1. No query-definition-character set.
In order to compile query into execution code, some extra data (such as
environment variables or the database character set) is used. The problem
here was that this context was not preserved. So, on the next load it can
differ from the original one, thus the result will be different.
The context contains the following data:
- client character set;
- connection collation (character set and collation);
- collation of the owner database;
The fix is to store this context and use it each time we parse (compile)
and execute the object (stored routine, trigger, ...).
2. Wrong mysqldump-output.
The original query can contain several encodings (by means of character set
introducers). The problem here was that we tried to convert original query
to the mysqldump-client character set.
Moreover, we stored queries in different character sets for different
objects (views, for one, used UTF8, triggers used original character set).
The solution is
- to store definition queries in the original character set;
- to change SHOW CREATE statement to output definition query in the
binary character set (i.e. without any conversion);
- introduce SHOW CREATE TRIGGER statement;
- to dump special statements to switch the context to the original one
before dumping and restore it afterwards.
Note, in order to preserve the database collation at the creation time,
additional ALTER DATABASE might be used (to temporary switch the database
collation back to the original value). In this case, ALTER DATABASE
privilege will be required. This is a backward-incompatible change.
3. INFORMATION_SCHEMA showed non-UTF8 strings
The fix is to generate UTF8-query during the parsing, store it in the object
and show it in the INFORMATION_SCHEMA.
Basically, the idea is to create a copy of the original query convert it to
UTF8. Character set introducers are removed and all text literals are
converted to UTF8.
This UTF8 query is intended to provide user-readable output. It must not be
used to recreate the object. Specialized SHOW CREATE statements should be
used for this.
The reason for this limitation is the following: the original query can
contain symbols from several character sets (by means of character set
introducers).
Example:
- original query:
CREATE VIEW v1 AS SELECT _cp1251 'Hello' AS c1;
- UTF8 query (for INFORMATION_SCHEMA):
CREATE VIEW v1 AS SELECT 'Hello' AS c1;
133 lines
9.2 KiB
Text
133 lines
9.2 KiB
Text
drop table if exists t1Aa,t2Aa,v1Aa,v2Aa;
|
|
drop view if exists t1Aa,t2Aa,v1Aa,v2Aa;
|
|
drop database if exists MySQLTest;
|
|
create database MySQLTest;
|
|
use MySQLTest;
|
|
create table TaB (Field int);
|
|
create view ViE as select * from TAb;
|
|
show create table VIe;
|
|
View Create View character_set_client collation_connection
|
|
vie CREATE ALGORITHM=UNDEFINED DEFINER=`root`@`localhost` SQL SECURITY DEFINER VIEW `vie` AS select `tab`.`Field` AS `Field` from `tab` latin1 latin1_swedish_ci
|
|
drop database MySQLTest;
|
|
use test;
|
|
create table t1Aa (col1 int);
|
|
create table t2aA (col1 int);
|
|
create view v1Aa as select * from t1aA;
|
|
create view v2aA as select * from v1aA;
|
|
create view v3Aa as select v2Aa.col1 from v2aA,t2Aa where v2Aa.col1 = t2aA.col1;
|
|
update v2aA set col1 = (select max(col1) from v1Aa);
|
|
ERROR HY000: The definition of table 'v1Aa' prevents operation UPDATE on table 'v2aA'.
|
|
update v2Aa set col1 = (select max(col1) from t1Aa);
|
|
ERROR HY000: The definition of table 'v2Aa' prevents operation UPDATE on table 'v2Aa'.
|
|
update v2aA set col1 = (select max(col1) from v2Aa);
|
|
ERROR HY000: You can't specify target table 'v2aA' for update in FROM clause
|
|
update v2aA,t2Aa set v2Aa.col1 = (select max(col1) from v1aA) where v2aA.col1 = t2aA.col1;
|
|
ERROR HY000: The definition of table 'v1aA' prevents operation UPDATE on table 'v2aA'.
|
|
update t1aA,t2Aa set t1Aa.col1 = (select max(col1) from v1Aa) where t1aA.col1 = t2aA.col1;
|
|
ERROR HY000: The definition of table 'v1Aa' prevents operation UPDATE on table 't1aA'.
|
|
update v1aA,t2Aa set v1Aa.col1 = (select max(col1) from v1aA) where v1Aa.col1 = t2aA.col1;
|
|
ERROR HY000: You can't specify target table 'v1aA' for update in FROM clause
|
|
update t2Aa,v2Aa set v2aA.col1 = (select max(col1) from v1aA) where v2Aa.col1 = t2aA.col1;
|
|
ERROR HY000: The definition of table 'v1aA' prevents operation UPDATE on table 't2Aa'.
|
|
update t2Aa,t1Aa set t1aA.col1 = (select max(col1) from v1Aa) where t1Aa.col1 = t2aA.col1;
|
|
ERROR HY000: The definition of table 'v1Aa' prevents operation UPDATE on table 't2Aa'.
|
|
update t2Aa,v1aA set v1Aa.col1 = (select max(col1) from v1aA) where v1Aa.col1 = t2aA.col1;
|
|
ERROR HY000: The definition of table 'v1aA' prevents operation UPDATE on table 't2Aa'.
|
|
update v2aA,t2Aa set v2Aa.col1 = (select max(col1) from t1aA) where v2aA.col1 = t2aA.col1;
|
|
ERROR HY000: The definition of table 'v2aA' prevents operation UPDATE on table 'v2aA'.
|
|
update t1Aa,t2Aa set t1aA.col1 = (select max(col1) from t1Aa) where t1aA.col1 = t2aA.col1;
|
|
ERROR HY000: You can't specify target table 't1Aa' for update in FROM clause
|
|
update v1aA,t2Aa set v1Aa.col1 = (select max(col1) from t1Aa) where v1aA.col1 = t2aA.col1;
|
|
ERROR HY000: The definition of table 'v1aA' prevents operation UPDATE on table 'v1aA'.
|
|
update t2Aa,v2Aa set v2aA.col1 = (select max(col1) from t1aA) where v2Aa.col1 = t2aA.col1;
|
|
ERROR HY000: You can't specify target table 't2Aa' for update in FROM clause
|
|
update t2Aa,t1Aa set t1aA.col1 = (select max(col1) from t1Aa) where t1aA.col1 = t2aA.col1;
|
|
ERROR HY000: You can't specify target table 't2Aa' for update in FROM clause
|
|
update t2Aa,v1Aa set v1aA.col1 = (select max(col1) from t1Aa) where v1Aa.col1 = t2aA.col1;
|
|
ERROR HY000: You can't specify target table 't2Aa' for update in FROM clause
|
|
update v2aA,t2Aa set v2Aa.col1 = (select max(col1) from v2aA) where v2Aa.col1 = t2aA.col1;
|
|
ERROR HY000: You can't specify target table 'v2aA' for update in FROM clause
|
|
update t1aA,t2Aa set t1Aa.col1 = (select max(col1) from v2aA) where t1aA.col1 = t2aA.col1;
|
|
ERROR HY000: The definition of table 'v2aA' prevents operation UPDATE on table 't1aA'.
|
|
update v1aA,t2Aa set v1Aa.col1 = (select max(col1) from v2Aa) where v1aA.col1 = t2aA.col1;
|
|
ERROR HY000: The definition of table 'v2Aa' prevents operation UPDATE on table 'v1aA'.
|
|
update t2Aa,v2aA set v2Aa.col1 = (select max(col1) from v2aA) where v2Aa.col1 = t2aA.col1;
|
|
ERROR HY000: The definition of table 'v2aA' prevents operation UPDATE on table 't2Aa'.
|
|
update t2Aa,t1Aa set t1aA.col1 = (select max(col1) from v2aA) where t1Aa.col1 = t2aA.col1;
|
|
ERROR HY000: The definition of table 'v2aA' prevents operation UPDATE on table 't2Aa'.
|
|
update t2Aa,v1Aa set v1aA.col1 = (select max(col1) from v2Aa) where v1Aa.col1 = t2aA.col1;
|
|
ERROR HY000: The definition of table 'v2Aa' prevents operation UPDATE on table 't2Aa'.
|
|
update v3aA set v3Aa.col1 = (select max(col1) from v1aA);
|
|
ERROR HY000: The definition of table 'v1aA' prevents operation UPDATE on table 'v3aA'.
|
|
update v3aA set v3Aa.col1 = (select max(col1) from t1aA);
|
|
ERROR HY000: The definition of table 'v3aA' prevents operation UPDATE on table 'v3aA'.
|
|
update v3aA set v3Aa.col1 = (select max(col1) from v2aA);
|
|
ERROR HY000: The definition of table 'v2aA' prevents operation UPDATE on table 'v3aA'.
|
|
update v3aA set v3Aa.col1 = (select max(col1) from v3aA);
|
|
ERROR HY000: You can't specify target table 'v3aA' for update in FROM clause
|
|
delete from v2Aa where col1 = (select max(col1) from v1Aa);
|
|
ERROR HY000: The definition of table 'v1Aa' prevents operation DELETE on table 'v2Aa'.
|
|
delete from v2aA where col1 = (select max(col1) from t1Aa);
|
|
ERROR HY000: The definition of table 'v2aA' prevents operation DELETE on table 'v2aA'.
|
|
delete from v2Aa where col1 = (select max(col1) from v2aA);
|
|
ERROR HY000: You can't specify target table 'v2Aa' for update in FROM clause
|
|
delete v2Aa from v2aA,t2Aa where (select max(col1) from v1aA) > 0 and v2Aa.col1 = t2aA.col1;
|
|
ERROR HY000: The definition of table 'v1aA' prevents operation DELETE on table 'v2aA'.
|
|
delete t1aA from t1Aa,t2Aa where (select max(col1) from v1Aa) > 0 and t1aA.col1 = t2aA.col1;
|
|
ERROR HY000: The definition of table 'v1Aa' prevents operation DELETE on table 't1Aa'.
|
|
delete v1aA from v1Aa,t2Aa where (select max(col1) from v1aA) > 0 and v1Aa.col1 = t2aA.col1;
|
|
ERROR HY000: You can't specify target table 'v1Aa' for update in FROM clause
|
|
delete v2aA from v2Aa,t2Aa where (select max(col1) from t1Aa) > 0 and v2aA.col1 = t2aA.col1;
|
|
ERROR HY000: The definition of table 'v2Aa' prevents operation DELETE on table 'v2Aa'.
|
|
delete t1aA from t1Aa,t2Aa where (select max(col1) from t1aA) > 0 and t1Aa.col1 = t2aA.col1;
|
|
ERROR HY000: You can't specify target table 't1Aa' for update in FROM clause
|
|
delete v1aA from v1Aa,t2Aa where (select max(col1) from t1aA) > 0 and v1aA.col1 = t2aA.col1;
|
|
ERROR HY000: The definition of table 'v1Aa' prevents operation DELETE on table 'v1Aa'.
|
|
delete v2Aa from v2aA,t2Aa where (select max(col1) from v2Aa) > 0 and v2aA.col1 = t2aA.col1;
|
|
ERROR HY000: You can't specify target table 'v2aA' for update in FROM clause
|
|
delete t1Aa from t1aA,t2Aa where (select max(col1) from v2Aa) > 0 and t1Aa.col1 = t2aA.col1;
|
|
ERROR HY000: The definition of table 'v2Aa' prevents operation DELETE on table 't1aA'.
|
|
delete v1Aa from v1aA,t2Aa where (select max(col1) from v2aA) > 0 and v1Aa.col1 = t2aA.col1;
|
|
ERROR HY000: The definition of table 'v2aA' prevents operation DELETE on table 'v1aA'.
|
|
insert into v2Aa values ((select max(col1) from v1aA));
|
|
ERROR HY000: The definition of table 'v1aA' prevents operation INSERT on table 'v2Aa'.
|
|
insert into t1aA values ((select max(col1) from v1Aa));
|
|
ERROR HY000: The definition of table 'v1Aa' prevents operation INSERT on table 't1aA'.
|
|
insert into v2aA values ((select max(col1) from v1aA));
|
|
ERROR HY000: The definition of table 'v1aA' prevents operation INSERT on table 'v2aA'.
|
|
insert into v2Aa values ((select max(col1) from t1Aa));
|
|
ERROR HY000: The definition of table 'v2Aa' prevents operation INSERT on table 'v2Aa'.
|
|
insert into t1aA values ((select max(col1) from t1Aa));
|
|
ERROR HY000: You can't specify target table 't1aA' for update in FROM clause
|
|
insert into v2aA values ((select max(col1) from t1aA));
|
|
ERROR HY000: The definition of table 'v2aA' prevents operation INSERT on table 'v2aA'.
|
|
insert into v2Aa values ((select max(col1) from v2aA));
|
|
ERROR HY000: You can't specify target table 'v2Aa' for update in FROM clause
|
|
insert into t1Aa values ((select max(col1) from v2Aa));
|
|
ERROR HY000: The definition of table 'v2Aa' prevents operation INSERT on table 't1Aa'.
|
|
insert into v2aA values ((select max(col1) from v2Aa));
|
|
ERROR HY000: You can't specify target table 'v2aA' for update in FROM clause
|
|
insert into v3Aa (col1) values ((select max(col1) from v1Aa));
|
|
ERROR HY000: The definition of table 'v1Aa' prevents operation INSERT on table 'v3Aa'.
|
|
insert into v3aA (col1) values ((select max(col1) from t1aA));
|
|
ERROR HY000: The definition of table 'v3aA' prevents operation INSERT on table 'v3aA'.
|
|
insert into v3Aa (col1) values ((select max(col1) from v2aA));
|
|
ERROR HY000: The definition of table 'v2aA' prevents operation INSERT on table 'v3Aa'.
|
|
drop view v3aA,v2Aa,v1aA;
|
|
drop table t1Aa,t2Aa;
|
|
create table t1Aa (col1 int);
|
|
create view v1Aa as select col1 from t1Aa as AaA;
|
|
show create view v1AA;
|
|
View Create View character_set_client collation_connection
|
|
v1aa CREATE ALGORITHM=UNDEFINED DEFINER=`root`@`localhost` SQL SECURITY DEFINER VIEW `v1aa` AS select `aaa`.`col1` AS `col1` from `t1aa` `AaA` latin1 latin1_swedish_ci
|
|
drop view v1AA;
|
|
select Aaa.col1 from t1Aa as AaA;
|
|
col1
|
|
create view v1Aa as select Aaa.col1 from t1Aa as AaA;
|
|
drop view v1AA;
|
|
create view v1Aa as select AaA.col1 from t1Aa as AaA;
|
|
show create view v1AA;
|
|
View Create View character_set_client collation_connection
|
|
v1aa CREATE ALGORITHM=UNDEFINED DEFINER=`root`@`localhost` SQL SECURITY DEFINER VIEW `v1aa` AS select `aaa`.`col1` AS `col1` from `t1aa` `AaA` latin1 latin1_swedish_ci
|
|
drop view v1AA;
|
|
drop table t1Aa;
|