mirror of
https://github.com/MariaDB/server.git
synced 2025-01-29 02:05:57 +01:00
2b6d241ee4
The crash happened with an indexed virtual column whose value is evaluated using a function that has a different meaning in sql_mode='' vs sql_mode=ORACLE: - DECODE() - LTRIM() - RTRIM() - LPAD() - RPAD() - REPLACE() - SUBSTR() For example: CREATE TABLE t1 ( b VARCHAR(1), g CHAR(1) GENERATED ALWAYS AS (SUBSTR(b,0,0)) VIRTUAL, KEY g(g) ); So far we had replacement XXX_ORACLE() functions for all mentioned function, e.g. SUBSTR_ORACLE() for SUBSTR(). So it was possible to correctly re-parse SUBSTR_ORACLE() even in sql_mode=''. But it was not possible to re-parse the MariaDB version of SUBSTR() after switching to sql_mode=ORACLE. It was erroneously mis-interpreted as SUBSTR_ORACLE(). As a result, this combination worked fine: SET sql_mode=ORACLE; CREATE TABLE t1 ... g CHAR(1) GENERATED ALWAYS AS (SUBSTR(b,0,0)) VIRTUAL, ...; INSERT ... FLUSH TABLES; SET sql_mode=''; INSERT ... But the other way around it crashed: SET sql_mode=''; CREATE TABLE t1 ... g CHAR(1) GENERATED ALWAYS AS (SUBSTR(b,0,0)) VIRTUAL, ...; INSERT ... FLUSH TABLES; SET sql_mode=ORACLE; INSERT ... At CREATE time, SUBSTR was instantiated as Item_func_substr and printed in the FRM file as substr(). At re-open time with sql_mode=ORACLE, "substr()" was erroneously instantiated as Item_func_substr_oracle. Fix: The fix proposes a symmetric solution. It provides a way to re-parse reliably all sql_mode dependent functions to their original CREATE TABLE time meaning, no matter what the open-time sql_mode is. We take advantage of the same idea we previously used to resolve sql_mode dependent data types. Now all sql_mode dependent functions are printed by SHOW using a schema qualifier when the current sql_mode differs from the function sql_mode: SET sql_mode=''; CREATE TABLE t1 ... SUBSTR(a,b,c) ..; SET sql_mode=ORACLE; SHOW CREATE TABLE t1; -> mariadb_schema.substr(a,b,c) SET sql_mode=ORACLE; CREATE TABLE t2 ... SUBSTR(a,b,c) ..; SET sql_mode=''; SHOW CREATE TABLE t1; -> oracle_schema.substr(a,b,c) Old replacement names like substr_oracle() are still understood for backward compatibility and used in FRM files (for downgrade compatibility), but they are not printed by SHOW any more. |
||
|---|---|---|
| .. | ||
| atomic | ||
| mysql | ||
| aria_backup.h | ||
| big_endian.h | ||
| byte_order_generic.h | ||
| byte_order_generic_x86.h | ||
| byte_order_generic_x86_64.h | ||
| CMakeLists.txt | ||
| decimal.h | ||
| dur_prop.h | ||
| errmsg.h | ||
| ft_global.h | ||
| handler_ername.h | ||
| handler_state.h | ||
| hash.h | ||
| heap.h | ||
| ilist.h | ||
| json_lib.h | ||
| keycache.h | ||
| lf.h | ||
| little_endian.h | ||
| m_ctype.h | ||
| m_string.h | ||
| ma_dyncol.h | ||
| maria.h | ||
| mariadb_capi_rename.h | ||
| my_alarm.h | ||
| my_alloc.h | ||
| my_alloca.h | ||
| my_atomic.h | ||
| my_atomic_wrapper.h | ||
| my_attribute.h | ||
| my_base.h | ||
| my_bit.h | ||
| my_bitmap.h | ||
| my_byteorder.h | ||
| my_check_opt.h | ||
| my_compare.h | ||
| my_compiler.h | ||
| my_context.h | ||
| my_counter.h | ||
| my_cpu.h | ||
| my_crypt.h | ||
| my_dbug.h | ||
| my_decimal_limits.h | ||
| my_default.h | ||
| my_dir.h | ||
| my_getopt.h | ||
| my_global.h | ||
| my_handler_errors.h | ||
| my_libwrap.h | ||
| my_list.h | ||
| my_md5.h | ||
| my_minidump.h | ||
| my_net.h | ||
| my_nosys.h | ||
| my_pthread.h | ||
| my_rdtsc.h | ||
| my_rnd.h | ||
| my_service_manager.h | ||
| my_stacktrace.h | ||
| my_sys.h | ||
| my_time.h | ||
| my_tree.h | ||
| my_uctype.h | ||
| my_user.h | ||
| my_valgrind.h | ||
| my_xml.h | ||
| myisam.h | ||
| myisamchk.h | ||
| myisammrg.h | ||
| myisampack.h | ||
| mysql.h | ||
| mysql_async.h | ||
| mysql_com.h | ||
| mysql_com_server.h | ||
| mysql_embed.h | ||
| mysql_time.h | ||
| mysql_version.h.in | ||
| mysqld_default_groups.h | ||
| mysys_err.h | ||
| no_valgrind_without_big.inc | ||
| pack.h | ||
| password.h | ||
| probes_mysql.d.base | ||
| probes_mysql.h | ||
| probes_mysql_nodtrace.h.in | ||
| queues.h | ||
| rijndael.h | ||
| scope.h | ||
| service_versions.h | ||
| source_revision.h.in | ||
| span.h | ||
| sql_common.h | ||
| ssl_compat.h | ||
| sslopt-case.h | ||
| sslopt-longopts.h | ||
| sslopt-vars.h | ||
| t_ctype.h | ||
| thr_alarm.h | ||
| thr_lock.h | ||
| thr_timer.h | ||
| thread_pool_priv.h | ||
| typelib.h | ||
| violite.h | ||
| waiting_threads.h | ||
| welcome_copyright_notice.h | ||
| wqueue.h | ||
| wsrep.h | ||