mirror of
https://github.com/MariaDB/server.git
synced 2025-01-29 18:20:07 +01:00
2226b1084c
Brief description: After insert some rows to MEMORY table with HASH key some
rows can't be deleted in one step.
Problem Analysis/solution: info->current_ptr will have the information about the
current hash pointer from where we can traverse to the list to get all the
remaining tuples.
In hp_delete_key we are updating info->current_ptr with the last_pos based on
the flag parameter(which is the keydef and last index are same). As part of the
fix we are making it to zero only when the code flow reaches to the end of the
function hp_delete_key() it means that the next record which has to get deleted
will be at the starting of the list so, that in the next call to
read record(heap_rnext()) will take line number 100 path instead of 102 path,
please see the below code in file hp_rnext.c, function heap_rnext().
99 else if (!info->current_ptr) /* Deleted or first call */
100 pos= hp_search(info, keyinfo, info->lastkey, 0);
101 else
102 pos= hp_search(info, keyinfo, info->lastkey, 1);
with that change the hp_search() will update the info->current_ptr with the
record which needs to be deleted.
storage/heap/hp_delete.c:
In heap_delete_key() function we are making info->current_ptr to 0 if
flag is enabled.
212 lines
6 KiB
C
212 lines
6 KiB
C
/* Copyright (C) 2000-2002, 2004-2007 MySQL AB
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */
|
|
|
|
/* remove current record in heap-database */
|
|
|
|
#include "heapdef.h"
|
|
|
|
int heap_delete(HP_INFO *info, const uchar *record)
|
|
{
|
|
uchar *pos;
|
|
HP_SHARE *share=info->s;
|
|
HP_KEYDEF *keydef, *end, *p_lastinx;
|
|
DBUG_ENTER("heap_delete");
|
|
DBUG_PRINT("enter",("info: 0x%lx record: 0x%lx", (long) info, (long) record));
|
|
|
|
test_active(info);
|
|
|
|
if (info->opt_flag & READ_CHECK_USED && hp_rectest(info,record))
|
|
DBUG_RETURN(my_errno); /* Record changed */
|
|
share->changed=1;
|
|
|
|
if ( --(share->records) < share->blength >> 1) share->blength>>=1;
|
|
pos=info->current_ptr;
|
|
|
|
p_lastinx = share->keydef + info->lastinx;
|
|
for (keydef = share->keydef, end = keydef + share->keys; keydef < end;
|
|
keydef++)
|
|
{
|
|
if ((*keydef->delete_key)(info, keydef, record, pos, keydef == p_lastinx))
|
|
goto err;
|
|
}
|
|
|
|
info->update=HA_STATE_DELETED;
|
|
*((uchar**) pos)=share->del_link;
|
|
share->del_link=pos;
|
|
pos[share->reclength]=0; /* Record deleted */
|
|
share->deleted++;
|
|
info->current_hash_ptr=0;
|
|
#if !defined(DBUG_OFF) && defined(EXTRA_HEAP_DEBUG)
|
|
DBUG_EXECUTE("check_heap",heap_check_heap(info, 0););
|
|
#endif
|
|
|
|
DBUG_RETURN(0);
|
|
err:
|
|
if (++(share->records) == share->blength)
|
|
share->blength+= share->blength;
|
|
DBUG_RETURN(my_errno);
|
|
}
|
|
|
|
|
|
/*
|
|
Remove one key from rb-tree
|
|
*/
|
|
|
|
int hp_rb_delete_key(HP_INFO *info, register HP_KEYDEF *keyinfo,
|
|
const uchar *record, uchar *recpos, int flag)
|
|
{
|
|
heap_rb_param custom_arg;
|
|
uint old_allocated;
|
|
int res;
|
|
|
|
if (flag)
|
|
info->last_pos= NULL; /* For heap_rnext/heap_rprev */
|
|
|
|
custom_arg.keyseg= keyinfo->seg;
|
|
custom_arg.key_length= hp_rb_make_key(keyinfo, info->recbuf, record, recpos);
|
|
custom_arg.search_flag= SEARCH_SAME;
|
|
old_allocated= keyinfo->rb_tree.allocated;
|
|
res= tree_delete(&keyinfo->rb_tree, info->recbuf, custom_arg.key_length,
|
|
&custom_arg);
|
|
info->s->index_length-= (old_allocated - keyinfo->rb_tree.allocated);
|
|
return res;
|
|
}
|
|
|
|
|
|
/*
|
|
Remove one key from hash-table
|
|
|
|
SYNPOSIS
|
|
hp_delete_key()
|
|
info Hash handler
|
|
keyinfo key definition of key that we want to delete
|
|
record row data to be deleted
|
|
recpos Pointer to heap record in memory
|
|
flag Is set if we want's to correct info->current_ptr
|
|
|
|
RETURN
|
|
0 Ok
|
|
other Error code
|
|
*/
|
|
|
|
int hp_delete_key(HP_INFO *info, register HP_KEYDEF *keyinfo,
|
|
const uchar *record, uchar *recpos, int flag)
|
|
{
|
|
ulong blength, pos2, pos_hashnr, lastpos_hashnr, key_pos;
|
|
HASH_INFO *lastpos,*gpos,*pos,*pos3,*empty,*last_ptr;
|
|
HP_SHARE *share=info->s;
|
|
DBUG_ENTER("hp_delete_key");
|
|
|
|
blength=share->blength;
|
|
if (share->records+1 == blength)
|
|
blength+= blength;
|
|
lastpos=hp_find_hash(&keyinfo->block,share->records);
|
|
last_ptr=0;
|
|
|
|
/* Search after record with key */
|
|
key_pos= hp_mask(hp_rec_hashnr(keyinfo, record), blength, share->records + 1);
|
|
pos= hp_find_hash(&keyinfo->block, key_pos);
|
|
|
|
gpos = pos3 = 0;
|
|
|
|
while (pos->ptr_to_rec != recpos)
|
|
{
|
|
if (flag && !hp_rec_key_cmp(keyinfo, record, pos->ptr_to_rec, 0))
|
|
last_ptr=pos; /* Previous same key */
|
|
gpos=pos;
|
|
if (!(pos=pos->next_key))
|
|
{
|
|
DBUG_RETURN(my_errno=HA_ERR_CRASHED); /* This shouldn't happend */
|
|
}
|
|
}
|
|
|
|
/* Remove link to record */
|
|
|
|
if (flag)
|
|
{
|
|
/* Save for heap_rnext/heap_rprev */
|
|
info->current_hash_ptr=last_ptr;
|
|
info->current_ptr = last_ptr ? last_ptr->ptr_to_rec : 0;
|
|
DBUG_PRINT("info",("Corrected current_ptr to point at: 0x%lx",
|
|
(long) info->current_ptr));
|
|
}
|
|
empty=pos;
|
|
if (gpos)
|
|
gpos->next_key=pos->next_key; /* unlink current ptr */
|
|
else if (pos->next_key)
|
|
{
|
|
empty=pos->next_key;
|
|
pos->ptr_to_rec=empty->ptr_to_rec;
|
|
pos->next_key=empty->next_key;
|
|
}
|
|
else
|
|
keyinfo->hash_buckets--;
|
|
|
|
if (empty == lastpos) /* deleted last hash key */
|
|
DBUG_RETURN (0);
|
|
|
|
/* Move the last key (lastpos) */
|
|
lastpos_hashnr = hp_rec_hashnr(keyinfo, lastpos->ptr_to_rec);
|
|
/* pos is where lastpos should be */
|
|
pos=hp_find_hash(&keyinfo->block, hp_mask(lastpos_hashnr, share->blength,
|
|
share->records));
|
|
if (pos == empty) /* Move to empty position. */
|
|
{
|
|
empty[0]=lastpos[0];
|
|
DBUG_RETURN(0);
|
|
}
|
|
pos_hashnr = hp_rec_hashnr(keyinfo, pos->ptr_to_rec);
|
|
/* pos3 is where the pos should be */
|
|
pos3= hp_find_hash(&keyinfo->block,
|
|
hp_mask(pos_hashnr, share->blength, share->records));
|
|
if (pos != pos3)
|
|
{ /* pos is on wrong posit */
|
|
empty[0]=pos[0]; /* Save it here */
|
|
pos[0]=lastpos[0]; /* This shold be here */
|
|
hp_movelink(pos, pos3, empty); /* Fix link to pos */
|
|
DBUG_RETURN(0);
|
|
}
|
|
pos2= hp_mask(lastpos_hashnr, blength, share->records + 1);
|
|
if (pos2 == hp_mask(pos_hashnr, blength, share->records + 1))
|
|
{ /* Identical key-positions */
|
|
if (pos2 != share->records)
|
|
{
|
|
empty[0]=lastpos[0];
|
|
hp_movelink(lastpos, pos, empty);
|
|
DBUG_RETURN(0);
|
|
}
|
|
pos3= pos; /* Link pos->next after lastpos */
|
|
/*
|
|
One of elements from the bucket we're scanning is moved to the
|
|
beginning of the list. Reset search since this element may not have
|
|
been processed yet.
|
|
*/
|
|
if (flag && pos2 == key_pos)
|
|
{
|
|
info->current_ptr= 0;
|
|
info->current_hash_ptr= 0;
|
|
}
|
|
}
|
|
else
|
|
{
|
|
pos3= 0; /* Different positions merge */
|
|
keyinfo->hash_buckets--;
|
|
}
|
|
|
|
empty[0]=lastpos[0];
|
|
hp_movelink(pos3, empty, pos->next_key);
|
|
pos->next_key=empty;
|
|
DBUG_RETURN(0);
|
|
}
|