mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 20:12:31 +01:00
08c852026d
This patch is the result of running run-clang-tidy -fix -header-filter=.* -checks='-*,modernize-use-equals-default' . Code style changes have been done on top. The result of this change leads to the following improvements: 1. Binary size reduction. * For a -DBUILD_CONFIG=mysql_release build, the binary size is reduced by ~400kb. * A raw -DCMAKE_BUILD_TYPE=Release reduces the binary size by ~1.4kb. 2. Compiler can better understand the intent of the code, thus it leads to more optimization possibilities. Additionally it enabled detecting unused variables that had an empty default constructor but not marked so explicitly. Particular change required following this patch in sql/opt_range.cc result_keys, an unused template class Bitmap now correctly issues unused variable warnings. Setting Bitmap template class constructor to default allows the compiler to identify that there are no side-effects when instantiating the class. Previously the compiler could not issue the warning as it assumed Bitmap class (being a template) would not be performing a NO-OP for its default constructor. This prevented the "unused variable warning".
121 lines
3.3 KiB
C++
121 lines
3.3 KiB
C++
/* Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License, version 2.0,
|
|
as published by the Free Software Foundation.
|
|
|
|
This program is also distributed with certain software (including
|
|
but not limited to OpenSSL) that is licensed under separate terms,
|
|
as designated in a particular file or component or in included license
|
|
documentation. The authors of MySQL hereby grant you an additional
|
|
permission to link the program and your derivative works with the
|
|
separately licensed software that they have included with MySQL.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License, version 2.0, for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software Foundation,
|
|
51 Franklin Street, Fifth Floor, Boston, MA 02110-1335 USA */
|
|
|
|
#ifndef TABLE_ALL_INSTR_H
|
|
#define TABLE_ALL_INSTR_H
|
|
|
|
/**
|
|
@file storage/perfschema/table_all_instr.h
|
|
Abstract tables for all instruments (declarations).
|
|
*/
|
|
|
|
#include "pfs_instr_class.h"
|
|
#include "pfs_instr.h"
|
|
#include "pfs_engine_table.h"
|
|
#include "table_helper.h"
|
|
|
|
/**
|
|
@addtogroup Performance_schema_tables
|
|
@{
|
|
*/
|
|
|
|
/** Position of a cursor on table_all_instr. */
|
|
struct pos_all_instr : public PFS_double_index,
|
|
public PFS_instrument_view_constants
|
|
{
|
|
pos_all_instr()
|
|
: PFS_double_index(FIRST_VIEW, 0)
|
|
{}
|
|
|
|
inline void reset(void)
|
|
{
|
|
m_index_1= FIRST_VIEW;
|
|
m_index_2= 0;
|
|
}
|
|
|
|
inline bool has_more_view(void)
|
|
{ return (m_index_1 <= LAST_VIEW); }
|
|
|
|
inline void next_view(void)
|
|
{
|
|
m_index_1++;
|
|
m_index_2= 0;
|
|
}
|
|
};
|
|
|
|
/**
|
|
Abstract table, a union of all instrumentations instances.
|
|
This table is a union of:
|
|
- a view on all mutex instances,
|
|
- a view on all rwlock instances,
|
|
- a view on all cond instances,
|
|
- a view on all file instances,
|
|
- a view on all socket instances
|
|
*/
|
|
class table_all_instr : public PFS_engine_table
|
|
{
|
|
public:
|
|
virtual int rnd_next();
|
|
virtual int rnd_pos(const void *pos);
|
|
virtual void reset_position(void);
|
|
|
|
protected:
|
|
table_all_instr(const PFS_engine_table_share *share);
|
|
|
|
public:
|
|
~table_all_instr() = default;
|
|
|
|
protected:
|
|
/**
|
|
Build a row in the mutex instance view.
|
|
@param pfs the mutex instance
|
|
*/
|
|
virtual void make_mutex_row(PFS_mutex *pfs)= 0;
|
|
/**
|
|
Build a row in the rwlock instance view.
|
|
@param pfs the rwlock instance
|
|
*/
|
|
virtual void make_rwlock_row(PFS_rwlock *pfs)= 0;
|
|
/**
|
|
Build a row in the condition instance view.
|
|
@param pfs the condition instance
|
|
*/
|
|
virtual void make_cond_row(PFS_cond *pfs)= 0;
|
|
/**
|
|
Build a row in the file instance view.
|
|
@param pfs the file instance
|
|
*/
|
|
virtual void make_file_row(PFS_file *pfs)= 0;
|
|
/**
|
|
Build a row in the socket instance view.
|
|
@param pfs the socket instance
|
|
*/
|
|
virtual void make_socket_row(PFS_socket *pfs)= 0;
|
|
|
|
/** Current position. */
|
|
pos_all_instr m_pos;
|
|
/** Next position. */
|
|
pos_all_instr m_next_pos;
|
|
};
|
|
|
|
/** @} */
|
|
#endif
|