mirror of
https://github.com/MariaDB/server.git
synced 2025-01-26 00:34:18 +01:00
ab1e6fefd8
MariaDB 10.0/MySQL 5.6 using innodb-page-size!=16K The storage format of FSP_SPACE_FLAGS was accidentally broken already in MariaDB 10.1.0. This fix is bringing the format in line with other MySQL and MariaDB release series. Please refer to the comments that were added to fsp0fsp.h for details. This is an INCOMPATIBLE CHANGE that affects users of page_compression and non-default innodb_page_size. Upgrading to this release will correct the flags in the data files. If you want to downgrade to earlier MariaDB 10.1.x, please refer to the test innodb.101_compatibility how to reset the FSP_SPACE_FLAGS in the files. NOTE: MariaDB 10.1.0 to 10.1.20 can misinterpret uncompressed data files with innodb_page_size=4k or 64k as compressed innodb_page_size=16k files, and then probably fail when trying to access the pages. See the comments in the function fsp_flags_convert_from_101() for detailed analysis. Move PAGE_COMPRESSION to FSP_SPACE_FLAGS bit position 16. In this way, compressed innodb_page_size=16k tablespaces will not be mistaken for uncompressed ones by MariaDB 10.1.0 to 10.1.20. Derive PAGE_COMPRESSION_LEVEL, ATOMIC_WRITES and DATA_DIR from the dict_table_t::flags when the table is available, in fil_space_for_table_exists_in_mem() or fil_open_single_table_tablespace(). During crash recovery, fil_load_single_table_tablespace() will use innodb_compression_level for the PAGE_COMPRESSION_LEVEL. FSP_FLAGS_MEM_MASK: A bitmap of the memory-only fil_space_t::flags that are not to be written to FSP_SPACE_FLAGS. Currently, these will include PAGE_COMPRESSION_LEVEL, ATOMIC_WRITES and DATA_DIR. Introduce the macro FSP_FLAGS_PAGE_SSIZE(). We only support one innodb_page_size for the whole instance. When creating a dummy tablespace for the redo log, use fil_space_t::flags=0. The flags are never written to the redo log files. Remove many FSP_FLAGS_SET_ macros. dict_tf_verify_flags(): Remove. This is basically only duplicating the logic of dict_tf_to_fsp_flags(), used in a debug assertion. fil_space_t::mark: Remove. This flag was not used for anything. fil_space_for_table_exists_in_mem(): Remove the unnecessary parameter mark_space, and add a parameter for table flags. Check that fil_space_t::flags match the table flags, and adjust the (memory-only) flags based on the table flags. fil_node_open_file(): Remove some redundant or unreachable conditions, do not use stderr for output, and avoid unnecessary server aborts. fil_user_tablespace_restore_page(): Convert the flags, so that the correct page_size will be used when restoring a page from the doublewrite buffer. fil_space_get_page_compressed(), fsp_flags_is_page_compressed(): Remove. It suffices to have fil_space_is_page_compressed(). FSP_FLAGS_WIDTH_DATA_DIR, FSP_FLAGS_WIDTH_PAGE_COMPRESSION_LEVEL, FSP_FLAGS_WIDTH_ATOMIC_WRITES: Remove, because these flags do not exist in the FSP_SPACE_FLAGS but only in memory. fsp_flags_try_adjust(): New function, to adjust the FSP_SPACE_FLAGS in page 0. Called by fil_open_single_table_tablespace(), fil_space_for_table_exists_in_mem(), innobase_start_or_create_for_mysql() except if --innodb-read-only is active. fsp_flags_is_valid(ulint): Reimplement from the scratch, with accurate comments. Do not display any details of detected inconsistencies, because the output could be confusing when dealing with MariaDB 10.1.x data files. fsp_flags_convert_from_101(ulint): Convert flags from buggy MariaDB 10.1.x format, or return ULINT_UNDEFINED if the flags cannot be in MariaDB 10.1.x format. fsp_flags_match(): Check the flags when probing files. Implemented based on fsp_flags_is_valid() and fsp_flags_convert_from_101(). dict_check_tablespaces_and_store_max_id(): Do not access the page after committing the mini-transaction. IMPORT TABLESPACE fixes: AbstractCallback::init(): Convert the flags. FetchIndexRootPages::operator(): Check that the tablespace flags match the table flags. Do not attempt to convert tablespace flags to table flags, because the conversion would necessarily be lossy. PageConverter::update_header(): Write back the correct flags. This takes care of the flags in IMPORT TABLESPACE.
243 lines
7.7 KiB
Text
243 lines
7.7 KiB
Text
#
|
|
# Bug #17335427 INNODB CAN NOT USE THE DOUBLEWRITE BUFFER PROPERLY
|
|
# Bug #18144349 INNODB CANNOT USE THE DOUBLEWRITE BUFFER FOR THE FIRST
|
|
# PAGE OF SYSTEM TABLESPACE
|
|
#
|
|
SET GLOBAL innodb_fast_shutdown = 0;
|
|
show variables like 'innodb_doublewrite';
|
|
Variable_name Value
|
|
innodb_doublewrite ON
|
|
show variables like 'innodb_fil_make_page_dirty_debug';
|
|
Variable_name Value
|
|
innodb_fil_make_page_dirty_debug 0
|
|
show variables like 'innodb_saved_page_number_debug';
|
|
Variable_name Value
|
|
innodb_saved_page_number_debug 0
|
|
create table t1 (f1 int primary key, f2 blob) engine=innodb;
|
|
start transaction;
|
|
insert into t1 values(1, repeat('#',12));
|
|
insert into t1 values(2, repeat('+',12));
|
|
insert into t1 values(3, repeat('/',12));
|
|
insert into t1 values(4, repeat('-',12));
|
|
insert into t1 values(5, repeat('.',12));
|
|
commit work;
|
|
# ---------------------------------------------------------------
|
|
# Test Begin: Test if recovery works if first page of user
|
|
# tablespace is full of zeroes.
|
|
select space from information_schema.innodb_sys_tables
|
|
where name = 'test/t1' into @space_id;
|
|
# Ensure that dirty pages of table t1 is flushed.
|
|
flush tables t1 for export;
|
|
unlock tables;
|
|
begin;
|
|
insert into t1 values (6, repeat('%', 12));
|
|
# Make the first page dirty for table t1
|
|
set global innodb_saved_page_number_debug = 0;
|
|
set global innodb_fil_make_page_dirty_debug = @space_id;
|
|
# Ensure that dirty pages of table t1 are flushed.
|
|
set global innodb_buf_flush_list_now = 1;
|
|
# Kill the server
|
|
# Make the first page (page_no=0) of the user tablespace
|
|
# full of zeroes.
|
|
#
|
|
# MDEV-11623: Use old FSP_SPACE_FLAGS in the doublewrite buffer.
|
|
check table t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 check status OK
|
|
select f1, f2 from t1;
|
|
f1 f2
|
|
1 ############
|
|
2 ++++++++++++
|
|
3 ////////////
|
|
4 ------------
|
|
5 ............
|
|
# Test End
|
|
# ---------------------------------------------------------------
|
|
# Test Begin: Test if recovery works if first page of user
|
|
# tablespace is corrupted.
|
|
select space from information_schema.innodb_sys_tables
|
|
where name = 'test/t1' into @space_id;
|
|
# Ensure that dirty pages of table t1 is flushed.
|
|
flush tables t1 for export;
|
|
unlock tables;
|
|
begin;
|
|
insert into t1 values (6, repeat('%', 12));
|
|
# Make the first page dirty for table t1
|
|
set global innodb_saved_page_number_debug = 0;
|
|
set global innodb_fil_make_page_dirty_debug = @space_id;
|
|
# Ensure that dirty pages of table t1 are flushed.
|
|
set global innodb_buf_flush_list_now = 1;
|
|
# Kill the server
|
|
# Corrupt the first page (page_no=0) of the user tablespace.
|
|
check table t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 check status OK
|
|
select f1, f2 from t1;
|
|
f1 f2
|
|
1 ############
|
|
2 ++++++++++++
|
|
3 ////////////
|
|
4 ------------
|
|
5 ............
|
|
# Test End
|
|
# ---------------------------------------------------------------
|
|
# Test Begin: Test if recovery works if 2nd page of user
|
|
# tablespace is full of zeroes.
|
|
select space from information_schema.innodb_sys_tables
|
|
where name = 'test/t1' into @space_id;
|
|
# Ensure that dirty pages of table t1 is flushed.
|
|
flush tables t1 for export;
|
|
unlock tables;
|
|
begin;
|
|
insert into t1 values (6, repeat('%', 400));
|
|
# Make the 2nd page dirty for table t1
|
|
set global innodb_saved_page_number_debug = 1;
|
|
set global innodb_fil_make_page_dirty_debug = @space_id;
|
|
# Ensure that dirty pages of table t1 are flushed.
|
|
set global innodb_buf_flush_list_now = 1;
|
|
# Kill the server
|
|
# Make the 2nd page (page_no=1) of the tablespace all zeroes.
|
|
check table t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 check status OK
|
|
select f1, f2 from t1;
|
|
f1 f2
|
|
1 ############
|
|
2 ++++++++++++
|
|
3 ////////////
|
|
4 ------------
|
|
5 ............
|
|
# Test End
|
|
# ---------------------------------------------------------------
|
|
# Test Begin: Test if recovery works if 2nd page of user
|
|
# tablespace is corrupted.
|
|
select space from information_schema.innodb_sys_tables
|
|
where name = 'test/t1' into @space_id;
|
|
# Ensure that dirty pages of table t1 is flushed.
|
|
flush tables t1 for export;
|
|
unlock tables;
|
|
begin;
|
|
insert into t1 values (6, repeat('%', 400));
|
|
# Make the 2nd page dirty for table t1
|
|
set global innodb_saved_page_number_debug = 1;
|
|
set global innodb_fil_make_page_dirty_debug = @space_id;
|
|
# Ensure that the dirty pages of table t1 are flushed.
|
|
set global innodb_buf_flush_list_now = 1;
|
|
# Kill the server
|
|
# Corrupt the 2nd page (page_no=1) of the user tablespace.
|
|
check table t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 check status OK
|
|
select f1, f2 from t1;
|
|
f1 f2
|
|
1 ############
|
|
2 ++++++++++++
|
|
3 ////////////
|
|
4 ------------
|
|
5 ............
|
|
# Test End
|
|
# ---------------------------------------------------------------
|
|
# Test Begin: Test if recovery works if first page of
|
|
# system tablespace is full of zeroes.
|
|
begin;
|
|
insert into t1 values (6, repeat('%', 400));
|
|
# Ensure that all dirty pages in the system are flushed.
|
|
set global innodb_buf_flush_list_now = 1;
|
|
# Make the first page dirty for system tablespace
|
|
set global innodb_saved_page_number_debug = 0;
|
|
set global innodb_fil_make_page_dirty_debug = 0;
|
|
# Ensure that the dirty page of system tablespace is also flushed.
|
|
set global innodb_buf_flush_list_now = 1;
|
|
# Kill the server
|
|
# Make the first page (page_no=0) of the system tablespace
|
|
# all zeroes.
|
|
check table t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 check status OK
|
|
select f1, f2 from t1;
|
|
f1 f2
|
|
1 ############
|
|
2 ++++++++++++
|
|
3 ////////////
|
|
4 ------------
|
|
5 ............
|
|
# Test End
|
|
# ---------------------------------------------------------------
|
|
# Test Begin: Test if recovery works if first page of
|
|
# system tablespace is corrupted.
|
|
begin;
|
|
insert into t1 values (6, repeat('%', 400));
|
|
# Ensure that all dirty pages in the system are flushed.
|
|
set global innodb_buf_flush_list_now = 1;
|
|
# Make the first page dirty for system tablespace
|
|
set global innodb_saved_page_number_debug = 0;
|
|
set global innodb_fil_make_page_dirty_debug = 0;
|
|
# Ensure that the dirty page of system tablespace is also flushed.
|
|
set global innodb_buf_flush_list_now = 1;
|
|
# Kill the server
|
|
# Corrupt the first page (page_no=0) of the system tablespace.
|
|
check table t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 check status OK
|
|
select f1, f2 from t1;
|
|
f1 f2
|
|
1 ############
|
|
2 ++++++++++++
|
|
3 ////////////
|
|
4 ------------
|
|
5 ............
|
|
# Test End
|
|
# ---------------------------------------------------------------
|
|
# Test Begin: Test if recovery works if 2nd page of
|
|
# system tablespace is full of zeroes.
|
|
begin;
|
|
insert into t1 values (6, repeat('%', 400));
|
|
# Ensure that all dirty pages in the system are flushed.
|
|
set global innodb_buf_flush_list_now = 1;
|
|
# Make the second page dirty for system tablespace
|
|
set global innodb_saved_page_number_debug = 1;
|
|
set global innodb_fil_make_page_dirty_debug = 0;
|
|
# Ensure that the dirty page of system tablespace is also flushed.
|
|
set global innodb_buf_flush_list_now = 1;
|
|
# Kill the server
|
|
# Make the 2nd page (page_no=1) of the system tablespace
|
|
# all zeroes.
|
|
check table t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 check status OK
|
|
select f1, f2 from t1;
|
|
f1 f2
|
|
1 ############
|
|
2 ++++++++++++
|
|
3 ////////////
|
|
4 ------------
|
|
5 ............
|
|
# Test End
|
|
# ---------------------------------------------------------------
|
|
# Test Begin: Test if recovery works if 2nd page of
|
|
# system tablespace is corrupted.
|
|
begin;
|
|
insert into t1 values (6, repeat('%', 400));
|
|
# Ensure that all dirty pages in the system are flushed.
|
|
set global innodb_buf_flush_list_now = 1;
|
|
# Make the second page dirty for system tablespace
|
|
set global innodb_saved_page_number_debug = 1;
|
|
set global innodb_fil_make_page_dirty_debug = 0;
|
|
# Ensure that the dirty page of system tablespace is also flushed.
|
|
set global innodb_buf_flush_list_now = 1;
|
|
# Kill the server
|
|
# Make the 2nd page (page_no=1) of the system tablespace
|
|
# all zeroes.
|
|
check table t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 check status OK
|
|
select f1, f2 from t1;
|
|
f1 f2
|
|
1 ############
|
|
2 ++++++++++++
|
|
3 ////////////
|
|
4 ------------
|
|
5 ............
|
|
# Test End
|
|
# ---------------------------------------------------------------
|
|
drop table t1;
|