mirror of
https://github.com/MariaDB/server.git
synced 2025-01-27 17:33:44 +01:00
bb56c30ad7
Problem & Analysis: If DML invokes a trigger or a
stored function that inserts into an AUTO_INCREMENT column,
that DML has to be marked as 'unsafe' statement. If the
tables are locked in the transaction prior to DML statement
(using LOCK TABLES), then the same statement is not marked as
'unsafe' statement. The logic of checking whether unsafeness
is protected with if (!thd->locked_tables_mode). Hence if
we lock the tables prior to DML statement, it is *not* entering
into this if condition. Hence the statement is not marked
as unsafe statement.
Fix: Irrespective of locked_tables_mode value, the unsafeness
check should be done. Now with this patch, the code is moved
out to 'decide_logging_format()' function where all these checks
are happening and also with out 'if(!thd->locked_tables_mode)'.
Along with the specified test case in the bug scenario
(BINLOG_STMT_UNSAFE_AUTOINC_COLUMNS), we also identified that
other cases BINLOG_STMT_UNSAFE_AUTOINC_NOT_FIRST,
BINLOG_STMT_UNSAFE_WRITE_AUTOINC_SELECT, BINLOG_STMT_UNSAFE_INSERT_TWO_KEYS
are also protected with thd->locked_tables_mode which is not right. All
of those checks also moved to 'decide_logging_format()' function.
53 lines
1.6 KiB
Text
53 lines
1.6 KiB
Text
include/master-slave.inc
|
|
[connection master]
|
|
CREATE TABLE t1(id INT AUTO_INCREMENT, i INT, PRIMARY KEY (id)) ENGINE=INNODB;
|
|
CREATE TABLE t2(id INT AUTO_INCREMENT, i INT, PRIMARY KEY (id)) ENGINE=INNODB;
|
|
CREATE TRIGGER trig1 AFTER INSERT ON t1
|
|
FOR EACH ROW
|
|
INSERT INTO t2(i) VALUES(new.i);
|
|
START TRANSACTION;
|
|
INSERT INTO t2(i) VALUES (1);
|
|
ROLLBACK;
|
|
INSERT INTO t1(i) VALUES(2);
|
|
START TRANSACTION;
|
|
LOCK TABLES t1 WRITE, t2 WRITE;
|
|
INSERT INTO t1(i) VALUES(3);
|
|
UNLOCK TABLES;
|
|
COMMIT;
|
|
include/diff_tables.inc [master:t1, slave:t1]
|
|
include/diff_tables.inc [master:t2, slave:t2]
|
|
DROP TABLE t1,t2;
|
|
CREATE TABLE t1(i INT) ENGINE=INNODB;
|
|
CREATE TABLE t2(id INT AUTO_INCREMENT, i INT, PRIMARY KEY (id)) ENGINE=INNODB;
|
|
INSERT INTO t1 values (1), (2), (3);
|
|
START TRANSACTION;
|
|
INSERT INTO t2(i) VALUES (1);
|
|
ROLLBACK;
|
|
INSERT INTO t2(i) SELECT i FROM t1;
|
|
START TRANSACTION;
|
|
LOCK TABLES t2 WRITE, t1 READ;
|
|
INSERT INTO t2(i) SELECT i FROM t1;
|
|
UNLOCK TABLES;
|
|
COMMIT;
|
|
include/diff_tables.inc [master:t1, slave:t1]
|
|
include/diff_tables.inc [master:t2, slave:t2]
|
|
DROP TABLE t1,t2;
|
|
CREATE TABLE t1(i int, id INT AUTO_INCREMENT, PRIMARY KEY (i, id)) ENGINE=MYISAM;
|
|
INSERT INTO t1 (i) values (1);
|
|
START TRANSACTION;
|
|
LOCK TABLES t1 WRITE;
|
|
INSERT INTO t1 (i) values (2);
|
|
UNLOCK TABLES;
|
|
COMMIT;
|
|
include/diff_tables.inc [master:t1, slave:t1]
|
|
DROP TABLE t1;
|
|
CREATE TABLE t1(i INT, j INT, UNIQUE KEY(i), UNIQUE KEY(j)) ENGINE=INNODB;
|
|
INSERT INTO t1 (i,j) VALUES (1,2) ON DUPLICATE KEY UPDATE j=j+1;
|
|
START TRANSACTION;
|
|
LOCK TABLES t1 WRITE;
|
|
INSERT INTO t1 (i,j) VALUES (1,2) ON DUPLICATE KEY UPDATE j=j+1;
|
|
UNLOCK TABLES;
|
|
COMMIT;
|
|
include/diff_tables.inc [master:t1, slave:t1]
|
|
DROP TABLE t1;
|
|
include/rpl_end.inc
|