mirror of
https://github.com/MariaDB/server.git
synced 2025-01-17 20:42:30 +01:00
369a5f1cdc
The problem from a user's perspective: user creates table A, and then tries to CREATE TABLE a SELECT from A - and this causes a deadlock error, a hang, or fails with a debug assert, but only if the storage engine is InnoDB. The origin of the problem: InnoDB uses case-insensitive collation (system_charset_info) when looking up the internal table share, thus returning the same share for 'a' and 'A'. Cause of the user-visible behavior: since the same share is returned to SQL locking subsystem, it assumes that the same table is first locked (within the same session) for WRITE, and then for READ, and returns a deadlock error. However, the code is wrong in not properly cleaning up upon an error, leaving external locks in place, which leads to assertion failures and hangs. Fix that has been implemented: the SQL layer should properly propagate the deadlock error, cleaning up and freeing all resources. Further work towards a more complete solution: InnoDB should not use case insensitive collation for table share hash if table names on disk honor the case. mysql-test/r/innodb-deadlock.result: Bug#25164 test case result mysql-test/t/innodb-deadlock.test: Bug#25164 test case. The CREATE TABLE may fail depending on the character set of the system and filesystem, but it should never hang. sql/lock.cc: Unlock the storage engine "external" table level locks, if the MySQL thr_lock locking subsystem detects a deadlock error.
140 lines
2.5 KiB
Text
140 lines
2.5 KiB
Text
-- source include/have_innodb.inc
|
|
|
|
connect (con1,localhost,root,,);
|
|
connect (con2,localhost,root,,);
|
|
|
|
--disable_warnings
|
|
drop table if exists t1,t2;
|
|
--enable_warnings
|
|
|
|
#
|
|
# Testing of FOR UPDATE
|
|
#
|
|
|
|
connection con1;
|
|
create table t1 (id integer, x integer) engine=INNODB;
|
|
insert into t1 values(0, 0);
|
|
set autocommit=0;
|
|
SELECT * from t1 where id = 0 FOR UPDATE;
|
|
|
|
connection con2;
|
|
set autocommit=0;
|
|
|
|
# The following query should hang because con1 is locking the page
|
|
--send
|
|
update t1 set x=2 where id = 0;
|
|
--sleep 2
|
|
|
|
connection con1;
|
|
update t1 set x=1 where id = 0;
|
|
select * from t1;
|
|
commit;
|
|
|
|
connection con2;
|
|
reap;
|
|
commit;
|
|
|
|
connection con1;
|
|
select * from t1;
|
|
commit;
|
|
|
|
drop table t1;
|
|
#
|
|
# Testing of FOR UPDATE
|
|
#
|
|
|
|
connection con1;
|
|
create table t1 (id integer, x integer) engine=INNODB;
|
|
create table t2 (b integer, a integer) engine=INNODB;
|
|
insert into t1 values(0, 0), (300, 300);
|
|
insert into t2 values(0, 10), (1, 20), (2, 30);
|
|
commit;
|
|
set autocommit=0;
|
|
select * from t2;
|
|
update t2 set a=100 where b=(SELECT x from t1 where id = b FOR UPDATE);
|
|
select * from t2;
|
|
select * from t1;
|
|
|
|
connection con2;
|
|
set autocommit=0;
|
|
|
|
# The following query should hang because con1 is locking the page
|
|
--send
|
|
update t1 set x=2 where id = 0;
|
|
--sleep 2
|
|
|
|
connection con1;
|
|
update t1 set x=1 where id = 0;
|
|
select * from t1;
|
|
commit;
|
|
|
|
connection con2;
|
|
reap;
|
|
commit;
|
|
|
|
connection con1;
|
|
select * from t1;
|
|
commit;
|
|
|
|
drop table t1, t2;
|
|
create table t1 (id integer, x integer) engine=INNODB;
|
|
create table t2 (b integer, a integer) engine=INNODB;
|
|
insert into t1 values(0, 0), (300, 300);
|
|
insert into t2 values(0, 0), (1, 20), (2, 30);
|
|
commit;
|
|
|
|
connection con1;
|
|
select a,b from t2 UNION SELECT id, x from t1 FOR UPDATE;
|
|
select * from t2;
|
|
select * from t1;
|
|
|
|
connection con2;
|
|
|
|
# The following query should hang because con1 is locking the page
|
|
update t2 set a=2 where b = 0;
|
|
select * from t2;
|
|
--send
|
|
update t1 set x=2 where id = 0;
|
|
--sleep 2
|
|
|
|
connection con1;
|
|
update t1 set x=1 where id = 0;
|
|
select * from t1;
|
|
commit;
|
|
|
|
connection con2;
|
|
reap;
|
|
commit;
|
|
|
|
connection con1;
|
|
select * from t1;
|
|
commit;
|
|
|
|
drop table t1, t2;
|
|
|
|
--echo End of 4.1 tests
|
|
|
|
#
|
|
# Bug#25164 create table `a` as select * from `A` hangs
|
|
#
|
|
|
|
set storage_engine=innodb;
|
|
|
|
--disable_warnings
|
|
drop table if exists a;
|
|
drop table if exists A;
|
|
--enable_warnings
|
|
|
|
create table A (c int);
|
|
insert into A (c) values (0);
|
|
--error 0,ER_LOCK_DEADLOCK,ER_UPDATE_TABLE_USED
|
|
create table a as select * from A;
|
|
drop table A;
|
|
|
|
--disable_warnings
|
|
drop table if exists a;
|
|
--enable_warnings
|
|
|
|
set storage_engine=default;
|
|
|
|
--echo End of 5.0 tests.
|