mariadb/storage/rocksdb
Sergey Vojtovich 20928e2e96 MDEV-14984 - regression in connect performance
Removed redundant plugin_thdvar_cleanup() from end_connection(): called by
THD::free_connection(), which always follows end_connection().

Saves at least one lock(LOCK_plugin) and one
rdlock(LOCK_system_variables_hash).

Benchmarked on a 2socket/20core/40threads Broadwell system using sysbench
connect brencmark @40 threads (with select 1 disabled).

10.2 shows moderate improvement: 136219.93 -> 137766.31 CPS.
10.3 is improvement is somewhat better: 93018.29 -> 101379.77 CPS.

Also backported MyRocks memory leak fix from 10.4, which turned out to
be unrelated.
2019-03-13 10:13:14 +04:00
..
mysql-test MDEV-14576 Include full name of object in message about incorrect value for column. 2018-12-16 02:21:41 +04:00
rocksdb@926f3a78a6 Merge branch 'merge-myrocks' of github.com:MariaDB/mergetrees into bb-10.2-mariarocks-merge 2018-08-28 14:09:04 +03:00
tools Merge branch 'merge-myrocks' of github.com:MariaDB/mergetrees into bb-10.2-mariarocks 2017-03-11 20:00:08 +00:00
unittest MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
.clang-format Copy of 2017-03-11 07:17:42 +03:00
.gitignore Ignore "invisible" files 2017-02-07 22:15:11 +02:00
atomic_stat.h MariaRocks port: move include/atomic_stat.h into storage/rocksdb 2017-01-21 22:58:57 +03:00
build_rocksdb.cmake Rocksdb, Windows - better fix for broken WIN32_LEAN_AND_MEAN 2018-09-05 19:32:31 +01:00
CMakeLists.txt fix RHEL8 "ambiguous python shebang" build failures 2019-01-03 00:23:06 +01:00
event_listener.cc MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
event_listener.h MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
get_rocksdb_files.sh Fix MariaRocks build (unfinished) 2016-10-07 08:25:10 +00:00
ha_rocksdb.cc MDEV-14984 - regression in connect performance 2019-03-13 10:13:14 +04:00
ha_rocksdb.h MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
ha_rocksdb_proto.h MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
logger.h MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
myrocks_hotbackup.py fix RHEL8 "ambiguous python shebang" build failures 2019-01-03 00:23:06 +01:00
properties_collector.cc MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
properties_collector.h MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_buff.h MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_cf_manager.cc MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_cf_manager.h MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_cf_options.cc MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_cf_options.h MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_compact_filter.h MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_comparator.h MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_datadic.cc MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_datadic.h MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_i_s.cc MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_i_s.h MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_index_merge.cc MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_index_merge.h MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_io_watchdog.cc MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_io_watchdog.h MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_mariadb_port.h Enable basic XA between MyRocks and the binlog 2017-08-25 11:55:12 +03:00
rdb_mariadb_server_port.cc Merge MyRocks merge tree into bb-10.2-mariarocks, unfinished. 2017-07-29 10:06:09 +00:00
rdb_mariadb_server_port.h Merge branch '10.2' of github.com:MariaDB/server into bb-10.2-mariarocks-merge 2017-09-19 15:34:38 +03:00
rdb_mutex_wrapper.cc MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_mutex_wrapper.h MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_perf_context.cc MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_perf_context.h MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_psi.cc Copy of 2018-08-28 08:23:44 +00:00
rdb_psi.h Copy of 2018-08-28 08:23:44 +00:00
rdb_source_revision.h.in MDEV-12458: Variable and log records to indicate RocksDB version are missing 2017-12-31 21:58:50 +02:00
rdb_sst_info.cc MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_sst_info.h MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_threads.cc MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_threads.h MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_utils.cc MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
rdb_utils.h MDEV-14267: correct FSF address 2018-10-30 19:45:09 +08:00
README Copy of 2017-07-28 17:52:07 +00:00
rocksdb-range-access.txt Copy of 2017-07-28 17:52:07 +00:00
ut0counter.h MDEV-12452 postfix - use C style cast, not reinterpret_cast 2017-04-07 06:09:25 +00:00

== Summary ==
This directory contains RocksDB-based Storage Engine (RDBSE) for MySQL,
also known as "MyRocks".

== Resources ==
https://github.com/facebook/mysql-5.6/wiki/Getting-Started-with-MyRocks
https://www.facebook.com/groups/MyRocks/

== Coding Conventions ==
The baseline for MyRocks coding conventions for the code in storage/rocksdb/
is based on the default clang format with a few minor changes.  The file
storage/rocksdb/.clang-format describes conventions and can be integrated
with Vim or Emacs as described here:
http://releases.llvm.org/3.6.0/tools/clang/docs/ClangFormat.html#vim-integration

All code outside of storage/rocksdb/ should conform to the MySQL coding
conventions:
http://dev.mysql.com/doc/internals/en/coding-guidelines.html.

Several refinements:
  0. There is an umbrella C++ namespace named "myrocks" for all MyRocks code.
  1. We introduced "RDB" as the super-short abbreviation for "RocksDB". We will
     use it as a name prefix, with different capitalization (see below), to ease
     up code navigation with ctags and grep.
     N.B. For ease of matching, we'll keep the variables and functions dealing
          with sysvars as close as possible to the outside visible names of
          sysvars, which start with "rocksdb_" prefix, the outward storage
          engine name.
  2. The names for classes, interfaces, and C++ structures (which act as
     classes), start with prefix "Rdb_".
     NB: For historical reasons, we'll keep the "ha_<storage_engine_name>" class
         name for ha_rocksdb class, which is an exception to the rule.
  3. The names for global objects and functions start with prefix "rdb_".
  4. The names for macros and constants start with prefix "RDB_".
  5. Regular class member names start with "m_".
  6. Static class member names start with "s_".
  7. Given the 80 character per line limit, we'll not always use full English
     words in names, when a well known or easily recognizable abbreviation
     exists (like "tx" for "transaction" or "param" for "parameter" etc).
  8. When needing to disambiguate, we use different suffixes for that, like
     "_arg" for a function argument/parameter, "_arr" for a C style array, and
     "_vect" for a std::vector etc.

== Running Tests ==
To run tests from rocksdb, rocksdb_rpl or other rocksdb_* packages, use the
following parameters:
  --default-storage-engine=rocksdb
  --skip-innodb
  --default-tmp-storage-engine=MyISAM
  --rocksdb