mirror of
https://github.com/MariaDB/server.git
synced 2025-01-17 12:32:27 +01:00
b5a038a590
This crash happened if a table was listed twice in a DROP TABLE statement, and the statement was executed while in LOCK TABLES mode. Since the two elements of table list were identical, they were assigned the same TABLE object. During processing of the first table element, the TABLE instance was destroyed and the second table list element was left with a dangling reference. When this reference was later accessed, the server crashed. Listing the same table twice in DROP TABLES should give an ER_NONUNIQ_TABLE error. However, this did not happen as the check for unique table names was skipped due to the lock type for table list elements being set to TL_IGNORE. Previously TL_UNLOCK was used and the unique check was performed. This bug was a regression introduced by a pre-requisite patch for Bug#51263 "Deadlock between transactional SELECT and ALTER TABLE ... REBUILD PARTITION". The regression only existed in an internal team tree and never in any released code. This patch reverts DROP TABLE (and DROP VIEW) to the old behavior of using TL_UNLOCK locks. Test case added to drop.test.
169 lines
4.6 KiB
Text
169 lines
4.6 KiB
Text
drop table if exists t1;
|
|
drop database if exists mysqltest;
|
|
drop database if exists client_test_db;
|
|
drop table t1;
|
|
ERROR 42S02: Unknown table 't1'
|
|
create table t1(n int);
|
|
insert into t1 values(1);
|
|
create temporary table t1( n int);
|
|
insert into t1 values(2);
|
|
create table t1(n int);
|
|
ERROR 42S01: Table 't1' already exists
|
|
drop table t1;
|
|
select * from t1;
|
|
n
|
|
1
|
|
create database mysqltest;
|
|
drop database if exists mysqltest;
|
|
create database mysqltest;
|
|
create table mysqltest.mysqltest (n int);
|
|
insert into mysqltest.mysqltest values (4);
|
|
select * from mysqltest.mysqltest;
|
|
n
|
|
4
|
|
drop database if exists mysqltest;
|
|
affected rows: 1
|
|
create database mysqltest;
|
|
use mysqltest;
|
|
drop table table1, table2, table3, table4, table5, table6,
|
|
table7, table8, table9, table10, table11, table12, table13,
|
|
table14, table15, table16, table17, table18, table19, table20,
|
|
table21, table22, table23, table24, table25, table26, table27,
|
|
table28;
|
|
ERROR 42S02: Unknown table 'table1,table2,table3,table4,table5,table6,table7,table8,table9,table10,table11,table12,table13,table'
|
|
drop table table1, table2, table3, table4, table5, table6,
|
|
table7, table8, table9, table10, table11, table12, table13,
|
|
table14, table15, table16, table17, table18, table19, table20,
|
|
table21, table22, table23, table24, table25, table26, table27,
|
|
table28, table29, table30;
|
|
ERROR 42S02: Unknown table 'table1,table2,table3,table4,table5,table6,table7,table8,table9,table10,table11,table12,table13,table'
|
|
use test;
|
|
drop database mysqltest;
|
|
flush tables with read lock;
|
|
create database mysqltest;
|
|
Got one of the listed errors
|
|
unlock tables;
|
|
create database mysqltest;
|
|
show databases;
|
|
Database
|
|
information_schema
|
|
mtr
|
|
mysql
|
|
mysqltest
|
|
performance_schema
|
|
test
|
|
flush tables with read lock;
|
|
drop database mysqltest;
|
|
Got one of the listed errors
|
|
unlock tables;
|
|
drop database mysqltest;
|
|
show databases;
|
|
Database
|
|
information_schema
|
|
mtr
|
|
mysql
|
|
performance_schema
|
|
test
|
|
drop database mysqltest;
|
|
ERROR HY000: Can't drop database 'mysqltest'; database doesn't exist
|
|
drop table t1;
|
|
flush tables with read lock;
|
|
create table t1(n int);
|
|
ERROR HY000: Can't execute the query because you have a conflicting read lock
|
|
unlock tables;
|
|
create table t1(n int);
|
|
show tables;
|
|
Tables_in_test
|
|
t1
|
|
drop table t1;
|
|
drop database if exists mysqltest;
|
|
drop table if exists t1;
|
|
create table t1 (i int);
|
|
create database mysqltest;
|
|
lock tables t1 read;
|
|
drop table t1;
|
|
show open tables;
|
|
drop database mysqltest;
|
|
select 1;
|
|
1
|
|
1
|
|
unlock tables;
|
|
drop table if exists t1,t2;
|
|
create table t1 (a int);
|
|
create table t2 (a int);
|
|
lock table t1 read;
|
|
drop table t2;
|
|
ERROR HY000: Table 't2' was not locked with LOCK TABLES
|
|
drop table t1;
|
|
ERROR HY000: Table 't1' was locked with a READ lock and can't be updated
|
|
unlock tables;
|
|
drop table t1,t2;
|
|
create table t1 (i int);
|
|
create table t2 (i int);
|
|
lock tables t1 read;
|
|
lock tables t2 read;
|
|
drop table t1;
|
|
ERROR HY000: Table 't1' was not locked with LOCK TABLES
|
|
drop table t1,t2;
|
|
ERROR HY000: Table 't1' was locked with a READ lock and can't be updated
|
|
unlock tables;
|
|
drop table t1,t2;
|
|
End of 5.0 tests
|
|
create database mysql_test;
|
|
create table mysql_test.t1(f1 int);
|
|
create table mysql_test.`#sql-347f_7` (f1 int);
|
|
create table mysql_test.`#sql-347f_8` (f1 int);
|
|
drop table mysql_test.`#sql-347f_8`;
|
|
drop database mysql_test;
|
|
|
|
# --
|
|
# -- Bug#29958: Weird message on DROP DATABASE if mysql.proc does not
|
|
# -- exist.
|
|
# --
|
|
DROP DATABASE IF EXISTS mysql_test;
|
|
CREATE DATABASE mysql_test;
|
|
DROP TABLE mysql.proc;
|
|
DROP DATABASE mysql_test;
|
|
Warnings:
|
|
Error 1146 Table 'mysql.proc' doesn't exist
|
|
|
|
# --
|
|
# -- End of Bug#29958.
|
|
# --
|
|
|
|
create database mysqltestbug26703;
|
|
use mysqltestbug26703;
|
|
create table `#mysql50#abc``def` ( id int );
|
|
create table `aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa` (a int);
|
|
ERROR 42000: Incorrect table name 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
|
|
create table `aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa` (a int);
|
|
create table `#mysql50#aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa` (a int);
|
|
create table `#mysql50#aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa` (a int);
|
|
ERROR 42000: Incorrect table name '#mysql50#aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
|
|
use test;
|
|
drop database mysqltestbug26703;
|
|
End of 5.1 tests
|
|
|
|
# --
|
|
# -- Bug#37431 (DROP TABLE does not report errors correctly).
|
|
# --
|
|
DROP TABLE IF EXISTS t1;
|
|
DROP TABLE t1;
|
|
ERROR 42S02: Unknown table 't1'
|
|
SHOW WARNINGS;
|
|
Level Code Message
|
|
Error 1051 Unknown table 't1'
|
|
|
|
# --
|
|
# -- End of Bug#37431.
|
|
# --
|
|
#
|
|
# Bug#54282 Crash in MDL_context::upgrade_shared_lock_to_exclusive
|
|
#
|
|
DROP TABLE IF EXISTS t1;
|
|
CREATE TABLE t1 (a INT);
|
|
LOCK TABLE t1 WRITE;
|
|
DROP TABLE t1, t1;
|
|
ERROR 42000: Not unique table/alias: 't1'
|
|
UNLOCK TABLES;
|
|
DROP TABLE t1;
|