mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 12:02:42 +01:00
a81da06f57
is allowed on views (not documented, broken)". Remove support of ALTER TABLE RENAME for views as: a) this feature was not documented, c) does not add any compatibility with other databases, b) its implementation doesn't follow metadata locking protocol by accessing .FRM without holding any metadata lock, c) its implementation complicates ALTER TABLE's code by introducing yet another separate branch to it. After this patch one can rename a view by using the documented way - RENAME TABLE statement. mysql-test/r/rename.result: Adjusted existing test case for bug #14959 "ALTER TABLE isn't able to rename a view" after fixing bug #53976: "ALTER TABLE RENAME is allowed on views (not documented, broken)". mysql-test/r/view.result: Adjusted test case after removing support for renaming of views through ALTER TABLE ... RENAME. mysql-test/t/rename.test: Adjusted existing test case for bug #14959 "ALTER TABLE isn't able to rename a view" after fixing bug #53976: "ALTER TABLE RENAME is allowed on views (not documented, broken)". mysql-test/t/view.test: Adjusted test case after removing support for renaming of views through ALTER TABLE ... RENAME. sql/sql_table.cc: Removed support for ALTER TABLE ... RENAME for views. This feature was not properly documented and its implementation was not following metadata locking protocol.
97 lines
2.3 KiB
Text
97 lines
2.3 KiB
Text
#
|
|
# Test of rename table
|
|
#
|
|
|
|
--source include/count_sessions.inc
|
|
|
|
--disable_warnings
|
|
drop table if exists t0,t1,t2,t3,t4;
|
|
# Clear up from other tests (to ensure that SHOW TABLES below is right)
|
|
drop table if exists t0,t5,t6,t7,t8,t9,t1_1,t1_2,t9_1,t9_2;
|
|
--enable_warnings
|
|
|
|
create table t0 SELECT 1,"table 1";
|
|
create table t2 SELECT 2,"table 2";
|
|
create table t3 SELECT 3,"table 3";
|
|
rename table t0 to t1;
|
|
rename table t3 to t4, t2 to t3, t1 to t2, t4 to t1;
|
|
select * from t1;
|
|
rename table t3 to t4, t2 to t3, t1 to t2, t4 to t1;
|
|
rename table t3 to t4, t2 to t3, t1 to t2, t4 to t1;
|
|
select * from t1;
|
|
|
|
# The following should give errors
|
|
--error ER_TABLE_EXISTS_ERROR,ER_TABLE_EXISTS_ERROR
|
|
rename table t1 to t2;
|
|
--error ER_TABLE_EXISTS_ERROR,ER_TABLE_EXISTS_ERROR
|
|
rename table t1 to t1;
|
|
--error ER_TABLE_EXISTS_ERROR,ER_TABLE_EXISTS_ERROR
|
|
rename table t3 to t4, t2 to t3, t1 to t2, t4 to t2;
|
|
show tables like "t_";
|
|
--error ER_TABLE_EXISTS_ERROR,ER_TABLE_EXISTS_ERROR
|
|
rename table t3 to t1, t2 to t3, t1 to t2, t4 to t1;
|
|
--error ER_FILE_NOT_FOUND,ER_FILE_NOT_FOUND
|
|
rename table t3 to t4, t5 to t3, t1 to t2, t4 to t1;
|
|
|
|
select * from t1;
|
|
select * from t2;
|
|
select * from t3;
|
|
|
|
# This should give a warning for t4
|
|
drop table if exists t1,t2,t3,t4;
|
|
|
|
#
|
|
# Bug #2397 RENAME TABLES is not blocked by
|
|
# FLUSH TABLES WITH READ LOCK
|
|
#
|
|
|
|
connect (con1,localhost,root,,);
|
|
connect (con2,localhost,root,,);
|
|
|
|
connection con1;
|
|
CREATE TABLE t1 (a int);
|
|
CREATE TABLE t3 (a int);
|
|
connection con2;
|
|
FLUSH TABLES WITH READ LOCK;
|
|
connection con1;
|
|
send RENAME TABLE t1 TO t2, t3 to t4;
|
|
connection con2;
|
|
show tables;
|
|
UNLOCK TABLES;
|
|
connection con1;
|
|
reap;
|
|
connection con2;
|
|
|
|
# Wait for the the tables to be renamed
|
|
# i.e the query below succeds
|
|
let $query= select * from t2, t4;
|
|
source include/wait_for_query_to_succeed.inc;
|
|
|
|
show tables;
|
|
|
|
drop table t2, t4;
|
|
|
|
disconnect con2;
|
|
disconnect con1;
|
|
connection default;
|
|
|
|
|
|
--echo End of 4.1 tests
|
|
|
|
|
|
--echo #
|
|
--echo # Bug#14959: "ALTER TABLE isn't able to rename a view"
|
|
--echo # Bug#53976: "ALTER TABLE RENAME is allowed on views
|
|
--echo # (not documented, broken)"
|
|
--echo #
|
|
create table t1(f1 int);
|
|
create view v1 as select * from t1;
|
|
--error ER_WRONG_OBJECT
|
|
alter table v1 rename to v2;
|
|
drop view v1;
|
|
drop table t1;
|
|
|
|
--echo End of 5.0 tests
|
|
|
|
--source include/wait_until_count_sessions.inc
|
|
|