mirror of
https://github.com/MariaDB/server.git
synced 2025-01-29 18:20:07 +01:00
6c5c1f0b2f
It's a micro optimization. On most platforms CPUs has instructions to
compare with 0 fast. DB_SUCCESS is the most popular outcome of functions
and this patch optimized code like (err == DB_SUCCESS)
BtrBulk::finish(): bogus assertion fixed
fil_node_t::read_page0(): corrected usage of os_file_read()
que_eval_sql(): bugus assertion removed. Apparently it checked that
the field was assigned after having been zero-initialized at
object creation.
It turns out that the return type of os_file_read_func() was changed
in mysql/mysql-server@98909cefbc (MySQL 5.7)
from ibool to dberr_t. The reviewer (if there was any) failed to
point out that because of future merges, it could be a bad idea to
change the return type of a function without changing the function name.
This change was applied to MariaDB 10.2.2 in
commit
|
||
|---|---|---|
| .. | ||
| crc32-vpmsum | ||
| mariabackup | ||
| readline | ||
| yassl | ||
| charset2html.c | ||
| CMakeLists.txt | ||
| comp_err.c | ||
| innochecksum.cc | ||
| my_print_defaults.c | ||
| mysql_waitpid.c | ||
| mysqld_safe_helper.c | ||
| perror.c | ||
| replace.c | ||
| resolve_stack_dump.c | ||
| resolveip.c | ||