mirror of
https://github.com/MariaDB/server.git
synced 2025-01-17 04:22:27 +01:00
a5efb91dea
Bug#54678: InnoDB, TRUNCATE, ALTER, I_S SELECT, crash or deadlock - Incompatible change: truncate no longer resorts to a row by row delete if the storage engine does not support the truncate method. Consequently, the count of affected rows does not, in any case, reflect the actual number of rows. - Incompatible change: it is no longer possible to truncate a table that participates as a parent in a foreign key constraint, unless it is a self-referencing constraint (both parent and child are in the same table). To work around this incompatible change and still be able to truncate such tables, disable foreign checks with SET foreign_key_checks=0 before truncate. Alternatively, if foreign key checks are necessary, please use a DELETE statement without a WHERE condition. Problem description: The problem was that for storage engines that do not support truncate table via a external drop and recreate, such as InnoDB which implements truncate via a internal drop and recreate, the delete_all_rows method could be invoked with a shared metadata lock, causing problems if the engine needed exclusive access to some internal metadata. This problem originated with the fact that there is no truncate specific handler method, which ended up leading to a abuse of the delete_all_rows method that is primarily used for delete operations without a condition. Solution: The solution is to introduce a truncate handler method that is invoked when the engine does not support truncation via a table drop and recreate. This method is invoked under a exclusive metadata lock, so that there is only a single instance of the table when the method is invoked. Also, the method is not invoked and a error is thrown if the table is a parent in a non-self-referencing foreign key relationship. This was necessary to avoid inconsistency as some integrity checks are bypassed. This is inline with the fact that truncate is primarily a DDL operation that was designed to quickly remove all data from a table. mysql-test/suite/innodb/t/innodb-truncate.test: Add test cases for truncate and foreign key checks. Also test that InnoDB resets auto-increment on truncate. mysql-test/suite/innodb/t/innodb.test: FK is not necessary, test is related to auto-increment. Update error number, truncate is no longer invoked if table is parent in a FK relationship. mysql-test/suite/innodb/t/innodb_mysql.test: Update error number, truncate is no longer invoked if table is parent in a FK relationship. Use delete instead of truncate, test is used to check the interaction of FKs, triggers and delete. mysql-test/suite/parts/inc/partition_check.inc: Fix typo. mysql-test/suite/sys_vars/t/foreign_key_checks_func.test: Update error number, truncate is no longer invoked if table is parent in a FK relationship. mysql-test/t/mdl_sync.test: Modify test case to reflect and ensure that truncate takes a exclusive metadata lock. mysql-test/t/trigger-trans.test: Update error number, truncate is no longer invoked if table is parent in a FK relationship. sql/ha_partition.cc: Reorganize the various truncate methods. delete_all_rows is now passed directly to the underlying engines, so as truncate. The code responsible for truncating individual partitions is moved to ha_partition::truncate_partition, which is invoked when a ALTER TABLE t1 TRUNCATE PARTITION p statement is executed. Since the partition truncate no longer can be invoked via delete, the bitmap operations are not necessary anymore. The explicit reset of the auto-increment value is also removed as the underlying engines are now responsible for reseting the value. sql/handler.cc: Wire up the handler truncate method. sql/handler.h: Introduce and document the truncate handler method. It assumes certain use cases of delete_all_rows. Add method to retrieve the list of foreign keys referencing a table. Method is used to avoid truncating tables that are parent in a foreign key relationship. sql/share/errmsg-utf8.txt: Add error message for truncate and FK. sql/sql_lex.h: Introduce a flag so that the partition engine can detect when a partition is being truncated. Used to give a special error. sql/sql_parse.cc: Function mysql_truncate_table no longer exists. sql/sql_partition_admin.cc: Implement the TRUNCATE PARTITION statement. sql/sql_truncate.cc: Change the truncate table implementation to use the new truncate handler method and to not rely on row-by-row delete anymore. The truncate handler method is always invoked with a exclusive metadata lock. Also, it is no longer possible to truncate a table that is parent in some non-self-referencing foreign key. storage/archive/ha_archive.cc: Rename method as the description indicates that in the future this could be a truncate operation. storage/blackhole/ha_blackhole.cc: Implement truncate as no operation for the blackhole engine in order to remain compatible with older releases. storage/federated/ha_federated.cc: Introduce truncate method that invokes delete_all_rows. This is required to support partition truncate as this form of truncate does not implement the drop and recreate protocol. storage/heap/ha_heap.cc: Introduce truncate method that invokes delete_all_rows. This is required to support partition truncate as this form of truncate does not implement the drop and recreate protocol. storage/ibmdb2i/ha_ibmdb2i.cc: Introduce truncate method that invokes delete_all_rows. This is required to support partition truncate as this form of truncate does not implement the drop and recreate protocol. storage/innobase/handler/ha_innodb.cc: Rename delete_all_rows to truncate. InnoDB now does truncate under a exclusive metadata lock. Introduce and reorganize methods used to retrieve the list of foreign keys referenced by a or referencing a table. storage/myisammrg/ha_myisammrg.cc: Introduce truncate method that invokes delete_all_rows. This is required in order to remain compatible with earlier releases where truncate would resort to a row-by-row delete.
197 lines
5.7 KiB
Text
197 lines
5.7 KiB
Text
drop table if exists t1;
|
|
create table t1 (a varchar(16), b int) engine=innodb;
|
|
create trigger t1_bi before insert on t1 for each row
|
|
begin
|
|
set new.a := upper(new.a);
|
|
set new.b := new.b + 3;
|
|
end|
|
|
select trigger_schema, trigger_name, event_object_schema,
|
|
event_object_table, action_statement from information_schema.triggers
|
|
where event_object_schema = 'test' and event_object_table = 't1';
|
|
trigger_schema trigger_name event_object_schema event_object_table action_statement
|
|
test t1_bi test t1 begin
|
|
set new.a := upper(new.a);
|
|
set new.b := new.b + 3;
|
|
end
|
|
insert into t1 values ('The Lion', 10);
|
|
select * from t1;
|
|
a b
|
|
THE LION 13
|
|
optimize table t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 optimize note Table does not support optimize, doing recreate + analyze instead
|
|
test.t1 optimize status OK
|
|
select trigger_schema, trigger_name, event_object_schema,
|
|
event_object_table, action_statement from information_schema.triggers
|
|
where event_object_schema = 'test' and event_object_table = 't1';
|
|
trigger_schema trigger_name event_object_schema event_object_table action_statement
|
|
test t1_bi test t1 begin
|
|
set new.a := upper(new.a);
|
|
set new.b := new.b + 3;
|
|
end
|
|
insert into t1 values ('The Unicorn', 20);
|
|
select * from t1;
|
|
a b
|
|
THE LION 13
|
|
THE UNICORN 23
|
|
alter table t1 add column c int default 0;
|
|
select trigger_schema, trigger_name, event_object_schema,
|
|
event_object_table, action_statement from information_schema.triggers
|
|
where event_object_schema = 'test' and event_object_table = 't1';
|
|
trigger_schema trigger_name event_object_schema event_object_table action_statement
|
|
test t1_bi test t1 begin
|
|
set new.a := upper(new.a);
|
|
set new.b := new.b + 3;
|
|
end
|
|
insert into t1 values ('Alice', 30, 1);
|
|
select * from t1;
|
|
a b c
|
|
THE LION 13 0
|
|
THE UNICORN 23 0
|
|
ALICE 33 1
|
|
alter table t1 rename to t1;
|
|
select trigger_schema, trigger_name, event_object_schema,
|
|
event_object_table, action_statement from information_schema.triggers
|
|
where event_object_schema = 'test' and event_object_table = 't1';
|
|
trigger_schema trigger_name event_object_schema event_object_table action_statement
|
|
test t1_bi test t1 begin
|
|
set new.a := upper(new.a);
|
|
set new.b := new.b + 3;
|
|
end
|
|
insert into t1 values ('The Crown', 40, 1);
|
|
select * from t1;
|
|
a b c
|
|
THE LION 13 0
|
|
THE UNICORN 23 0
|
|
ALICE 33 1
|
|
THE CROWN 43 1
|
|
alter table t1 rename to t1, add column d int default 0;
|
|
select trigger_schema, trigger_name, event_object_schema,
|
|
event_object_table, action_statement from information_schema.triggers
|
|
where event_object_schema = 'test' and event_object_table = 't1';
|
|
trigger_schema trigger_name event_object_schema event_object_table action_statement
|
|
test t1_bi test t1 begin
|
|
set new.a := upper(new.a);
|
|
set new.b := new.b + 3;
|
|
end
|
|
insert into t1 values ('The Pie', 50, 1, 1);
|
|
select * from t1;
|
|
a b c d
|
|
THE LION 13 0 0
|
|
THE UNICORN 23 0 0
|
|
ALICE 33 1 0
|
|
THE CROWN 43 1 0
|
|
THE PIE 53 1 1
|
|
drop table t1;
|
|
|
|
Bug#26141 mixing table types in trigger causes full
|
|
table lock on innodb table
|
|
|
|
Ensure we do not open and lock tables for the triggers we do not
|
|
fire.
|
|
|
|
drop table if exists t1, t2, t3;
|
|
drop trigger if exists trg_bug26141_au;
|
|
drop trigger if exists trg_bug26141_ai;
|
|
create table t1 (c int primary key) engine=innodb;
|
|
create table t2 (c int) engine=myisam;
|
|
create table t3 (c int) engine=myisam;
|
|
insert into t1 (c) values (1);
|
|
create trigger trg_bug26141_ai after insert on t1
|
|
for each row
|
|
begin
|
|
insert into t2 (c) values (1);
|
|
# We need the 'sync' lock to synchronously wait in connection 2 till
|
|
# the moment when the trigger acquired all the locks.
|
|
select release_lock("lock_bug26141_sync") into @a;
|
|
# 1000 is time in seconds of lock wait timeout -- this is a way
|
|
# to cause a manageable sleep up to 1000 seconds
|
|
select get_lock("lock_bug26141_wait", 1000) into @a;
|
|
end|
|
|
create trigger trg_bug26141_au after update on t1
|
|
for each row
|
|
begin
|
|
insert into t3 (c) values (1);
|
|
end|
|
|
select get_lock("lock_bug26141_wait", 0);
|
|
get_lock("lock_bug26141_wait", 0)
|
|
1
|
|
select get_lock("lock_bug26141_sync", /* must not be priorly locked */ 0);
|
|
get_lock("lock_bug26141_sync", /* must not be priorly locked */ 0)
|
|
1
|
|
insert into t1 (c) values (2);
|
|
select get_lock("lock_bug26141_sync", 1000);
|
|
get_lock("lock_bug26141_sync", 1000)
|
|
1
|
|
update t1 set c=3 where c=1;
|
|
select release_lock("lock_bug26141_sync");
|
|
release_lock("lock_bug26141_sync")
|
|
1
|
|
select release_lock("lock_bug26141_wait");
|
|
release_lock("lock_bug26141_wait")
|
|
1
|
|
select * from t1;
|
|
c
|
|
2
|
|
3
|
|
select * from t2;
|
|
c
|
|
1
|
|
select * from t3;
|
|
c
|
|
1
|
|
drop table t1, t2, t3;
|
|
DROP TABLE IF EXISTS t1;
|
|
DROP TABLE IF EXISTS t2;
|
|
CREATE TABLE t1(a INT PRIMARY KEY) ENGINE=innodb;
|
|
CREATE TABLE t2(b INT, FOREIGN KEY(b) REFERENCES t1(a)) ENGINE=innodb;
|
|
INSERT INTO t1 VALUES (1);
|
|
CREATE TRIGGER t1_bd BEFORE DELETE ON t1 FOR EACH ROW SET @a = 1;
|
|
CREATE TRIGGER t1_ad AFTER DELETE ON t1 FOR EACH ROW SET @b = 1;
|
|
SET @a = 0;
|
|
SET @b = 0;
|
|
TRUNCATE t1;
|
|
ERROR 42000: Cannot truncate a table referenced in a foreign key constraint (`test`.`t2`, CONSTRAINT `t2_ibfk_1` FOREIGN KEY (`b`) REFERENCES `test`.`t1` (`a`))
|
|
SELECT @a, @b;
|
|
@a @b
|
|
0 0
|
|
DELETE FROM t1;
|
|
SELECT @a, @b;
|
|
@a @b
|
|
1 1
|
|
INSERT INTO t1 VALUES (1);
|
|
DELETE FROM t1;
|
|
SELECT @a, @b;
|
|
@a @b
|
|
1 1
|
|
DROP TABLE t2, t1;
|
|
End of 5.0 tests
|
|
BUG#31612
|
|
Trigger fired multiple times leads to gaps in auto_increment sequence
|
|
create table t1 (a int, val char(1)) engine=InnoDB;
|
|
create table t2 (b int auto_increment primary key,
|
|
val char(1)) engine=InnoDB;
|
|
create trigger t1_after_insert after
|
|
insert on t1 for each row insert into t2 set val=NEW.val;
|
|
insert into t1 values ( 123, 'a'), ( 123, 'b'), ( 123, 'c'),
|
|
(123, 'd'), (123, 'e'), (123, 'f'), (123, 'g');
|
|
insert into t1 values ( 654, 'a'), ( 654, 'b'), ( 654, 'c'),
|
|
(654, 'd'), (654, 'e'), (654, 'f'), (654, 'g');
|
|
select * from t2 order by b;
|
|
b val
|
|
1 a
|
|
2 b
|
|
3 c
|
|
4 d
|
|
5 e
|
|
6 f
|
|
7 g
|
|
8 a
|
|
9 b
|
|
10 c
|
|
11 d
|
|
12 e
|
|
13 f
|
|
14 g
|
|
drop trigger t1_after_insert;
|
|
drop table t1,t2;
|