mirror of
https://github.com/MariaDB/server.git
synced 2025-01-20 14:02:32 +01:00
3058b8e2a6
Assert in Diagnostics_area::set_ok_status() for XA COMMIT This assert was triggered if XA COMMIT was issued when an XA transaction already had encountered an error (e.g. a deadlock) which required the XA transaction to be rolled back. In general, the assert is triggered if a statement tries to send OK to the client when an error has already been reported. It was triggered in this case because the trans_xa_commit() function first reported an error, then rolled back the transaction and finally returned FALSE, indicating success. Since trans_xa_commit() reported success, mysql_execute_command() tried to report OK, triggering the assert. This patch fixes the problem by fixing trans_xa_commit() to return TRUE if it encounters an error that requires rollback, even if the rollback itself is successful. Test case added to xa.test.
292 lines
5.6 KiB
Text
292 lines
5.6 KiB
Text
#
|
|
# WL#1756
|
|
#
|
|
-- source include/have_innodb.inc
|
|
|
|
# Save the initial number of concurrent sessions
|
|
--source include/count_sessions.inc
|
|
|
|
--disable_warnings
|
|
drop table if exists t1, t2;
|
|
--enable_warnings
|
|
create table t1 (a int) engine=innodb;
|
|
xa start 'test1';
|
|
insert t1 values (10);
|
|
xa end 'test1';
|
|
xa prepare 'test1';
|
|
xa rollback 'test1';
|
|
select * from t1;
|
|
|
|
xa start 'test2';
|
|
--error ER_XAER_RMFAIL
|
|
xa start 'test-bad';
|
|
insert t1 values (20);
|
|
--error ER_XAER_RMFAIL
|
|
xa prepare 'test2';
|
|
xa end 'test2';
|
|
xa prepare 'test2';
|
|
xa commit 'test2';
|
|
select * from t1;
|
|
|
|
xa start 'testa','testb';
|
|
insert t1 values (30);
|
|
|
|
--error ER_XAER_RMFAIL
|
|
commit;
|
|
|
|
xa end 'testa','testb';
|
|
|
|
--error ER_XAER_RMFAIL
|
|
begin;
|
|
--error ER_XAER_RMFAIL
|
|
create table t2 (a int);
|
|
|
|
connect (con1,localhost,root,,);
|
|
connection con1;
|
|
|
|
--error ER_XAER_DUPID
|
|
xa start 'testa','testb';
|
|
--error ER_XAER_DUPID
|
|
xa start 'testa','testb', 123;
|
|
|
|
# gtrid [ , bqual [ , formatID ] ]
|
|
xa start 0x7465737462, 0x2030405060, 0xb;
|
|
insert t1 values (40);
|
|
xa end 'testb',' 0@P`',11;
|
|
xa prepare 'testb',0x2030405060,11;
|
|
|
|
--error ER_XAER_RMFAIL
|
|
start transaction;
|
|
|
|
xa recover;
|
|
|
|
# uncomment the line below when binlog will be able to prepare
|
|
#disconnect con1;
|
|
connection default;
|
|
|
|
xa prepare 'testa','testb';
|
|
|
|
xa recover;
|
|
|
|
--error ER_XAER_NOTA
|
|
xa commit 'testb',0x2030405060,11;
|
|
xa rollback 'testa','testb';
|
|
|
|
--error ER_PARSE_ERROR
|
|
xa start 'zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz';
|
|
|
|
select * from t1;
|
|
|
|
disconnect con1;
|
|
connection default;
|
|
drop table t1;
|
|
|
|
#
|
|
# Bug#28323: Server crashed in xid cache operations
|
|
#
|
|
|
|
--disable_warnings
|
|
drop table if exists t1;
|
|
--enable_warnings
|
|
|
|
create table t1(a int, b int, c varchar(20), primary key(a)) engine = innodb;
|
|
insert into t1 values(1, 1, 'a');
|
|
insert into t1 values(2, 2, 'b');
|
|
|
|
connect (con1,localhost,root,,);
|
|
connect (con2,localhost,root,,);
|
|
|
|
--connection con1
|
|
xa start 'a','b';
|
|
update t1 set c = 'aa' where a = 1;
|
|
--connection con2
|
|
xa start 'a','c';
|
|
update t1 set c = 'bb' where a = 2;
|
|
--connection con1
|
|
--send update t1 set c = 'bb' where a = 2
|
|
--connection con2
|
|
--sleep 1
|
|
--error ER_LOCK_DEADLOCK
|
|
update t1 set c = 'aa' where a = 1;
|
|
select count(*) from t1;
|
|
--error ER_XA_RBDEADLOCK
|
|
xa end 'a','c';
|
|
xa rollback 'a','c';
|
|
--disconnect con2
|
|
|
|
connect (con3,localhost,root,,);
|
|
--connection con3
|
|
xa start 'a','c';
|
|
|
|
--disconnect con1
|
|
--disconnect con3
|
|
--connection default
|
|
drop table t1;
|
|
|
|
--echo #
|
|
--echo # BUG#51342 - more xid crashing
|
|
--echo #
|
|
CREATE TABLE t1(a INT) ENGINE=InnoDB;
|
|
XA START 'x';
|
|
SET SESSION autocommit=0;
|
|
INSERT INTO t1 VALUES(1);
|
|
--error ER_XAER_RMFAIL
|
|
SET SESSION autocommit=1;
|
|
SELECT @@autocommit;
|
|
INSERT INTO t1 VALUES(1);
|
|
XA END 'x';
|
|
XA COMMIT 'x' ONE PHASE;
|
|
DROP TABLE t1;
|
|
SET SESSION autocommit=1;
|
|
|
|
--echo End of 5.0 tests
|
|
|
|
#
|
|
# Bug#44672: Assertion failed: thd->transaction.xid_state.xid.is_null()
|
|
#
|
|
|
|
xa start 'a';
|
|
xa end 'a';
|
|
xa rollback 'a';
|
|
xa start 'a';
|
|
xa end 'a';
|
|
xa rollback 'a';
|
|
|
|
#
|
|
# Bug#45548: XA transaction without access to InnoDB tables crashes the server
|
|
#
|
|
|
|
xa start 'a';
|
|
xa end 'a';
|
|
xa prepare 'a';
|
|
xa commit 'a';
|
|
|
|
xa start 'a';
|
|
xa end 'a';
|
|
xa prepare 'a';
|
|
xa commit 'a';
|
|
|
|
#
|
|
# BUG#43171 - Assertion failed: thd->transaction.xid_state.xid.is_null()
|
|
#
|
|
CREATE TABLE t1(a INT, KEY(a)) ENGINE=InnoDB;
|
|
INSERT INTO t1 VALUES(1),(2);
|
|
connect(con1,localhost,root,,);
|
|
|
|
# Part 1: Prepare to test XA START after regular transaction deadlock
|
|
BEGIN;
|
|
UPDATE t1 SET a=3 WHERE a=1;
|
|
|
|
connection default;
|
|
BEGIN;
|
|
UPDATE t1 SET a=4 WHERE a=2;
|
|
|
|
connection con1;
|
|
let $conn_id= `SELECT CONNECTION_ID()`;
|
|
SEND UPDATE t1 SET a=5 WHERE a=2;
|
|
|
|
connection default;
|
|
let $wait_timeout= 2;
|
|
let $wait_condition= SELECT 1 FROM INFORMATION_SCHEMA.PROCESSLIST
|
|
WHERE ID=$conn_id AND STATE='Searching rows for update';
|
|
--source include/wait_condition.inc
|
|
|
|
--error ER_LOCK_DEADLOCK
|
|
UPDATE t1 SET a=5 WHERE a=1;
|
|
ROLLBACK;
|
|
|
|
# Part 2: Prepare to test XA START after XA transaction deadlock
|
|
connection con1;
|
|
REAP;
|
|
ROLLBACK;
|
|
BEGIN;
|
|
UPDATE t1 SET a=3 WHERE a=1;
|
|
|
|
connection default;
|
|
XA START 'xid1';
|
|
UPDATE t1 SET a=4 WHERE a=2;
|
|
|
|
connection con1;
|
|
SEND UPDATE t1 SET a=5 WHERE a=2;
|
|
|
|
connection default;
|
|
let $wait_timeout= 2;
|
|
let $wait_condition= SELECT 1 FROM INFORMATION_SCHEMA.PROCESSLIST
|
|
WHERE ID=$conn_id AND STATE='Searching rows for update';
|
|
--source include/wait_condition.inc
|
|
|
|
--error ER_LOCK_DEADLOCK
|
|
UPDATE t1 SET a=5 WHERE a=1;
|
|
--error ER_XA_RBDEADLOCK
|
|
XA END 'xid1';
|
|
XA ROLLBACK 'xid1';
|
|
|
|
XA START 'xid1';
|
|
XA END 'xid1';
|
|
XA ROLLBACK 'xid1';
|
|
|
|
disconnect con1;
|
|
DROP TABLE t1;
|
|
|
|
|
|
--echo #
|
|
--echo # Bug#56448 Assertion failed: ! is_set() with second xa end
|
|
--echo #
|
|
|
|
XA START 'x';
|
|
XA END 'x';
|
|
# Second XA END caused an assertion.
|
|
--error ER_XAER_RMFAIL
|
|
XA END 'x';
|
|
XA PREPARE 'x';
|
|
# Second XA PREPARE also caused an assertion.
|
|
--error ER_XAER_RMFAIL
|
|
XA PREPARE 'x';
|
|
XA ROLLBACK 'x';
|
|
|
|
|
|
--echo #
|
|
--echo # Bug#59986 Assert in Diagnostics_area::set_ok_status() for XA COMMIT
|
|
--echo #
|
|
|
|
--disable_warnings
|
|
DROP TABLE IF EXISTS t1;
|
|
--enable_warnings
|
|
|
|
CREATE TABLE t1(a INT, b INT, PRIMARY KEY(a)) engine=InnoDB;
|
|
INSERT INTO t1 VALUES (1, 1), (2, 2);
|
|
|
|
--echo # Connection con1
|
|
connect (con1, localhost, root);
|
|
XA START 'a';
|
|
UPDATE t1 SET b= 3 WHERE a=1;
|
|
|
|
--echo # Connection default
|
|
connection default;
|
|
XA START 'b';
|
|
UPDATE t1 SET b=4 WHERE a=2;
|
|
--echo # Sending:
|
|
--send UPDATE t1 SET b=5 WHERE a=1
|
|
|
|
--echo # Connection con1
|
|
connection con1;
|
|
--sleep 1
|
|
--error ER_LOCK_DEADLOCK
|
|
UPDATE t1 SET b=6 WHERE a=2;
|
|
# This used to trigger the assert
|
|
--error ER_XA_RBDEADLOCK
|
|
XA COMMIT 'a';
|
|
|
|
--echo # Connection default
|
|
connection default;
|
|
--echo # Reaping: UPDATE t1 SET b=5 WHERE a=1
|
|
--reap
|
|
XA END 'b';
|
|
XA ROLLBACK 'b';
|
|
DROP TABLE t1;
|
|
disconnect con1;
|
|
|
|
|
|
# Wait till all disconnects are completed
|
|
--source include/wait_until_count_sessions.inc
|
|
|