mirror of
https://github.com/MariaDB/server.git
synced 2025-01-30 18:41:56 +01:00
149b754768
ALTER TABLE ... ADD FOREIGN KEY may trigger assertion failure when it has LOCK=EXCLUSIVE clause or concurrent FLUSH TABLES is being executed. In both cases being altered table is marked as flushed, which forces subsequent attempt to open parent table to re-open. Which in turn is not allowed while transaction is running. Rather than opening parent table, just take appropriate MDL lock. Also removed table_already_fk_prelocked() check: MDL itself has much better methods to handle duplicate locks. E.g. the former won't acquire MDL_SHARED_NO_WRITE if it already has MDL_SHARED_READ.
128 lines
4.2 KiB
Text
128 lines
4.2 KiB
Text
--source include/have_innodb.inc
|
|
--source include/have_debug.inc
|
|
--source include/have_debug_sync.inc
|
|
|
|
--enable_connect_log
|
|
|
|
--echo #
|
|
--echo # Bug #19471516 SERVER CRASHES WHEN EXECUTING ALTER TABLE
|
|
--echo # ADD FOREIGN KEY
|
|
--echo #
|
|
|
|
CREATE TABLE `department` (`department_id` INT, `department_people_fk` INT,
|
|
PRIMARY KEY (`department_id`)) engine=innodb;
|
|
|
|
CREATE TABLE `title` (`title_id` INT, `title_manager_fk` INT,
|
|
`title_reporter_fk` INT, PRIMARY KEY (`title_id`)) engine=innodb;
|
|
|
|
CREATE TABLE `people` (`people_id` INT, PRIMARY KEY (`people_id`)) engine=innodb;
|
|
|
|
ALTER TABLE `department` ADD FOREIGN KEY (`department_people_fk`) REFERENCES
|
|
`people` (`people_id`);
|
|
|
|
ALTER TABLE `title` ADD FOREIGN KEY (`title_manager_fk`) REFERENCES `people`
|
|
(`people_id`);
|
|
|
|
ALTER TABLE `title` ADD FOREIGN KEY (`title_reporter_fk`) REFERENCES `people`
|
|
(`people_id`);
|
|
|
|
drop table title, department, people;
|
|
|
|
#
|
|
# FK and prelocking:
|
|
# child table accesses (reads and writes) wait for locks.
|
|
#
|
|
create table t1 (a int primary key, b int) engine=innodb;
|
|
create table t2 (c int primary key, d int,
|
|
foreign key (d) references t1 (a) on update cascade) engine=innodb;
|
|
insert t1 values (1,1),(2,2),(3,3);
|
|
insert t2 values (4,1),(5,2),(6,3);
|
|
flush table t2 with read lock; # this takes MDL_SHARED_NO_WRITE
|
|
connect (con1,localhost,root);
|
|
--error ER_ROW_IS_REFERENCED_2
|
|
delete from t1 where a=2;
|
|
send update t1 set a=10 where a=1;
|
|
connection default;
|
|
let $wait_condition= select 1 from information_schema.processlist where state='Waiting for table metadata lock';
|
|
source include/wait_condition.inc;
|
|
unlock tables;
|
|
connection con1;
|
|
reap;
|
|
connection default;
|
|
lock table t2 write; # this takes MDL_SHARED_NO_READ_WRITE
|
|
connection con1;
|
|
send delete from t1 where a=2;
|
|
connection default;
|
|
let $wait_condition= select 1 from information_schema.processlist where state='Waiting for table metadata lock';
|
|
source include/wait_condition.inc;
|
|
unlock tables;
|
|
connection con1;
|
|
--error ER_ROW_IS_REFERENCED_2
|
|
reap;
|
|
connection default;
|
|
unlock tables;
|
|
disconnect con1;
|
|
|
|
# but privileges should not be checked
|
|
create user foo;
|
|
grant select,update on test.t1 to foo;
|
|
connect(foo,localhost,foo);
|
|
update t1 set a=30 where a=3;
|
|
disconnect foo;
|
|
connection default;
|
|
select * from t2;
|
|
drop table t2, t1;
|
|
drop user foo;
|
|
|
|
#
|
|
# MDEV-16465 Invalid (old?) table or database name or hang in ha_innobase::delete_table and log semaphore wait upon concurrent DDL with foreign keys
|
|
#
|
|
create table t1 (f1 int primary key) engine=innodb;
|
|
create table t2 (f2 int primary key) engine=innodb;
|
|
create table t3 (f3 int primary key, foreign key (f3) references t2(f2)) engine=innodb;
|
|
insert into t1 values (1),(2),(3),(4),(5);
|
|
insert into t2 values (1),(2),(3),(4),(5);
|
|
insert into t3 values (1),(2),(3),(4),(5);
|
|
connect con1,localhost,root;
|
|
set debug_sync='alter_table_before_rename_result_table signal g1 wait_for g2';
|
|
send alter table t2 add constraint foreign key (f2) references t1(f1) on delete cascade on update cascade;
|
|
connection default;
|
|
let $conn=`select connection_id()`;
|
|
set debug_sync='before_execute_sql_command wait_for g1';
|
|
send update t1 set f1 = f1 + 100000 limit 2;
|
|
connect con2,localhost,root;
|
|
let $wait_condition= select 1 from information_schema.processlist where state='Waiting for table metadata lock' and info like 'update t1 %';
|
|
source include/wait_condition.inc;
|
|
--replace_result $conn UPDATE
|
|
eval kill query $conn;
|
|
disconnect con2;
|
|
connection default;
|
|
error ER_QUERY_INTERRUPTED;
|
|
reap;
|
|
set debug_sync='now signal g2';
|
|
connection con1;
|
|
reap;
|
|
show create table t2;
|
|
disconnect con1;
|
|
connection default;
|
|
select * from t2 where f2 not in (select f1 from t1);
|
|
select * from t3 where f3 not in (select f2 from t2);
|
|
drop table t3;
|
|
drop table t2;
|
|
drop table t1;
|
|
set debug_sync='reset';
|
|
|
|
|
|
--echo #
|
|
--echo # MDEV-17595 - Server crashes in copy_data_between_tables or
|
|
--echo # Assertion `thd->transaction.stmt.is_empty() ||
|
|
--echo # (thd->state_flags & Open_tables_state::BACKUPS_AVAIL)'
|
|
--echo # fails in close_tables_for_reopen upon concurrent
|
|
--echo # ALTER TABLE and FLUSH
|
|
--echo #
|
|
CREATE TABLE t1 (a INT, KEY(a)) ENGINE=InnoDB;
|
|
INSERT INTO t1 VALUES(1),(2);
|
|
CREATE TABLE t2 (b INT, KEY(b)) ENGINE=InnoDB;
|
|
INSERT INTO t2 VALUES(2);
|
|
ALTER TABLE t2 ADD FOREIGN KEY(b) REFERENCES t1(a), LOCK=EXCLUSIVE;
|
|
DROP TABLE t2, t1;
|