mirror of
https://github.com/MariaDB/server.git
synced 2025-01-30 02:30:06 +01:00
17e0f5224c
This commit adds correct handling of binlogs for SST using rsync
or mariabackup. Before this fix, binlogs were handled incorrectly -
- only one (last) binary log file was transferred during SST, which
then led to various failures (for example, when trying to list all
events from the binary log). These bugs were long masked by flaws
in the primitive binlogs handling code in the SST scripts, which
causing binary logs files to be erased after transfer or not added
to the binlog index on the joiner node. Now the correct transfer
of all binary logs (not just the last of the binary log files) has
been implemented both for the rsync (at the script level) and for
the mariabackup (at the level of the main utility code).
This commit also adds a new sst_max_binlogs=<n> parameter, which
can be located in the [sst] section or in the [xtrabackup] section
(historically, supported for mariabackup only, not for rsync), or
in one of the server sections. This parameter specifies the number
of binary log files to be sent to the joiner node during SST. This
option is added for compatibility with old SST scripting behavior,
which can be emulated by setting the sst_max_binlogs=1 (although
in general this can cause problems for the reasons described above).
In addition, setting the sst_max_binlogs=0 can be used to suppress
the transmission of binary logs to the joiner nodes during SST
(although sometimes a single file with the current binary log can
still be transmitted to the joiner, even with sst_max_binlogs=0,
because this sometimes necessary in modes that involve the use of
GTIDs with Galera).
Also, this commit ensures correct handling of paths to various
innodb files and directories in the SST scripts, and fixes some
problems with this that existed in mariabackup utility (which
were associated with incorrect handling of the innodb_data_dir
parameter in some scenarios).
In addition, this commit contains the following enhancements:
1) Added tests for mtr, which check the correct work with binlogs
after SST (using rsync and mariabackup);
2) Added correct handling of slashes at the end of all paths that
the SST script receives as parameters;
3) Improved parsing code for --mysqld-args parameters. Now it
correctly processes the sequence "--" after the name of the
one-letter option;
4) Checking the secret signature during joiner authentication
is made independent of presence of bash (as a unix shell)
in the system and diff utility no longer needed to check
certificates compliance;
5) All directories that are necessary for the correct placement
of various logs are automatically created by SST scripts in
advance (before running mariabackup on the joiner node);
6) Removal of old binary logs on joiner is done using the binlog
index (if it exists) (not only by fixed pattern that based
on the current binlog name, as before);
7) Paths for placing binary logs are correctly processed if they
are set as relative paths (to the datadir);
8) SST scripts are made even more resistant to spaces in filenames
(now for binlogs);
9) In case of failure, SST scripts now always end with an exit
code other than zero;
10) SST script for rsync now correctly create a tar file with
the binlogs, even if the paths to them (in the binlog index
file) are specified as a mix of absolute and relative paths,
and even if they do not match with the datadir path specified
in the current configuration settings.
89 lines
1.7 KiB
C
89 lines
1.7 KiB
C
#ifndef XTRABACKUP_BACKUP_MYSQL_H
|
|
#define XTRABACKUP_BACKUP_MYSQL_H
|
|
|
|
#include <mysql.h>
|
|
|
|
/* mysql flavor and version */
|
|
enum mysql_flavor_t { FLAVOR_UNKNOWN, FLAVOR_MYSQL,
|
|
FLAVOR_PERCONA_SERVER, FLAVOR_MARIADB };
|
|
extern mysql_flavor_t server_flavor;
|
|
extern unsigned long mysql_server_version;
|
|
|
|
/* server capabilities */
|
|
extern bool have_changed_page_bitmaps;
|
|
extern bool have_backup_locks;
|
|
extern bool have_lock_wait_timeout;
|
|
extern bool have_galera_enabled;
|
|
extern bool have_flush_engine_logs;
|
|
extern bool have_multi_threaded_slave;
|
|
extern bool have_gtid_slave;
|
|
|
|
|
|
/* History on server */
|
|
extern time_t history_start_time;
|
|
extern time_t history_end_time;
|
|
extern time_t history_lock_time;
|
|
|
|
|
|
extern bool sql_thread_started;
|
|
extern char *mysql_slave_position;
|
|
extern char *mysql_binlog_position;
|
|
|
|
/** connection to mysql server */
|
|
extern MYSQL *mysql_connection;
|
|
|
|
void
|
|
capture_tool_command(int argc, char **argv);
|
|
|
|
bool
|
|
select_history();
|
|
|
|
bool
|
|
flush_changed_page_bitmaps();
|
|
|
|
void
|
|
backup_cleanup();
|
|
|
|
bool
|
|
get_mysql_vars(MYSQL *connection);
|
|
|
|
bool
|
|
detect_mysql_capabilities_for_backup();
|
|
|
|
MYSQL *
|
|
xb_mysql_connect();
|
|
|
|
MYSQL_RES *
|
|
xb_mysql_query(MYSQL *connection, const char *query, bool use_result,
|
|
bool die_on_error = true);
|
|
|
|
void
|
|
unlock_all(MYSQL *connection);
|
|
|
|
bool
|
|
write_current_binlog_file(MYSQL *connection, bool write_binlogs);
|
|
|
|
bool
|
|
write_xtrabackup_info(MYSQL *connection, const char * filename, bool history,
|
|
bool stream);
|
|
|
|
bool
|
|
write_backup_config_file();
|
|
|
|
bool
|
|
lock_binlog_maybe(MYSQL *connection);
|
|
|
|
bool
|
|
lock_tables(MYSQL *connection);
|
|
|
|
bool
|
|
wait_for_safe_slave(MYSQL *connection);
|
|
|
|
bool
|
|
write_galera_info(MYSQL *connection);
|
|
|
|
bool
|
|
write_slave_info(MYSQL *connection);
|
|
|
|
|
|
#endif
|