mirror of
https://github.com/MariaDB/server.git
synced 2025-01-15 19:42:28 +01:00
807e4f320f
os_innodb_umask was of the incorrect type resulting in warnings
in clang-19. The correct type is mode_t.
As os_innodb_umask was set during innnodb_init from my_umask,
corrected the type there along with its companion my_umask_dir.
Because of this, the defaults mask values in innodb never
had an effect.
The resulting change allow found signed differences in
my_create{,_nosymlink}, open_nosymlinks:
mysys/my_create.c:47:20: error: operand of ?: changes signedness from ‘int’ to ‘mode_t’ {aka ‘unsigned int’} due to unsignedness of other operand [-Werror=sign-compare]
47 | CreateFlags ? CreateFlags : my_umask);
Ref: clang-19 warnings:
[55/123] Building CXX object storage/innobase/CMakeFiles/innobase.dir/os/os0file.cc.o
storage/innobase/os/os0file.cc:1075:46: warning: implicit conversion loses integer precision: 'ulint' (aka 'unsigned long') to 'mode_t' (aka 'unsigned int') [-Wshorten-64-to-32]
1075 | file = open(name, create_flag | O_CLOEXEC, os_innodb_umask);
| ~~~~ ^~~~~~~~~~~~~~~
storage/innobase/os/os0file.cc:1249:46: warning: implicit conversion loses integer precision: 'ulint' (aka 'unsigned long') to 'mode_t' (aka 'unsigned int') [-Wshorten-64-to-32]
1249 | file = open(name, create_flag | O_CLOEXEC, os_innodb_umask);
| ~~~~ ^~~~~~~~~~~~~~~
storage/innobase/os/os0file.cc:1381:45: warning: implicit conversion loses integer precision: 'ulint' (aka 'unsigned long') to 'mode_t' (aka 'unsigned int') [-Wshorten-64-to-32]
1381 | file = open(name, create_flag | O_CLOEXEC, os_innodb_umask);
| ~~~~ ^~~~~~~~~~~~~~~
60 lines
1.8 KiB
C
60 lines
1.8 KiB
C
/* Copyright (c) 2000, 2001, 2005-2008 MySQL AB, 2009 Sun Microsystems, Inc.
|
|
Use is subject to license terms.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1335 USA */
|
|
|
|
#include "mysys_priv.h"
|
|
#include <my_dir.h>
|
|
#include "mysys_err.h"
|
|
#include <errno.h>
|
|
#include <my_sys.h>
|
|
#if defined(_WIN32)
|
|
#include <share.h>
|
|
#endif
|
|
|
|
/*
|
|
** Create a new file
|
|
** Arguments:
|
|
** Path-name of file
|
|
** Read | write on file (umask value)
|
|
** Read & Write on open file
|
|
** Special flags
|
|
*/
|
|
|
|
|
|
File my_create(const char *FileName, mode_t CreateFlags, int access_flags,
|
|
myf MyFlags)
|
|
{
|
|
int fd;
|
|
DBUG_ENTER("my_create");
|
|
DBUG_PRINT("my",("Name: '%s' CreateFlags: %u AccessFlags: %d MyFlags: %lu",
|
|
FileName, CreateFlags, access_flags, MyFlags));
|
|
#if defined(_WIN32)
|
|
fd= my_win_open(FileName, access_flags | O_CREAT);
|
|
#else
|
|
fd= open((char *) FileName, access_flags | O_CREAT | O_CLOEXEC,
|
|
CreateFlags ? CreateFlags : my_umask);
|
|
#endif
|
|
|
|
if ((MyFlags & MY_SYNC_DIR) && (fd >=0) &&
|
|
my_sync_dir_by_file(FileName, MyFlags))
|
|
{
|
|
my_close(fd, MyFlags);
|
|
fd= -1;
|
|
}
|
|
|
|
fd= my_register_filename(fd, FileName, FILE_BY_CREATE,
|
|
EE_CANTCREATEFILE, MyFlags);
|
|
DBUG_RETURN(fd);
|
|
} /* my_create */
|