mirror of
https://github.com/MariaDB/server.git
synced 2025-01-23 23:34:34 +01:00
7bb6a72593
DATE and DATETIME can be compared either as strings or as int. Both methods have their disadvantages. Strings can contain valid DATETIME value but have insignificant zeros omitted thus became non-comparable with other DATETIME strings. The comparison as int usually will require conversion from the string representation and the automatic conversion in most cases is carried out in a wrong way thus producing wrong comparison result. Another problem occurs when one tries to compare DATE field with a DATETIME constant. The constant is converted to DATE losing its precision i.e. losing time part. This fix addresses the problems described above by adding a special DATE/DATETIME comparator. The comparator correctly converts DATE/DATETIME string values to int when it's necessary, adds zero time part (00:00:00) to DATE values to compare them correctly to DATETIME values. Due to correct conversion malformed DATETIME string values are correctly compared to other DATE/DATETIME values. As of this patch a DATE value equals to DATETIME value with zero time part. For example '2001-01-01' equals to '2001-01-01 00:00:00'. The compare_datetime() function is added to the Arg_comparator class. It implements the correct comparator for DATE/DATETIME values. Two supplementary functions called get_date_from_str() and get_datetime_value() are added. The first one extracts DATE/DATETIME value from a string and the second one retrieves the correct DATE/DATETIME value from an item. The new Arg_comparator::can_compare_as_dates() function is added and used to check whether two given items can be compared by the compare_datetime() comparator. Two caching variables were added to the Arg_comparator class to speedup the DATE/DATETIME comparison. One more store() method was added to the Item_cache_int class to cache int values. The new is_datetime() function was added to the Item class. It indicates whether the item returns a DATE/DATETIME value. sql/item.cc: Bug#27590: Wrong DATE/DATETIME comparison. One more store() method was added to the Item_cache_int class to cache int values. The new is_datetime() function was added to the Item class. It indicates whether the item returns a DATE/DATETIME value. sql/item.h: Bug#27590: Wrong DATE/DATETIME comparison. One more store() method was added to the Item_cache_int class to cache int values. The new is_datetime() function was added to the Item class. It indicates whether the item returns a DATE/DATETIME value. sql/item_cmpfunc.cc: Bug#27590: Wrong DATE/DATETIME comparison. The compare_datetime() function is added to the Arg_comparator class. It implements the correct comparator for DATE/DATETIME values. Two supplementary functions called get_date_from_str() and get_datetime_value() are added. The first one extracts DATE/DATETIME value from a string and the second one retrieves the correct DATE/DATETIME value from an item. The new Arg_comparator::can_compare_as_dates() function is added and used to check whether two given items can be compared by the compare_datetime() comparator. sql/item_cmpfunc.h: Bug#27590: Wrong DATE/DATETIME comparison. The compare_datetime() function is added to the Arg_comparator class. It implements the correct comparator for DATE/DATETIME values. Two supplementary functions called get_date_from_str() and get_datetime_value() are added. The first one extracts DATE/DATETIME value from a string and the second one retrieves the correct DATE/DATETIME value from an item. The new Arg_comparator::can_compare_as_dates() function is added and used to check whether two given items can be compared by the compare_datetime() comparator. Two caching variables were added to the Arg_comparator class to speedup the DATE/DATETIME comparison. mysql-test/include/ps_conv.inc: Test case adjusted after fix for bug#27590. mysql-test/r/distinct.result: Test cases results are corrected after fix for bug#27590. sql/sql_select.cc: Bug#27590: Wrong DATE/DATETIME comparison. The test_if_equality_guarantees_uniqueness() function now uses Arg_comparator::can_compare_as_dates() to detect comparable DATE/DATETIME items. mysql-test/r/ps_2myisam.result: The result of the adjusted test case after fix for bug#27590. mysql-test/r/ps_3innodb.result: The result of the adjusted test case after fix for bug#27590. mysql-test/r/ps_4heap.result: The result of the adjusted test case after fix for bug#27590. mysql-test/r/ps_5merge.result: The result of the adjusted test case after fix for bug#27590. mysql-test/r/subselect.result: Test cases results are corrected after fix for bug#27590. mysql-test/r/type_datetime.result: Added a test case for the bug#27590: Wrong DATE/DATETIME comparison. mysql-test/t/type_datetime.test: Added a test case for the bug#27590: Wrong DATE/DATETIME comparison. tests/mysql_client_test.c: Test case adjusted after fix for bug#27590. |
||
|---|---|---|
| .. | ||
| add_anonymous_users.inc | ||
| analyze_failure_sync_with_master.test | ||
| big_test.inc | ||
| check-testcase.test | ||
| check_var_limit.inc | ||
| common-tests.inc | ||
| ctype_common.inc | ||
| ctype_filesort.inc | ||
| ctype_innodb_like.inc | ||
| ctype_like_escape.inc | ||
| delete_anonymous_users.inc | ||
| endspace.inc | ||
| federated.inc | ||
| federated_cleanup.inc | ||
| get_binlog_dump_thread_id.inc | ||
| gis_generic.inc | ||
| have_archive.inc | ||
| have_bdb.inc | ||
| have_big5.inc | ||
| have_blackhole.inc | ||
| have_case_sensitive_file_system.inc | ||
| have_compress.inc | ||
| have_cp932.inc | ||
| have_cp1250_ch.inc | ||
| have_crypt.inc | ||
| have_csv.inc | ||
| have_debug.inc | ||
| have_eucjpms.inc | ||
| have_euckr.inc | ||
| have_exampledb.inc | ||
| have_federated_db.inc | ||
| have_gb2312.inc | ||
| have_gbk.inc | ||
| have_geometry.inc | ||
| have_innodb.inc | ||
| have_latin2_ch.inc | ||
| have_lowercase0.inc | ||
| have_multi_ndb.inc | ||
| have_ndb.inc | ||
| have_outfile.inc | ||
| have_query_cache.inc | ||
| have_sjis.inc | ||
| have_ssl.inc | ||
| have_tis620.inc | ||
| have_ucs2.inc | ||
| have_udf.inc | ||
| have_ujis.inc | ||
| im_check_env.inc | ||
| innodb_rollback_on_timeout.inc | ||
| is_debug_build.inc | ||
| loaddata_autocom.inc | ||
| master-slave.inc | ||
| mysqltest-x.inc | ||
| ndb_backup.inc | ||
| ndb_backup_print.inc | ||
| ndb_default_cluster.inc | ||
| not_as_root.inc | ||
| not_embedded.inc | ||
| not_openssl.inc | ||
| not_windows.inc | ||
| ps_conv.inc | ||
| ps_create.inc | ||
| ps_modify.inc | ||
| ps_modify1.inc | ||
| ps_query.inc | ||
| ps_renew.inc | ||
| report-features.test | ||
| rpl_stmt_seq.inc | ||
| show_msg.inc | ||
| show_msg80.inc | ||
| sp-vars.inc | ||
| strict_autoinc.inc | ||
| system_db_struct.inc | ||
| test_outfile.inc | ||
| testdb_only.inc | ||
| varchar.inc | ||
| wait_for_query_to_suceed.inc | ||
| wait_show_pattern.inc | ||
| wait_slave_status.inc | ||
| windows.inc | ||