mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 12:02:42 +01:00
f094eff1d9
pointed data. I ran gcc -Wcast-qual on storage/maria, this identified un-needed casts, a couple of functions which said they had a const parameter though they changed the pointed content! This is fixed here. Some suspicious places receive a comment. The original intention of running -Wcast-qual was to find what code changes R-tree keys: I added const words, but hidden casts like those of int2store (casts target to (uint16*)) removed const checking; -Wcast-qual helped find those hidden casts. Log handler does not change the content pointed by LEX_STRING::str it receives, so we now use a struct which has a const inside, to emphasize this and be able to pass "const uchar*" buffers to log handler without fear of their content being changed by it. One-line fix for a merge glitch (when merging from MyISAM). include/m_string.h: As Maria's log handler uses LEX_STRING but never changes the content pointed by LEX_STRING::str, and assigns uchar* into this member most of the time, we introduce a new struct LEX_CUSTRING (C const U unsigned) for the log handler. include/my_global.h: In macros which read pointed content: use const pointers so that gcc -Wcast-qual does not warn about casting a const pointer to non-const. include/my_handler.h: In macros which read pointed content: use const pointers so that gcc -Wcast-qual does not warn about casting a const pointer to non-const. ha_find_null() does not change *a. include/my_sys.h: insert_dynamic() does not change *element. include/myisampack.h: In macros which read pointed content: use const pointers so that gcc -Wcast-qual does not warn about casting a const pointer to non-const. mysys/array.c: insert_dynamic() does not change *element mysys/my_handler.c: ha_find_null() does not change *a storage/maria/ma_bitmap.c: Log handler receives const strings now storage/maria/ma_blockrec.c: Log handler receives const strings now. _ma_apply_undo_row_delete/update() do change *header. storage/maria/ma_blockrec.h: correct prototype storage/maria/ma_check.c: Log handler receives const strings now. Un-needed casts storage/maria/ma_checkpoint.c: Log handler receives const strings now storage/maria/ma_checksum.c: unneeded cast storage/maria/ma_commit.c: Log handler receives const strings now storage/maria/ma_create.c: Log handler receives const strings now storage/maria/ma_dbug.c: fixing warning of gcc -Wcast-qual storage/maria/ma_delete.c: Log handler receives const strings now storage/maria/ma_delete_all.c: Log handler receives const strings now storage/maria/ma_delete_table.c: Log handler receives const strings now storage/maria/ma_dynrec.c: fixing some warnings of gcc -Wcast-qual. Unneeded casts removed. Comment about function which lies. storage/maria/ma_ft_parser.c: fix for warnings of gcc -Wcast-qual, removing unneeded casts storage/maria/ma_ft_update.c: less casts, comment storage/maria/ma_key.c: less casts, stay const (warnings of gcc -Wcast-qual) storage/maria/ma_key_recover.c: Log handler receives const strings now storage/maria/ma_loghandler.c: Log handler receives const strings now storage/maria/ma_loghandler.h: Log handler receives const strings now storage/maria/ma_loghandler_lsn.h: In macros which read pointed content: use const pointers so that gcc -Wcast-qual does not warn about casting a const pointer to non-const. storage/maria/ma_page.c: Log handler receives const strings now; more const storage/maria/ma_recovery.c: Log handler receives const strings now storage/maria/ma_rename.c: Log handler receives const strings now storage/maria/ma_rt_index.c: more const, to emphasize that functions don't change pointed content. best_key= NULL was forgotten during merge from MyISAM a few days ago, was causing a Valgrind warning storage/maria/ma_rt_index.h: new proto storage/maria/ma_rt_key.c: more const storage/maria/ma_rt_key.h: new proto storage/maria/ma_rt_mbr.c: more const for functions which deserve it storage/maria/ma_rt_mbr.h: new prototype storage/maria/ma_rt_split.c: make const what is not changed. storage/maria/ma_search.c: un-needed casts, more const storage/maria/ma_sp_key.c: more const storage/maria/ma_unique.c: un-needed casts. storage/maria/ma_write.c: Log handler receives const strings now storage/maria/maria_def.h: some more const storage/maria/unittest/ma_test_loghandler-t.c: Log handler receives const strings now storage/maria/unittest/ma_test_loghandler_first_lsn-t.c: Log handler receives const strings now storage/maria/unittest/ma_test_loghandler_max_lsn-t.c: Log handler receives const strings now storage/maria/unittest/ma_test_loghandler_multigroup-t.c: Log handler receives const strings now storage/maria/unittest/ma_test_loghandler_multithread-t.c: Log handler receives const strings now storage/maria/unittest/ma_test_loghandler_noflush-t.c: Log handler receives const strings now storage/maria/unittest/ma_test_loghandler_nologs-t.c: Log handler receives const strings now storage/maria/unittest/ma_test_loghandler_pagecache-t.c: Log handler receives const strings now storage/maria/unittest/ma_test_loghandler_purge-t.c: Log handler receives const strings now
139 lines
4.9 KiB
C
139 lines
4.9 KiB
C
/* Copyright (C) 2006 MySQL AB & MySQL Finland AB & TCX DataKonsult AB
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */
|
|
|
|
/*
|
|
Rename a table
|
|
*/
|
|
|
|
#include "ma_fulltext.h"
|
|
#include "trnman_public.h"
|
|
|
|
/**
|
|
@brief renames a table
|
|
|
|
@param old_name current name of table
|
|
@param new_name table should be renamed to this name
|
|
|
|
@return Operation status
|
|
@retval 0 OK
|
|
@retval !=0 Error
|
|
*/
|
|
|
|
int maria_rename(const char *old_name, const char *new_name)
|
|
{
|
|
char from[FN_REFLEN],to[FN_REFLEN];
|
|
int data_file_rename_error;
|
|
#ifdef USE_RAID
|
|
uint raid_type=0,raid_chunks=0;
|
|
#endif
|
|
MARIA_HA *info;
|
|
MARIA_SHARE *share;
|
|
myf sync_dir;
|
|
DBUG_ENTER("maria_rename");
|
|
|
|
#ifdef EXTRA_DEBUG
|
|
_ma_check_table_is_closed(old_name,"rename old_table");
|
|
_ma_check_table_is_closed(new_name,"rename new table2");
|
|
#endif
|
|
/** @todo LOCK take X-lock on table */
|
|
if (!(info= maria_open(old_name, O_RDWR, HA_OPEN_FOR_REPAIR)))
|
|
DBUG_RETURN(my_errno);
|
|
share= info->s;
|
|
#ifdef USE_RAID
|
|
raid_type = share->base.raid_type;
|
|
raid_chunks = share->base.raid_chunks;
|
|
#endif
|
|
|
|
/*
|
|
the renaming of an internal table to the final table (like in ALTER TABLE)
|
|
is the moment when this table receives its correct create_rename_lsn and
|
|
this is important; make sure transactionality has been re-enabled.
|
|
*/
|
|
DBUG_ASSERT(share->now_transactional == share->base.born_transactional);
|
|
sync_dir= (share->now_transactional && !share->temporary &&
|
|
!maria_in_recovery) ? MY_SYNC_DIR : 0;
|
|
if (sync_dir)
|
|
{
|
|
LSN lsn;
|
|
LEX_CUSTRING log_array[TRANSLOG_INTERNAL_PARTS + 2];
|
|
uint old_name_len= strlen(old_name)+1, new_name_len= strlen(new_name)+1;
|
|
log_array[TRANSLOG_INTERNAL_PARTS + 0].str= old_name;
|
|
log_array[TRANSLOG_INTERNAL_PARTS + 0].length= old_name_len;
|
|
log_array[TRANSLOG_INTERNAL_PARTS + 1].str= new_name;
|
|
log_array[TRANSLOG_INTERNAL_PARTS + 1].length= new_name_len;
|
|
/*
|
|
For this record to be of any use for Recovery, we need the upper
|
|
MySQL layer to be crash-safe, which it is not now (that would require
|
|
work using the ddl_log of sql/sql_table.cc); when it is, we should
|
|
reconsider the moment of writing this log record (before or after op,
|
|
under THR_LOCK_maria or not...), how to use it in Recovery.
|
|
For now it can serve to apply logs to a backup so we sync it.
|
|
*/
|
|
if (unlikely(translog_write_record(&lsn, LOGREC_REDO_RENAME_TABLE,
|
|
&dummy_transaction_object, NULL,
|
|
old_name_len + new_name_len,
|
|
sizeof(log_array)/sizeof(log_array[0]),
|
|
log_array, NULL, NULL) ||
|
|
translog_flush(lsn)))
|
|
{
|
|
maria_close(info);
|
|
DBUG_RETURN(1);
|
|
}
|
|
/*
|
|
store LSN into file, needed for Recovery to not be confused if a
|
|
RENAME happened (applying REDOs to the wrong table).
|
|
*/
|
|
if (_ma_update_state_lsns(share, lsn, TRUE, TRUE))
|
|
{
|
|
maria_close(info);
|
|
DBUG_RETURN(1);
|
|
}
|
|
}
|
|
|
|
maria_close(info);
|
|
#ifdef USE_RAID
|
|
#ifdef EXTRA_DEBUG
|
|
_ma_check_table_is_closed(old_name,"rename raidcheck");
|
|
#endif
|
|
#endif /* USE_RAID */
|
|
|
|
fn_format(from,old_name,"",MARIA_NAME_IEXT,MY_UNPACK_FILENAME|MY_APPEND_EXT);
|
|
fn_format(to,new_name,"",MARIA_NAME_IEXT,MY_UNPACK_FILENAME|MY_APPEND_EXT);
|
|
if (my_rename_with_symlink(from, to, MYF(MY_WME | sync_dir)))
|
|
DBUG_RETURN(my_errno);
|
|
fn_format(from,old_name,"",MARIA_NAME_DEXT,MY_UNPACK_FILENAME|MY_APPEND_EXT);
|
|
fn_format(to,new_name,"",MARIA_NAME_DEXT,MY_UNPACK_FILENAME|MY_APPEND_EXT);
|
|
#ifdef USE_RAID
|
|
if (raid_type)
|
|
data_file_rename_error= my_raid_rename(from, to, raid_chunks,
|
|
MYF(MY_WME | sync_dir));
|
|
else
|
|
#endif
|
|
data_file_rename_error=
|
|
my_rename_with_symlink(from, to, MYF(MY_WME | sync_dir));
|
|
if (data_file_rename_error)
|
|
{
|
|
/*
|
|
now we have a renamed index file and a non-renamed data file, try to
|
|
undo the rename of the index file.
|
|
*/
|
|
data_file_rename_error= my_errno;
|
|
fn_format(from, old_name, "", MARIA_NAME_IEXT, MYF(MY_UNPACK_FILENAME|MY_APPEND_EXT));
|
|
fn_format(to, new_name, "", MARIA_NAME_IEXT, MYF(MY_UNPACK_FILENAME|MY_APPEND_EXT));
|
|
my_rename_with_symlink(to, from, MYF(MY_WME | sync_dir));
|
|
}
|
|
DBUG_RETURN(data_file_rename_error);
|
|
|
|
}
|