mirror of
https://github.com/MariaDB/server.git
synced 2025-01-19 21:42:35 +01:00
f50c4207f2
partition is corrupt The main problem was that ALTER TABLE t ANALYZE/CHECK/OPTIMIZE/REPAIR PARTITION took another code path (over mysql_alter_table instead of mysql_admin_table) which differs in two ways: 1) alter table opens the tables in a different way than admin tables do resulting in returning with error before it tried the command 2) alter table does not start to send any diagnostic rows to the client which the lower admin functions continue to use -> resulting in assertion crash The fix: Remapped ALTER TABLE t ANALYZE/CHECK/OPTIMIZE/REPAIR PARTITION to use the same code path as ANALYZE/CHECK/OPTIMIZE/REPAIR TABLE t. Adding check in mysql_admin_table to setup the partition list for which partitions that should be used. Partitioned tables will still not work with REPAIR TABLE/PARTITION USE_FRM, since that requires moving partitions to tables, REPAIR TABLE t USE_FRM, and check that the data still fulfills the partitioning function and then move the table back to being a partition. NOTE: I have removed the following functions from the handler interface: analyze_partitions, check_partitions, optimize_partitions, repair_partitions Since they are not longer needed. THIS ALTERS THE STORAGE ENGINE API mysql-test/r/handler_innodb.result: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Added a note result row. mysql-test/r/innodb.result: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Added a note result row. mysql-test/r/innodb_mysql.result: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Added a note result row. mysql-test/r/partition.result: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Updated after fixing ANALYZE/CHECK/OPTIMIZE/REPAIR partitioned tables. mysql-test/r/trigger-trans.result: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Added a note result row. mysql-test/suite/ndb/r/ndb_partition_key.result: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Updated after fixing ANALYZE/CHECK/OPTIMIZE/REPAIR partitioned tables. mysql-test/suite/ndb/t/ndb_partition_key.test: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Updated after fixing ANALYZE/CHECK/OPTIMIZE/REPAIR partitioned tables. mysql-test/suite/parts/inc/partition_alter4.inc: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Updated after fixing ANALYZE/CHECK/OPTIMIZE/REPAIR partitioned tables. mysql-test/suite/parts/r/partition_alter4_innodb.result: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Updated after fixing ANALYZE/CHECK/OPTIMIZE/REPAIR partitioned tables. mysql-test/suite/parts/r/partition_alter4_myisam.result: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Updated after fixing ANALYZE/CHECK/OPTIMIZE/REPAIR partitioned tables. mysql-test/suite/rpl/r/rpl_failed_optimize.result: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Added a note result row. mysql-test/suite/rpl/r/rpl_innodb_mixed_dml.result: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Added a note result row. mysql-test/t/partition.test: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Updated after fixing ANALYZE/CHECK/OPTIMIZE/REPAIR partitioned tables. sql/ha_partition.cc: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Added a function for returning admin commands result rows Updated handle_opt_partitions to handle admin commands result rows, and some error filtering (as mysql_admin_table do). Removed the functions analyze/check/optimize/repair_partitions since they have no longer any use. sql/ha_partition.h: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Removed analyze/check/optimize/repair_partitions since they are no longer are needed. sql/handler.cc: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Removed analyze/check/optimize/repair_partitions since they are no longer are needed. sql/handler.h: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Removed analyze/check/optimize/repair_partitions since they are no longer are needed. sql/mysql_priv.h: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Added set_part_state for reuse of code in mysql_admin_table. (Originally fond in sql/sql_partition.cc:prep_alter_part_table) sql/protocol.cc: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Added one assert and a debug print. sql/sql_partition.cc: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Refactored code for setting up partition state, set_part_state, now used in both prep_alter_part_table and sql_table.cc:mysql_admin_table. Removed code for handling ANALYZE/CHECK/OPTIMIZE/REPAIR partitions, since it is now handled by mysql_admin_table. sql/sql_table.cc: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Added functionality in mysql_admin_table to work with partitioned tables. Fixed a possible assertion bug for HA_ADMIN_TRY_ALTER (If analyze would output a row, it fails since the row was already started). sql/sql_yacc.yy: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Remapped ALTER TABLE t ANALYZE/CHECK/OPTIMIZE/REPAIR PARTITION to use the same code path as ANALYZE/CHECK/OPTIMIZE/REPAIR TABLE instead of taking the ALTER TABLE path. Added reset of alter_info for ANALYZE/CHECK/OPTIMIZE/REPAIR TABLE since it is now used by partitioned tables. storage/myisam/mi_check.c: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Changed warning message from "Found X parts Should be: Y parts" to "Found X key parts. Should be Y", since it could be confusing with partitioned tables. |
||
|---|---|---|
| .. | ||
| disabled.def | ||
| loaddata_autocom_ndb.test | ||
| ndb_alter_table.test | ||
| ndb_alter_table2.test | ||
| ndb_alter_table3.test | ||
| ndb_auto_increment.test | ||
| ndb_autoinc.test | ||
| ndb_basic.test | ||
| ndb_binlog_basic.test | ||
| ndb_binlog_ddl_multi.test | ||
| ndb_binlog_discover.test | ||
| ndb_binlog_format.test | ||
| ndb_binlog_ignore_db-master.opt | ||
| ndb_binlog_ignore_db.test | ||
| ndb_binlog_log_bin.test | ||
| ndb_binlog_multi.test | ||
| ndb_bitfield.test | ||
| ndb_blob.test | ||
| ndb_blob_partition.test | ||
| ndb_bug26793.test | ||
| ndb_bug31477.test | ||
| ndb_cache.test | ||
| ndb_cache2.test | ||
| ndb_cache_multi.test | ||
| ndb_cache_multi2.test | ||
| ndb_charset.test | ||
| ndb_condition_pushdown.test | ||
| ndb_config.test | ||
| ndb_config2.test | ||
| ndb_cursor.test | ||
| ndb_database.test | ||
| ndb_dd_alter.test | ||
| ndb_dd_basic.test | ||
| ndb_dd_ddl.test | ||
| ndb_dd_disk2memory.test | ||
| ndb_dd_dump.test | ||
| ndb_dd_sql_features.test | ||
| ndb_gis.test | ||
| ndb_grant.later | ||
| ndb_index.test | ||
| ndb_index_ordered.test | ||
| ndb_index_unique.test | ||
| ndb_insert.test | ||
| ndb_limit.test | ||
| ndb_load.test | ||
| ndb_loaddatalocal.test | ||
| ndb_lock.test | ||
| ndb_lock_table.test | ||
| ndb_minmax.test | ||
| ndb_multi.test | ||
| ndb_multi_row.test | ||
| ndb_partition_error.test | ||
| ndb_partition_error2-master.opt | ||
| ndb_partition_error2.test | ||
| ndb_partition_key.test | ||
| ndb_partition_list.test | ||
| ndb_partition_range.test | ||
| ndb_read_multi_range.test | ||
| ndb_rename.test | ||
| ndb_replace.test | ||
| ndb_restore.test | ||
| ndb_restore_compat.test | ||
| ndb_restore_different_endian_data.test | ||
| ndb_restore_partition-master.opt | ||
| ndb_restore_partition.test | ||
| ndb_restore_print.test | ||
| ndb_row_format.test | ||
| ndb_single_user.test | ||
| ndb_sp.test | ||
| ndb_subquery.test | ||
| ndb_temporary.test | ||
| ndb_transaction.test | ||
| ndb_trigger.test | ||
| ndb_truncate.test | ||
| ndb_types.test | ||
| ndb_update.test | ||
| ndb_update_no_read.test | ||
| ndb_view.test | ||
| ndbapi.test | ||
| ps_7ndb.test | ||
| strict_autoinc_5ndb.test | ||