mirror of
https://github.com/MariaDB/server.git
synced 2025-01-20 05:52:27 +01:00
f50c4207f2
partition is corrupt The main problem was that ALTER TABLE t ANALYZE/CHECK/OPTIMIZE/REPAIR PARTITION took another code path (over mysql_alter_table instead of mysql_admin_table) which differs in two ways: 1) alter table opens the tables in a different way than admin tables do resulting in returning with error before it tried the command 2) alter table does not start to send any diagnostic rows to the client which the lower admin functions continue to use -> resulting in assertion crash The fix: Remapped ALTER TABLE t ANALYZE/CHECK/OPTIMIZE/REPAIR PARTITION to use the same code path as ANALYZE/CHECK/OPTIMIZE/REPAIR TABLE t. Adding check in mysql_admin_table to setup the partition list for which partitions that should be used. Partitioned tables will still not work with REPAIR TABLE/PARTITION USE_FRM, since that requires moving partitions to tables, REPAIR TABLE t USE_FRM, and check that the data still fulfills the partitioning function and then move the table back to being a partition. NOTE: I have removed the following functions from the handler interface: analyze_partitions, check_partitions, optimize_partitions, repair_partitions Since they are not longer needed. THIS ALTERS THE STORAGE ENGINE API mysql-test/r/handler_innodb.result: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Added a note result row. mysql-test/r/innodb.result: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Added a note result row. mysql-test/r/innodb_mysql.result: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Added a note result row. mysql-test/r/partition.result: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Updated after fixing ANALYZE/CHECK/OPTIMIZE/REPAIR partitioned tables. mysql-test/r/trigger-trans.result: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Added a note result row. mysql-test/suite/ndb/r/ndb_partition_key.result: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Updated after fixing ANALYZE/CHECK/OPTIMIZE/REPAIR partitioned tables. mysql-test/suite/ndb/t/ndb_partition_key.test: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Updated after fixing ANALYZE/CHECK/OPTIMIZE/REPAIR partitioned tables. mysql-test/suite/parts/inc/partition_alter4.inc: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Updated after fixing ANALYZE/CHECK/OPTIMIZE/REPAIR partitioned tables. mysql-test/suite/parts/r/partition_alter4_innodb.result: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Updated after fixing ANALYZE/CHECK/OPTIMIZE/REPAIR partitioned tables. mysql-test/suite/parts/r/partition_alter4_myisam.result: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Updated after fixing ANALYZE/CHECK/OPTIMIZE/REPAIR partitioned tables. mysql-test/suite/rpl/r/rpl_failed_optimize.result: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Added a note result row. mysql-test/suite/rpl/r/rpl_innodb_mixed_dml.result: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Added a note result row. mysql-test/t/partition.test: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Updated after fixing ANALYZE/CHECK/OPTIMIZE/REPAIR partitioned tables. sql/ha_partition.cc: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Added a function for returning admin commands result rows Updated handle_opt_partitions to handle admin commands result rows, and some error filtering (as mysql_admin_table do). Removed the functions analyze/check/optimize/repair_partitions since they have no longer any use. sql/ha_partition.h: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Removed analyze/check/optimize/repair_partitions since they are no longer are needed. sql/handler.cc: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Removed analyze/check/optimize/repair_partitions since they are no longer are needed. sql/handler.h: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Removed analyze/check/optimize/repair_partitions since they are no longer are needed. sql/mysql_priv.h: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Added set_part_state for reuse of code in mysql_admin_table. (Originally fond in sql/sql_partition.cc:prep_alter_part_table) sql/protocol.cc: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Added one assert and a debug print. sql/sql_partition.cc: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Refactored code for setting up partition state, set_part_state, now used in both prep_alter_part_table and sql_table.cc:mysql_admin_table. Removed code for handling ANALYZE/CHECK/OPTIMIZE/REPAIR partitions, since it is now handled by mysql_admin_table. sql/sql_table.cc: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Added functionality in mysql_admin_table to work with partitioned tables. Fixed a possible assertion bug for HA_ADMIN_TRY_ALTER (If analyze would output a row, it fails since the row was already started). sql/sql_yacc.yy: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Remapped ALTER TABLE t ANALYZE/CHECK/OPTIMIZE/REPAIR PARTITION to use the same code path as ANALYZE/CHECK/OPTIMIZE/REPAIR TABLE instead of taking the ALTER TABLE path. Added reset of alter_info for ANALYZE/CHECK/OPTIMIZE/REPAIR TABLE since it is now used by partitioned tables. storage/myisam/mi_check.c: Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that partition is corrupt Changed warning message from "Found X parts Should be: Y parts" to "Found X key parts. Should be Y", since it could be confusing with partitioned tables.
293 lines
7.6 KiB
Text
293 lines
7.6 KiB
Text
DROP TABLE IF EXISTS t1;
|
|
CREATE TABLE t1 (a int, b int, c int, d int, PRIMARY KEY(a,b,c))
|
|
ENGINE = NDB
|
|
PARTITION BY KEY (a,b);
|
|
insert into t1 values (1,1,1,1);
|
|
select * from t1;
|
|
a b c d
|
|
1 1 1 1
|
|
update t1 set d = 2 where a = 1 and b = 1 and c = 1;
|
|
select * from t1;
|
|
a b c d
|
|
1 1 1 2
|
|
delete from t1;
|
|
select * from t1;
|
|
a b c d
|
|
drop table t1;
|
|
CREATE TABLE t1 (a int, b int, c int, d int, PRIMARY KEY(a,b))
|
|
ENGINE = NDB
|
|
PARTITION BY KEY (c);
|
|
ERROR HY000: A PRIMARY KEY must include all columns in the table's partitioning function
|
|
CREATE TABLE t1 (a int, b int, c int, PRIMARY KEY(a,b))
|
|
ENGINE = NDB
|
|
PARTITION BY KEY (a);
|
|
insert into t1 values
|
|
(1,1,3),(1,2,3),(1,3,3),(1,4,3),(1,5,3),(1,6,3),
|
|
(1,7,3),(1,8,3),(1,9,3),(1,10,3),(1,11,3),(1,12,3);
|
|
select * from t1 order by b;
|
|
a b c
|
|
1 1 3
|
|
1 2 3
|
|
1 3 3
|
|
1 4 3
|
|
1 5 3
|
|
1 6 3
|
|
1 7 3
|
|
1 8 3
|
|
1 9 3
|
|
1 10 3
|
|
1 11 3
|
|
1 12 3
|
|
select max(b) from t1 where a = 1;
|
|
max(b)
|
|
12
|
|
select b from t1 where a = 1 order by b desc;
|
|
b
|
|
12
|
|
11
|
|
10
|
|
9
|
|
8
|
|
7
|
|
6
|
|
5
|
|
4
|
|
3
|
|
2
|
|
1
|
|
DROP TABLE t1;
|
|
CREATE TABLE t1 (a INT, b CHAR(10) COLLATE latin1_bin, c INT, d INT,
|
|
PRIMARY KEY (a,b,c) USING HASH)
|
|
ENGINE=NDB
|
|
DEFAULT CHARSET=latin1
|
|
PARTITION BY KEY (b);
|
|
insert into t1 values (1,"a",1,1),(2,"a",1,1),(3,"a",1,1);
|
|
-- t1 --
|
|
|
|
Fragment type: 5
|
|
K Value: 6
|
|
Min load factor: 78
|
|
Max load factor: 80
|
|
Temporary table: no
|
|
Number of attributes: 4
|
|
Number of primary keys: 3
|
|
Length of frm data: #
|
|
Row Checksum: 1
|
|
Row GCI: 1
|
|
SingleUserMode: 0
|
|
ForceVarPart: 1
|
|
TableStatus: Retrieved
|
|
-- Attributes --
|
|
a Int PRIMARY KEY AT=FIXED ST=MEMORY
|
|
b Char(10;latin1_bin) PRIMARY KEY DISTRIBUTION KEY AT=FIXED ST=MEMORY
|
|
c Int PRIMARY KEY AT=FIXED ST=MEMORY
|
|
d Int NULL AT=FIXED ST=MEMORY
|
|
|
|
-- Indexes --
|
|
PRIMARY KEY(a, b, c) - UniqueHashIndex
|
|
|
|
|
|
NDBT_ProgramExit: 0 - OK
|
|
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`a` int(11) NOT NULL DEFAULT '0',
|
|
`b` char(10) CHARACTER SET latin1 COLLATE latin1_bin NOT NULL DEFAULT '',
|
|
`c` int(11) NOT NULL DEFAULT '0',
|
|
`d` int(11) DEFAULT NULL,
|
|
PRIMARY KEY (`a`,`b`,`c`) USING HASH
|
|
) ENGINE=ndbcluster DEFAULT CHARSET=latin1 /*!50100 PARTITION BY KEY (b) */
|
|
DROP TABLE t1;
|
|
CREATE TABLE t1 (a int not null primary key)
|
|
PARTITION BY KEY(a)
|
|
(PARTITION p0 ENGINE = NDB, PARTITION p1 ENGINE = NDB);
|
|
drop table t1;
|
|
CREATE TABLE t1 (a int not null primary key);
|
|
ALTER TABLE t1
|
|
ENGINE = NDB
|
|
PARTITION BY KEY(a)
|
|
(PARTITION p0 ENGINE = NDB, PARTITION p1 ENGINE = NDB);
|
|
drop table t1;
|
|
CREATE TABLE t1 (a int not null primary key) ENGINE = NDB;
|
|
ALTER TABLE t1
|
|
PARTITION BY KEY(a)
|
|
(PARTITION p0 ENGINE = NDB, PARTITION p1 ENGINE = NDB);
|
|
drop table t1;
|
|
create table t1 (a int)
|
|
engine=ndb
|
|
partition by key(a)
|
|
(partition p0, partition p1);
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`a` int(11) DEFAULT NULL
|
|
) ENGINE=ndbcluster DEFAULT CHARSET=latin1 /*!50100 PARTITION BY KEY (a) (PARTITION p0 ENGINE = ndbcluster, PARTITION p1 ENGINE = ndbcluster) */
|
|
alter table t1 engine=heap;
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`a` int(11) DEFAULT NULL
|
|
) ENGINE=MEMORY DEFAULT CHARSET=latin1 /*!50100 PARTITION BY KEY (a) (PARTITION p0 ENGINE = MEMORY, PARTITION p1 ENGINE = MEMORY) */
|
|
alter table t1 engine=ndb;
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`a` int(11) DEFAULT NULL
|
|
) ENGINE=ndbcluster DEFAULT CHARSET=latin1 /*!50100 PARTITION BY KEY (a) (PARTITION p0 ENGINE = ndbcluster, PARTITION p1 ENGINE = ndbcluster) */
|
|
alter table t1 engine=heap remove partitioning;
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`a` int(11) DEFAULT NULL
|
|
) ENGINE=MEMORY DEFAULT CHARSET=latin1
|
|
alter table t1 engine=ndb
|
|
partition by key(a)
|
|
(partition p0, partition p1 engine = ndb);
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`a` int(11) DEFAULT NULL
|
|
) ENGINE=ndbcluster DEFAULT CHARSET=latin1 /*!50100 PARTITION BY KEY (a) (PARTITION p0 ENGINE = ndbcluster, PARTITION p1 ENGINE = ndbcluster) */
|
|
alter table t1
|
|
partition by key (a)
|
|
(partition p0 engine=ndb, partition p1 engine=ndb);
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`a` int(11) DEFAULT NULL
|
|
) ENGINE=ndbcluster DEFAULT CHARSET=latin1 /*!50100 PARTITION BY KEY (a) (PARTITION p0 ENGINE = ndbcluster, PARTITION p1 ENGINE = ndbcluster) */
|
|
alter table t1 remove partitioning;
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`a` int(11) DEFAULT NULL
|
|
) ENGINE=ndbcluster DEFAULT CHARSET=latin1
|
|
alter table t1
|
|
partition by key(a)
|
|
(partition p0 engine=ndb, partition p1);
|
|
alter table t1
|
|
engine=ndb
|
|
partition by key(a)
|
|
(partition p0 engine=ndb, partition p1 engine = ndb);
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`a` int(11) DEFAULT NULL
|
|
) ENGINE=ndbcluster DEFAULT CHARSET=latin1 /*!50100 PARTITION BY KEY (a) (PARTITION p0 ENGINE = ndbcluster, PARTITION p1 ENGINE = ndbcluster) */
|
|
drop table t1;
|
|
CREATE TABLE t1 (
|
|
c1 MEDIUMINT NOT NULL AUTO_INCREMENT,
|
|
c2 TEXT NOT NULL,
|
|
c3 INT NOT NULL,
|
|
c4 BIT NOT NULL,
|
|
c5 FLOAT,
|
|
c6 VARCHAR(255),
|
|
c7 TIMESTAMP,
|
|
PRIMARY KEY(c1,c3))
|
|
ENGINE=NDB
|
|
PARTITION BY KEY(c3) PARTITIONS 5;
|
|
ALTER TABLE t1 COALESCE PARTITION 4;
|
|
DROP TABLE t1;
|
|
CREATE TABLE t1 (a int primary key)
|
|
ENGINE=NDB
|
|
PARTITION BY KEY(a);
|
|
ANALYZE TABLE t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 analyze note The storage engine for the table doesn't support analyze
|
|
CHECK TABLE t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 check note The storage engine for the table doesn't support check
|
|
OPTIMIZE TABLE t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 optimize note The storage engine for the table doesn't support optimize
|
|
REPAIR TABLE t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 repair note The storage engine for the table doesn't support repair
|
|
ALTER TABLE t1 OPTIMIZE PARTITION p0;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 optimize note The storage engine for the table doesn't support optimize
|
|
ALTER TABLE t1 CHECK PARTITION p0;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 check note The storage engine for the table doesn't support check
|
|
ALTER TABLE t1 REPAIR PARTITION p0;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 repair note The storage engine for the table doesn't support repair
|
|
ALTER TABLE t1 ANALYZE PARTITION p0;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 analyze note The storage engine for the table doesn't support analyze
|
|
ALTER TABLE t1 REBUILD PARTITION p0;
|
|
ERROR HY000: Table storage engine for 't1' doesn't have this option
|
|
DROP TABLE t1;
|
|
CREATE TABLE t1 (
|
|
c1 MEDIUMINT NOT NULL AUTO_INCREMENT,
|
|
c2 TEXT NOT NULL,
|
|
c3 INT NOT NULL,
|
|
PRIMARY KEY(c1,c3))
|
|
ENGINE=NDB
|
|
PARTITION BY KEY(c3) PARTITIONS 5;
|
|
ALTER TABLE t1 ADD COLUMN c4 INT AFTER c1;
|
|
DROP TABLE t1;
|
|
CREATE TABLE t1 (
|
|
c1 MEDIUMINT NOT NULL AUTO_INCREMENT,
|
|
c2 TEXT NOT NULL,
|
|
c3 INT NOT NULL,
|
|
PRIMARY KEY(c1,c3))
|
|
ENGINE=NDB
|
|
PARTITION BY KEY(c3)
|
|
(PARTITION p0 NODEGROUP 0, PARTITION p1 NODEGROUP 0);
|
|
ALTER TABLE t1 ADD COLUMN c4 INT AFTER c1;
|
|
SELECT NODEGROUP,PARTITION_NAME FROM information_schema.partitions WHERE
|
|
table_name = "t1";
|
|
NODEGROUP PARTITION_NAME
|
|
0 p0
|
|
0 p1
|
|
DROP TABLE t1;
|
|
CREATE TABLE t1 (
|
|
a tinyint unsigned NOT NULL,
|
|
b bigint(20) unsigned NOT NULL,
|
|
c char(12),
|
|
PRIMARY KEY (a,b)
|
|
) ENGINE ndb DEFAULT CHARSET=latin1 PARTITION BY KEY (a);
|
|
insert into t1 values(1,1,'1'), (2,2,'2'), (3,3,'3'), (4,4,'4'), (5,5,'5');
|
|
select * from t1 where a = 1;
|
|
a b c
|
|
1 1 1
|
|
select * from t1 where a = 2;
|
|
a b c
|
|
2 2 2
|
|
select * from t1 where a = 3;
|
|
a b c
|
|
3 3 3
|
|
select * from t1 where a = 4;
|
|
a b c
|
|
4 4 4
|
|
select * from t1 where a = 5;
|
|
a b c
|
|
5 5 5
|
|
delete from t1 where a = 1;
|
|
select * from t1 order by 1;
|
|
a b c
|
|
2 2 2
|
|
3 3 3
|
|
4 4 4
|
|
5 5 5
|
|
delete from t1 where a = 2;
|
|
select * from t1 order by 1;
|
|
a b c
|
|
3 3 3
|
|
4 4 4
|
|
5 5 5
|
|
delete from t1 where a = 3;
|
|
select * from t1 order by 1;
|
|
a b c
|
|
4 4 4
|
|
5 5 5
|
|
delete from t1 where a = 4;
|
|
select * from t1 order by 1;
|
|
a b c
|
|
5 5 5
|
|
delete from t1 where a = 5;
|
|
select * from t1 order by 1;
|
|
a b c
|
|
drop table t1;
|